Don't load every commit if there are no local hashes
ClosedPublic
Actions

Authored by epriestley on Apr 11 2014, 1:09 AM.

Tags

None

Referenced Files

	F15440809: D8758.diff
	Wed, Mar 26, 2:42 PM

	F15424840: D8758.id20764.diff
	Sun, Mar 23, 12:26 AM

	F15417227: D8758.id.diff
	Thu, Mar 20, 4:10 PM

	F15416081: D8758.id20765.diff
	Thu, Mar 20, 9:06 AM

	F15409237: D8758.diff
	Wed, Mar 19, 3:44 AM

	F15393730: D8758.id20764.diff
	Sat, Mar 15, 11:04 PM

	F15393729: D8758.id.diff
	Sat, Mar 15, 11:04 PM

	F15393727: D8758.diff
	Sat, Mar 15, 11:04 PM

View All Files

Subscribers

chad

epriestley

Details

Reviewers

btrahan
sophiebits

Commits

Restricted Diffusion Commit
rP650bc97ed704: Don't load every commit if there are no local hashes

Summary

We make a silly query for every commit if you copy/paste a diff.

Test Plan

Copy/pasted diffs now render in fewer than 30 seconds.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20764.Apr 11 2014, 1:09 AM

epriestley retitled this revision from to Don't load every commit if there are no local hashes.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: sophiebits, btrahan.

Herald added a subscriber: epriestley.Apr 11 2014, 1:09 AM

Thanks!

This revision is now accepted and ready to land.Apr 11 2014, 1:09 AM

Suuure.

Closed by commit rP650bc97ed704 (authored by @epriestley).

Was this the fishing trip?

Yeah. I think we can fix this a little more systematically, we've hit a somewhat-similar issue or two in the past but nothing that required fishing.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialRevisionViewController.php

17 lines

Diff 20765

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Don't load every commit if there are no local hashesClosedPublicActions