Page MenuHomePhabricator

Don't load every commit if there are no local hashes
ClosedPublic

Authored by epriestley on Apr 11 2014, 1:09 AM.

Details

Summary

We make a silly query for every commit if you copy/paste a diff.

Test Plan

Copy/pasted diffs now render in fewer than 30 seconds.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20764.Apr 11 2014, 1:09 AM
epriestley retitled this revision from to Don't load every commit if there are no local hashes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: sophiebits, btrahan.
btrahan accepted this revision.Apr 11 2014, 1:09 AM
btrahan edited edge metadata.

Thanks!

This revision is now accepted and ready to land.Apr 11 2014, 1:09 AM
sophiebits accepted this revision.Apr 11 2014, 1:09 AM
sophiebits edited edge metadata.

Suuure.

epriestley closed this revision.Apr 11 2014, 1:09 AM
epriestley updated this revision to Diff 20765.

Closed by commit rP650bc97ed704 (authored by @epriestley).

chad added a subscriber: chad.Apr 11 2014, 1:10 AM

Was this the fishing trip?

Yeah. I think we can fix this a little more systematically, we've hit a somewhat-similar issue or two in the past but nothing that required fishing.