Page MenuHomePhabricator

Make Cmd+Enter work to submit a form
ClosedPublic

Authored by sophiebits on Apr 4 2014, 1:59 AM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP077f57f06dee: Make Cmd+Enter work to submit a form
Summary

Fixes T3010.

keydown is what you're supposed to use for special keys like Enter; keypress didn't work for me for Cmd+Enter on Chrome.

Test Plan

Submitted a Differential field with Cmd+Enter on Chrome Mac. Also made sure Ctrl+Enter still works and Opt+Enter does not.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

sophiebits updated this revision to Diff 20632.Apr 4 2014, 1:59 AM
sophiebits added a task: Restricted Maniphest Task.
sophiebits retitled this revision from to Make Cmd+Enter work to submit a form.
sophiebits updated this object.
sophiebits edited the test plan for this revision. (Show Details)
sophiebits added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley.
epriestley accepted this revision.Apr 4 2014, 2:00 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 4 2014, 2:00 AM
epriestley closed this revision.Apr 4 2014, 2:00 AM
epriestley updated this revision to Diff 20633.

Closed by commit rP077f57f06dee (authored by @spicyj, committed by @epriestley).