Add --no-verify to git commit call for arc patch
ClosedPublic
Actions

Authored by sophiebits on Jun 14 2014, 12:05 AM.

Tags

None

Referenced Files

	F18368598: D9523.id22825.diff
	Thu, Aug 28, 1:13 AM

	F18367867: D9523.id22949.diff
	Thu, Aug 28, 12:12 AM

	F18365195: D9523.id.diff
	Wed, Aug 27, 8:36 PM

	F18364938: D9523.id22825.diff
	Wed, Aug 27, 8:07 PM

	F18229886: D9523.id.diff
	Wed, Aug 20, 11:42 AM

	F18219825: D9523.diff
	Tue, Aug 19, 12:30 PM

	F18118867: D9523.id22949.diff
	Wed, Aug 13, 9:15 AM

	F18118863: D9523.id22825.diff
	Wed, Aug 13, 9:14 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCee3baade6ebf: Add --no-verify to git commit call for arc patch

Summary

I can't find an analogous flag for hg.

Test Plan

I don't have any precommit hooks set up on my machine so I can't test this easily, but I think this seems pretty harmless?

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

sophiebits updated this revision to Diff 22825.Jun 14 2014, 12:05 AM

sophiebits retitled this revision from to Add --no-verify to git commit call for arc patch.

sophiebits updated this object.

sophiebits edited the test plan for this revision. (Show Details)

sophiebits added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 14 2014, 12:05 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1072: Diff 22825.Jun 14 2014, 12:06 AM

epriestley accepted this revision.Jun 16 2014, 6:39 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 16 2014, 6:39 PM

Closed by commit rARCee3baade6ebf (authored by @spicyj, committed by @epriestley).

Thanks.

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistPatchWorkflow.php

2 lines

Diff 22949

View Options

src/workflow/ArcanistPatchWorkflow.php

Add --no-verify to git commit call for arc patchClosedPublicActions