Page MenuHomePhabricator

Fix bugs in python lexer
ClosedPublic

Authored by sophiebits on Jun 6 2014, 12:23 AM.

Details

Summary

Two things:

  • The appearance of \\ or \' or \-followed-by-a-newline in a raw string would improperly end the string
  • A disallowed newline in a string would cause an error instead of trying to continue anyway
Test Plan

Ran it on a file that was failing for me that was something like:

x = r'\\"'
# hello there

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

sophiebits updated this revision to Diff 22439.Jun 6 2014, 12:23 AM
sophiebits retitled this revision from to Fix bugs in python lexer.
sophiebits updated this object.
sophiebits edited the test plan for this revision. (Show Details)
sophiebits added a reviewer: epriestley.
epriestley accepted this revision.Jun 6 2014, 12:25 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 6 2014, 12:25 AM
epriestley closed this revision.Jun 6 2014, 1:10 AM
epriestley updated this revision to Diff 22445.

Closed by commit rPHU7e75bf271c66 (authored by @spicyj, committed by @epriestley).