| sophiebits | |
| Mar 17 2014, 6:56 PM |
| F130898: Screen_Shot_2014-03-17_at_12.44.33_PM.png | |
| Mar 17 2014, 7:45 PM |
I have the following Herald rule:
{F130876}
I seem to be getting emails for updates to diffs that match these criteria, but not for the initial diff creation.
Due to T4628 I can't see the transcript easily. One diff that this rule matched looks like this, which seems fine to me:
{F130880}
I believe this was introduced around Mar 11 or 12. Let me know how I can help.
Just to double check, your phabricator/ is ahead of rP0b15624c (Mar 11), right? If you're behind that, that might have fixed this. (I haven't actually tried to reproduce it at HEAD quite yet though so it might just be an issue in general.) I'll see if I can repro now.
I can't immediately reproduce this. Adding a reviewer via Herald (dolphin) generated an email to that user locally without requiring additional updates:
$ ./bin/mail show-outbound --id 15287 PROPERTIES ID: 15287 Status: queued Related PHID: PHID-DREV-dd4f6b2twuawjx3sxtsu Message: PARAMETERS subject: D1043: head from: PHID-USER-lqiz3yd7wmk64ejugvov subject-prefix: [Differential] vary-subject-prefix: [Request, 2 lines] thread-id: differential-rev-PHID-DREV-dd4f6b2twuawjx3sxtsu-req is-first-message: 1 mailtags: {"0":"differential-review-request","1":"differential-other","4":"differential-reviewers","5":"differential-cc"} is-bulk: 1 to: ["PHID-USER-n3xioxs5pjls6gy7p5cv"] worker-task: 1193889 HEADERS Thread-Topic: D1043: head X-Herald-Rules: <42>, <40>, <38>, <23>, <18>, <17>, <15> X-Phabricator-To: <PHID-USER-lqiz3yd7wmk64ejugvov> X-Phabricator-To: <PHID-USER-doikxnpzgkzdpwxsy2a2> X-Phabricator-To: <PHID-USER-n3xioxs5pjls6gy7p5cv> X-Phabricator-To: <PHID-USER-aeabc4ipqbifny3rw4ok> X-Phabricator-To: <PHID-USER-m6xxrccxh7pdexwu26lu> X-Phabricator-To: <PHID-USER-h4kwi2juszzzmr3u2yqq> X-Phabricator-To: <PHID-USER-2igufa6mcgg66yatfhlb> X-Phabricator-To: <PHID-USER-26eeorv2tbfzq5tx6im2> X-Phabricator-Cc: <PHID-USER-aeabc4ipqbifny3rw4ok> ATTACHMENTS D1043.519.patch RECIPIENTS dolphin (dolphin) BODY epriestley created this revision. epriestley added a reviewer: orange. Herald added a subscriber: duck. Herald added reviewers: dolphin, The Bureaucracy. REVISION SUMMARY body TEST PLAN test REVISION DETAIL http://local.aphront.com:8080/D1043 AFFECTED FILES number_j.txt CHANGE DETAILS Index: number_j.txt =================================================================== --- number_j.txt +++ number_j.txt @@ -137,3 +137,5 @@ j j j +j +jj To: epriestley, orange, dolphin, duck, Sebastiangarcia, Ahmedsmoore, nathanhthomas, chewnicorn Cc: duck
Let me try fixing T4628 first and see if that makes things any more clear.
Seeing something similar here. We have a rule which adds CCs and the initial review email doesnt get sent out but followups do.