Fix bad aspect ratio on some file previews
ClosedPublic
Actions

Authored by epriestley on May 12 2015, 3:32 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T4724: Some images appear with the wrong aspect ratio
T7707: Implement a read-through cache layer

Commits

Restricted Diffusion Commit
rPa19b0029e223: Fix bad aspect ratio on some file previews

Summary

Ref T7707. Fixes T4724. I misread the report on T4724; this is trivial. We're just reading the wrong properties in setting "width" and "height" attributes, the actual thumbnailing logic is fine.

Test Plan

Uploaded image from T4724, saw it have a proper aspect ratio.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 30788.May 12 2015, 3:32 PM

epriestley retitled this revision from to Fix bad aspect ratio on some file previews.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T7707: Implement a read-through cache layer, T4724: Some images appear with the wrong aspect ratio.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 12 2015, 3:32 PM

<3 thanks

chad accepted this revision.May 12 2015, 4:30 PM

chad added a reviewer: chad.

This revision is now accepted and ready to land.May 12 2015, 4:30 PM

Closed by commit rPa19b0029e223: Fix bad aspect ratio on some file previews (authored by epriestley, committed by epriestley). · Explain WhyMay 13 2015, 6:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

markup/

PhabricatorEmbedFileRemarkupRule.php

4 lines

Diff 30830

View Options

src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php

Fix bad aspect ratio on some file previewsClosedPublicActions