Page MenuHomePhabricator

Fix bad aspect ratio on some file previews
ClosedPublic

Authored by epriestley on May 12 2015, 3:32 PM.

Details

Summary

Ref T7707. Fixes T4724. I misread the report on T4724; this is trivial. We're just reading the wrong properties in setting "width" and "height" attributes, the actual thumbnailing logic is fine.

Test Plan

Uploaded image from T4724, saw it have a proper aspect ratio.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 30788.May 12 2015, 3:32 PM
epriestley retitled this revision from to Fix bad aspect ratio on some file previews.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
chad accepted this revision.May 12 2015, 4:30 PM
chad added a reviewer: chad.
This revision is now accepted and ready to land.May 12 2015, 4:30 PM
This revision was automatically updated to reflect the committed changes.