Paths

Table of Contentst

Fix binary/utf8 issues with Differential changeset parse cache
ClosedPublic
Actions

Authored by epriestley on May 17 2014, 11:24 PM.

Details

Reviewers

btrahan
sophiebits

Maniphest Tasks

T4898: Differential should cache syntax highlight

Commits

Restricted Diffusion Commit
rPd744d5d85995: Fix binary/utf8 issues with Differential changeset parse cache

Summary

Fixes T4898. After we increased the strictness of the %s conversion, most serialize() output is rejected from the cache.

Drop the cache, change the column type to latin1_bin, and then use %B to mark the data as binary during query construction.

Test Plan

Viewed Differential, saw cache fills.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21785.May 17 2014, 11:24 PM

epriestley retitled this revision from to Fix binary/utf8 issues with Differential changeset parse cache.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, sophiebits.

epriestley added a task: T4898: Differential should cache syntax highlight.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 17 2014, 11:24 PM

epriestley added inline comments.May 17 2014, 11:24 PM

src/applications/differential/parser/DifferentialChangesetParser.php
369	YES INDEED

Harbormaster completed remote builds in B537: Diff 21785.May 17 2014, 11:25 PM

yay for catching things. also caching stuff.

This revision is now accepted and ready to land.May 17 2014, 11:30 PM

Closed by commit rPd744d5d85995 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20140517.dxbinarycache.sql

4 lines

src/

applications/

differential/

parser/

DifferentialChangesetParser.php

13 lines

Diff 21786

View Options

resources/sql/autopatches/20140517.dxbinarycache.sql