Page MenuHomePhabricator

Fix binary/utf8 issues with Differential changeset parse cache
ClosedPublic

Authored by epriestley on May 17 2014, 11:24 PM.

Details

Summary

Fixes T4898. After we increased the strictness of the %s conversion, most serialize() output is rejected from the cache.

Drop the cache, change the column type to latin1_bin, and then use %B to mark the data as binary during query construction.

Test Plan

Viewed Differential, saw cache fills.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix binary/utf8 issues with Differential changeset parse cache.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, sophiebits.
epriestley added inline comments.May 17 2014, 11:24 PM
src/applications/differential/parser/DifferentialChangesetParser.php
369

YES INDEED

sophiebits accepted this revision.May 17 2014, 11:30 PM
sophiebits edited edge metadata.

yay for catching things. also caching stuff.

This revision is now accepted and ready to land.May 17 2014, 11:30 PM
epriestley closed this revision.May 17 2014, 11:34 PM
epriestley updated this revision to Diff 21786.

Closed by commit rPd744d5d85995 (authored by @epriestley).