Page MenuHomePhabricator

Restore "Branch" and "changes since last update" fields to Differential mail
ClosedPublic

Authored by epriestley on Mar 31 2014, 7:28 PM.

Details

Summary

Ref T418. Fixes T4642. The "changes since last update" and "branch" fields got dropped; restore them in a general, field-driven way.

Test Plan
  • Created a revision, got relevant sections in mail.
  • Commented on a revision, got relevant sections in mail.
  • Updated a revision, got relevant sections in mail.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20529.Mar 31 2014, 7:28 PM
epriestley retitled this revision from to Restore "Brach" and "changes since last update" fields to Differential mail.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
chad retitled this revision from Restore "Brach" and "changes since last update" fields to Differential mail to Restore "Branch" and "changes since last update" fields to Differential mail.Mar 31 2014, 8:16 PM

Thanks for this!

src/applications/differential/customfield/DifferentialBranchField.php
62

It's also useful to have the branch shown when a diff is accepted and ready to land.

(Out of curiosity, do you use arc branch? And/or would arc land D123 be useful? I assume you're using the BRANCH field to copy-paste to the CLI?)

epriestley updated this revision to Diff 20532.Mar 31 2014, 8:48 PM
  • Also show the field for accepted revisions.

Ooh! No, I didn't know about arc branch. I do think being able to say arc land D123 would also be useful.

btrahan accepted this revision.Mar 31 2014, 9:35 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 31 2014, 9:35 PM
epriestley closed this revision.Apr 1 2014, 3:23 PM
epriestley updated this revision to Diff 20543.

Closed by commit rPcf6f7446ce3f (authored by @epriestley).