Paths

Table of Contentst

Differential D8694

Set from name when $can_send_as_user is true
ClosedPublic
Actions

Authored by sophiebits on Apr 4 2014, 12:43 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Feb 12, 8:48 PM

	Unknown Object (File)
	Wed, Feb 12, 3:04 AM

	Unknown Object (File)
	Tue, Feb 11, 11:04 PM

	Unknown Object (File)
	Tue, Feb 11, 11:03 PM

	Unknown Object (File)
	Tue, Feb 11, 10:58 PM

	Unknown Object (File)
	Tue, Feb 11, 10:46 PM

	Unknown Object (File)
	Sun, Feb 9, 12:09 PM

	Unknown Object (File)
	Sun, Feb 9, 12:09 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP133772d7eb1f: Set from name when $can_send_as_user is true

Test Plan

Crossed fingers.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

sophiebits updated this revision to Diff 20621.Apr 4 2014, 12:43 AM

sophiebits retitled this revision from to Set from name when $can_send_as_user is true.

sophiebits updated this object.

sophiebits edited the test plan for this revision. (Show Details)

sophiebits added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers.Apr 4 2014, 12:43 AM

Herald added subscribers: Korvin, epriestley.

whatcouldgowrong

This revision is now accepted and ready to land.Apr 4 2014, 12:44 AM

epriestley added inline comments.Apr 4 2014, 12:45 AM

src/applications/metamta/storage/PhabricatorMetaMTAMail.php
365	Also I wonder if this clause should maybe be like `if ($can_send_as_user && ($actor_email !== null))`.

sophiebits added inline comments.Apr 4 2014, 12:46 AM

src/applications/metamta/storage/PhabricatorMetaMTAMail.php
365	Well, we have $can_send_as_user = $actor_email && PhabricatorEnv::getEnvConfig('metamta.can-send-as-user'); which I assumed was good enough.
365	Or did you mean just store the config option in that var?

Closed by commit rP133772d7eb1f (authored by @spicyj, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

storage/

PhabricatorMetaMTAMail.php

2 lines

Diff 20623

src/applications/metamta/storage/PhabricatorMetaMTAMail.php

Loading...