Page MenuHomePhabricator

Set from name when $can_send_as_user is true
ClosedPublic

Authored by sophiebits on Apr 4 2014, 12:43 AM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP133772d7eb1f: Set from name when $can_send_as_user is true
Test Plan

Crossed fingers.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

sophiebits updated this revision to Diff 20621.Apr 4 2014, 12:43 AM
sophiebits retitled this revision from to Set from name when $can_send_as_user is true.
sophiebits updated this object.
sophiebits edited the test plan for this revision. (Show Details)
sophiebits added a reviewer: epriestley.
epriestley accepted this revision.Apr 4 2014, 12:44 AM
epriestley edited edge metadata.

whatcouldgowrong

This revision is now accepted and ready to land.Apr 4 2014, 12:44 AM
epriestley added inline comments.Apr 4 2014, 12:45 AM
src/applications/metamta/storage/PhabricatorMetaMTAMail.php
365

Also I wonder if this clause should maybe be like if ($can_send_as_user && ($actor_email !== null)).

sophiebits added inline comments.Apr 4 2014, 12:46 AM
src/applications/metamta/storage/PhabricatorMetaMTAMail.php
365

Well, we have

$can_send_as_user = $actor_email &&
  PhabricatorEnv::getEnvConfig('metamta.can-send-as-user');

which I assumed was good enough.

365

Or did you mean just store the config option in that var?

epriestley closed this revision.Apr 4 2014, 12:51 AM
epriestley updated this revision to Diff 20623.

Closed by commit rP133772d7eb1f (authored by @spicyj, committed by @epriestley).