Paths

Table of Contentst

Differential D9451

Make named lookup of users case insensitive
ClosedPublic
Actions

Authored by epriestley on Jun 10 2014, 11:59 AM.

Tags

None

Referenced Files

	F14060455: D9451.diff
	Mon, Nov 18, 1:22 AM

	F14034803: D9451.diff
	Sun, Nov 10, 2:13 AM

	F14004897: D9451.id22558.diff
	Sun, Oct 27, 4:42 AM

	F13980572: D9451.id22577.diff
	Oct 19 2024, 11:29 AM

	Unknown Object (File)
	Oct 9 2024, 4:12 PM

	Unknown Object (File)
	Oct 3 2024, 5:29 AM

	Unknown Object (File)
	Oct 1 2024, 12:19 PM

	Unknown Object (File)
	Sep 30 2024, 10:01 PM

Subscribers

Details

Reviewers

btrahan
sophiebits
chad

Maniphest Tasks

T5302: Conduit phid.lookup is case sensitive

Commits

Restricted Diffusion Commit
rP28341307922c: Make named lookup of users case insensitive

Summary

Fixes T5302. Allow the name @aLiNCoLN to identify user @alincoln.

Test Plan

Queried users with mixed case names.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22558.Jun 10 2014, 11:59 AM

epriestley retitled this revision from to Make named lookup of users case insensitive.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: sophiebits, btrahan.

epriestley added a task: T5302: Conduit phid.lookup is case sensitive.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 10 2014, 11:59 AM

Harbormaster completed remote builds in B955: Diff 22558.Jun 10 2014, 12:00 PM

sophiebits accepted this revision.Jun 10 2014, 6:35 PM

sophiebits edited edge metadata.

sophiebits added inline comments.

src/applications/people/phid/PhabricatorPeoplePHIDTypeUser.php
71	Just to verify my understanding – this transformation isn't necessary for the query, just for matching the objects up afterwards?

This revision is now accepted and ready to land.Jun 10 2014, 6:35 PM

Yep, that's correct. The query itself finds usernames in either case (which is how the user.query version works), but we currently discard them on the way out.

Closed by commit rP28341307922c (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

phid/

PhabricatorPeoplePHIDTypeUser.php

6 lines

Diff 22577

src/applications/people/phid/PhabricatorPeoplePHIDTypeUser.php

Loading...