Paths

Table of Contentst

Differential D9451

Make named lookup of users case insensitive
ClosedPublic
Actions

Authored by epriestley on Jun 10 2014, 11:59 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jan 27, 7:12 AM

	Unknown Object (File)
	Sat, Jan 25, 9:56 PM

	Unknown Object (File)
	Tue, Jan 21, 1:00 AM

	Unknown Object (File)
	Fri, Jan 17, 5:32 PM

	Unknown Object (File)
	Fri, Jan 17, 5:16 AM

	Unknown Object (File)
	Sat, Jan 11, 6:03 AM

	Unknown Object (File)
	Dec 30 2024, 2:09 PM

	Unknown Object (File)
	Dec 27 2024, 5:43 PM

Subscribers

Details

Reviewers

btrahan
sophiebits
chad

Maniphest Tasks

T5302: Conduit phid.lookup is case sensitive

Commits

Restricted Diffusion Commit
rP28341307922c: Make named lookup of users case insensitive

Summary

Fixes T5302. Allow the name @aLiNCoLN to identify user @alincoln.

Test Plan

Queried users with mixed case names.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22558.Jun 10 2014, 11:59 AM

epriestley retitled this revision from to Make named lookup of users case insensitive.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: sophiebits, btrahan.

epriestley added a task: T5302: Conduit phid.lookup is case sensitive.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 10 2014, 11:59 AM

Harbormaster completed remote builds in B955: Diff 22558.Jun 10 2014, 12:00 PM

sophiebits accepted this revision.Jun 10 2014, 6:35 PM

sophiebits edited edge metadata.

sophiebits added inline comments.

src/applications/people/phid/PhabricatorPeoplePHIDTypeUser.php
71	Just to verify my understanding – this transformation isn't necessary for the query, just for matching the objects up afterwards?

This revision is now accepted and ready to land.Jun 10 2014, 6:35 PM

Yep, that's correct. The query itself finds usernames in either case (which is how the user.query version works), but we currently discard them on the way out.

Closed by commit rP28341307922c (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

phid/

PhabricatorPeoplePHIDTypeUser.php

6 lines

Diff 22577

src/applications/people/phid/PhabricatorPeoplePHIDTypeUser.php

Loading...