Add CCs -> Add Subscribers
ClosedPublic
Actions

Authored by sophiebits on Jun 3 2014, 9:57 PM.

Tags

None

Referenced Files

	F15423574: D9367.diff
	Sat, Mar 22, 4:10 PM

	F15418162: D9367.id.diff
	Thu, Mar 20, 9:14 PM

	F15417843: D9367.id22312.diff
	Thu, Mar 20, 7:01 PM

	F15417108: D9367.id22315.diff
	Thu, Mar 20, 3:22 PM

	F15413635: D9367.id22315.diff
	Wed, Mar 19, 8:14 PM

	F15412410: D9367.diff
	Wed, Mar 19, 12:54 PM

	F15395611: D9367.diff
	Sun, Mar 16, 8:24 AM

	F15387568: D9367.id22315.diff
	Sat, Mar 15, 2:37 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP09d306b5b186: Add CCs -> Add Subscribers

Summary

I think this is the direction the language has been moving? Maybe this will train me that "CCs" are called "Subscribers". (I actually don't love this wording change, but consistency is good?)

Test Plan

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

sophiebits updated this revision to Diff 22312.Jun 3 2014, 9:57 PM

sophiebits retitled this revision from to Add CCs -> Add Subscribers.

sophiebits updated this object.

sophiebits edited the test plan for this revision. (Show Details)

sophiebits added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 3 2014, 9:57 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B836: Diff 22312.Jun 3 2014, 9:58 PM

epriestley accepted this revision.Jun 3 2014, 10:53 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 3 2014, 10:53 PM

Closed by commit rP09d306b5b186 (authored by @spicyj, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

constants/

DifferentialAction.php

2 lines

view/

DifferentialAddCommentView.php

2 lines

Diff 22315

View Options

src/applications/differential/constants/DifferentialAction.php