Page MenuHomePhabricator
Differential D19500

Fix changeset construction special case for empty commits in pre-commit hooks
ClosedPublic
Actions

Authored by epriestley on Jun 21 2018, 10:56 PM.
Tags
None
Referenced Files
F18220803: D19500.id.diff
Tue, Aug 19, 4:02 PM
F18199455: D19500.diff
Mon, Aug 18, 1:51 AM
F17705862: D19500.id46630.diff
Jul 16 2025, 10:05 AM
F17700626: D19500.diff
Jul 15 2025, 8:58 PM
F17684652: D19500.diff
Jul 14 2025, 1:58 AM
Unknown Object (File)
Jun 17 2025, 10:42 AM
Unknown Object (File)
Jun 5 2025, 5:53 PM
Unknown Object (File)
Jun 1 2025, 9:45 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
avivey
Maniphest Tasks
T13151: Plans: 2018 Week 23 - Week 30 Bonus Content
T13155: Empty commit causes diffusion error output (but doesn't fail)
Commits
rP6136b8327575: Fix changeset construction special case for empty commits in pre-commit hooks
Summary

Fixes T13155. Ref T13151. A recent change (D19455) changed the return format here, but I missed this special case for empty commits.

Test Plan
  • T13155 has a good set of reproduction instructions.
  • Pushed an empty commit.
    • Before: bunch of warning log spew.
    • After: clean logs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
engine/
2 lines

Diff 46631

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...
Phabricator · Built by Phacility