Page MenuHomePhabricator
Differential D19500

Fix changeset construction special case for empty commits in pre-commit hooks
ClosedPublic
Actions

Authored by epriestley on Jun 21 2018, 10:56 PM.
Tags
None
Referenced Files
F18806933: D19500.diff
Sat, Oct 18, 10:06 PM
F18757632: D19500.diff
Sun, Oct 5, 6:29 PM
F18750310: D19500.id46631.diff
Sat, Oct 4, 7:17 AM
F18738084: D19500.id46630.diff
Wed, Oct 1, 2:01 PM
F18674842: D19500.id.diff
Thu, Sep 25, 4:31 PM
F18647939: D19500.diff
Sep 19 2025, 3:15 PM
F18591243: D19500.id46631.diff
Sep 12 2025, 8:37 AM
F18588090: D19500.id46631.diff
Sep 11 2025, 11:16 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
avivey
Maniphest Tasks
T13151: Plans: 2018 Week 23 - Week 30 Bonus Content
T13155: Empty commit causes diffusion error output (but doesn't fail)
Commits
rP6136b8327575: Fix changeset construction special case for empty commits in pre-commit hooks
Summary

Fixes T13155. Ref T13151. A recent change (D19455) changed the return format here, but I missed this special case for empty commits.

Test Plan
  • T13155 has a good set of reproduction instructions.
  • Pushed an empty commit.
    • Before: bunch of warning log spew.
    • After: clean logs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
engine/
2 lines

Diff 46631

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...
Phabricator · Built by Phacility