Differential D19500

Fix changeset construction special case for empty commits in pre-commit hooks
ClosedPublic
Actions

Authored by epriestley on Jun 21 2018, 10:56 PM.

Details

Reviewers

amckinley
avivey

Maniphest Tasks

T13151: Plans: 2018 Week 23 - Week 30 Bonus Content
T13155: Empty commit causes diffusion error output (but doesn't fail)

Commits

rP6136b8327575: Fix changeset construction special case for empty commits in pre-commit hooks

Summary

Fixes T13155. Ref T13151. A recent change (D19455) changed the return format here, but I missed this special case for empty commits.

Test Plan

T13155 has a good set of reproduction instructions.
Pushed an empty commit.
- Before: bunch of warning log spew.
- After: clean logs.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 21 2018, 10:56 PM

Harbormaster completed remote builds in B20436: Diff 46630.Jun 21 2018, 10:57 PM

epriestley requested review of this revision.Jun 21 2018, 10:57 PM

avivey accepted this revision.Jun 21 2018, 11:24 PM

This revision is now accepted and ready to land.Jun 21 2018, 11:24 PM

Closed by commit rP6136b8327575: Fix changeset construction special case for empty commits in pre-commit hooks (authored by epriestley). · Explain WhyJun 21 2018, 11:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

engine/

DiffusionCommitHookEngine.php

2 lines

Diff 46631

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Fix changeset construction special case for empty commits in pre-commit hooksClosedPublicActions