Page MenuHomePhabricator

Fix changeset construction special case for empty commits in pre-commit hooks
ClosedPublic

Authored by epriestley on Jun 21 2018, 10:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 30, 6:05 PM
Unknown Object (File)
Thu, Dec 26, 3:45 PM
Unknown Object (File)
Wed, Dec 25, 10:54 AM
Unknown Object (File)
Thu, Dec 19, 9:52 PM
Unknown Object (File)
Thu, Dec 19, 1:04 AM
Unknown Object (File)
Sat, Dec 14, 6:57 PM
Unknown Object (File)
Sun, Dec 8, 10:02 AM
Unknown Object (File)
Dec 2 2024, 10:17 PM
Subscribers
None

Details

Summary

Fixes T13155. Ref T13151. A recent change (D19455) changed the return format here, but I missed this special case for empty commits.

Test Plan
  • T13155 has a good set of reproduction instructions.
  • Pushed an empty commit.
    • Before: bunch of warning log spew.
    • After: clean logs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable