Page MenuHomePhabricator
Create Task
Maniphest T3130

Improve recognition of symbols in Java
Open, NormalPublic
Actions

Description

Write a Java lexer (like D3336) to improve recognition of symbols in Java. Current state of the world is roughly:

Screen_Shot_2013-05-07_at_6.11.17_PM.png (177×713 px, 15 KB)

"Test", "main", "method" and "CONSTANT" are linked, but the other "Test" occurrences and "somefunc()" (i.e., implicit instance method call) are not.

Revisions and Commits

rPHU libphutil
D19637rPHUa28f6e5d64f3 Port the Java fragment lexer to PHP

Related Objects

Event Timeline

epriestley triaged this task as Normal priority.May 8 2013, 1:18 AM
epriestley added a project: libphutil.
epriestley added a subscriber: epriestley.
avivey added a subscriber: avivey.Nov 10 2013, 11:37 PM
jonah214 added a subscriber: jonah214.Jan 14 2014, 3:18 AM
avivey added a comment.Jan 30 2014, 12:33 AM

I've just realised that the lookup never work for java methods: pygmentize calls them "function"s and for ctags they are "method"s.

(at least with my versions: pygmentize 1.6 and ctags 5.8)

cburroughs added a subscriber: cburroughs.Sep 3 2014, 2:28 PM
avivey added a project: Symbols.May 18 2015, 5:24 AM
epriestley mentioned this in T1602: Support scoped symbols.Jan 24 2018, 4:35 PM
epriestley moved this task from Backlog to Language Support on the Symbols board.Jan 24 2018, 5:38 PM
Herald added a subscriber: eadler. · View Herald TranscriptJan 24 2018, 5:38 PM
epriestley added a revision: D19637: Port the Java fragment lexer to PHP.Sep 4 2018, 9:01 PM
epriestley added a commit: rPHUa28f6e5d64f3: Port the Java fragment lexer to PHP.Sep 6 2018, 3:41 PM
avivey changed the visibility from "All Users" to "Public (No Login Required)".Sep 6 2018, 5:34 PM
epriestley added a comment.Sep 6 2018, 5:35 PM

D19637 doesn't actually improve this, but it brings us a step closer (since the logic is now in PHP and can be modified more easily to label symbols and add context).

Phabricator · Built by Phacility