Page MenuHomePhabricator
Create Task
Maniphest T13239

null pointer exception in PhabricatorPeopleWelcomeController
Closed, ResolvedPublic
Actions

Description

See https://discourse.phabricator-community.org/t/call-to-a-member-function-getmessagetext-on-null/2304

Not sure how to reproduce this, but in D19995#249483, null value may be returned when a PhabricatorAuthMessage is expected.

Revisions and Commits

rP Phabricator
D20001rP491ba6d77e19 (stable) Fix "Welcome Mail" check for a message when no message exists
D20001rPbe8b7c9ebac7 Fix "Welcome Mail" check for a message when no message exists

Related Objects

Event Timeline

avivey created this task.Jan 19 2019, 11:31 PM
Herald added a subscriber: amckinley. · View Herald TranscriptJan 19 2019, 11:31 PM
epriestley added a revision: D20001: Fix "Welcome Mail" check for a message when no message exists.Jan 20 2019, 2:57 PM
epriestley added a subscriber: epriestley.Jan 20 2019, 3:00 PM

Reproduction steps are:

  • On a fresh or recently updated install, don't go to Auth → Customize Messages → Welcome Email Body and customize the email body.
  • Try to welcome a user.

A workaround is:

  • Go to Auth → Customize Messages → Welcome Email Body and set any custom body (even an empty one).

But D20001 should fix this, I just goofed it up at the last second when I wanted to add an actual link to the custom message.

epriestley closed this task as Resolved by committing rPbe8b7c9ebac7: Fix "Welcome Mail" check for a message when no message exists.Jan 20 2019, 3:00 PM
epriestley added a commit: rPbe8b7c9ebac7: Fix "Welcome Mail" check for a message when no message exists.
epriestley added a commit: rP491ba6d77e19: (stable) Fix "Welcome Mail" check for a message when no message exists.
Phabricator · Built by Phacility