Page MenuHomePhabricator

Allow bin/config to create config file
ClosedPublic

Authored by avivey on Sep 7 2019, 7:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 3, 11:22 PM
Unknown Object (File)
Mon, Dec 2, 11:36 PM
Unknown Object (File)
Thu, Nov 28, 1:19 PM
Unknown Object (File)
Tue, Nov 12, 12:45 PM
Unknown Object (File)
Fri, Nov 8, 11:49 AM
Unknown Object (File)
Nov 6 2024, 12:19 AM
Unknown Object (File)
Nov 6 2024, 12:19 AM
Unknown Object (File)
Nov 6 2024, 12:19 AM
Subscribers

Details

Summary

See D20779, https://discourse.phabricator-community.org/t/3089. bin/config set complains about
missing config file as if it's un-writable.

Test Plan

run bin/config set with missing, writable, unwritable conf.json and parent dir.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avivey requested review of this revision.Sep 7 2019, 7:19 PM

assertWritable checks that the file exists and writable. There's assertWritableFile, but it's private, and it's being called anyway from setKeys.
This might be hiding some other strange conditions, but I couldn't think of any that don't end up just making the file un-writeable.

Oops -- I think this is a reasonable fix, thanks!

This revision is now accepted and ready to land.Sep 7 2019, 11:01 PM
This revision was automatically updated to reflect the committed changes.