Page MenuHomePhabricator

Fix `arc diff` when adding large new file with new git
ClosedPublic

Authored by avivey on Jul 8 2018, 11:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 23, 6:49 PM
Unknown Object (File)
Thu, May 8, 11:16 AM
Unknown Object (File)
Tue, May 6, 11:20 AM
Unknown Object (File)
Apr 24 2025, 6:29 PM
Unknown Object (File)
Apr 13 2025, 6:35 AM
Unknown Object (File)
Apr 10 2025, 2:26 AM
Unknown Object (File)
Apr 5 2025, 11:14 AM
Unknown Object (File)
Apr 4 2025, 12:40 PM
Subscribers

Details

Summary

See https://discourse.phabricator-community.org/t/arc-not-supporting-git-2-17-1/.
When treating it a large file binary, we try to get the "old" and "new" content using git ls-tree and cat-file.
If the file is new or deleted, there is no old file, so we try to work with filename null.

Under git < 2.17.1, that gets treated as git ls-tree -- ., which falls in the next condition under "no such path".
In git 2.18, etc, this is an error.

Explicitly bail out if there is no filename.

Test Plan

Add a new, large (>4Mb) file, arc diff.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable