Page MenuHomePhabricator

Fix `arc diff` when adding large new file with new git
ClosedPublic

Authored by avivey on Jul 8 2018, 11:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 5, 1:56 PM
Unknown Object (File)
Fri, Nov 29, 12:42 PM
Unknown Object (File)
Tue, Nov 26, 10:08 PM
Unknown Object (File)
Fri, Nov 22, 1:47 AM
Unknown Object (File)
Thu, Nov 21, 10:15 AM
Unknown Object (File)
Mon, Nov 18, 1:08 AM
Unknown Object (File)
Thu, Nov 14, 8:55 PM
Unknown Object (File)
Sat, Nov 9, 8:22 PM
Subscribers

Details

Summary

See https://discourse.phabricator-community.org/t/arc-not-supporting-git-2-17-1/.
When treating it a large file binary, we try to get the "old" and "new" content using git ls-tree and cat-file.
If the file is new or deleted, there is no old file, so we try to work with filename null.

Under git < 2.17.1, that gets treated as git ls-tree -- ., which falls in the next condition under "no such path".
In git 2.18, etc, this is an error.

Explicitly bail out if there is no filename.

Test Plan

Add a new, large (>4Mb) file, arc diff.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable