Page MenuHomePhabricator

Fix `arc diff` when adding large new file with new git
ClosedPublic

Authored by avivey on Jul 8 2018, 11:39 PM.
Tags
None
Referenced Files
F18140908: D19513.id.diff
Thu, Aug 14, 5:19 AM
F17790956: D19513.id46663.diff
Jul 24 2025, 9:06 PM
F17759743: D19513.diff
Jul 22 2025, 6:47 PM
F17689626: D19513.diff
Jul 14 2025, 1:19 PM
Unknown Object (File)
May 23 2025, 6:49 PM
Unknown Object (File)
May 8 2025, 11:16 AM
Unknown Object (File)
May 6 2025, 11:20 AM
Unknown Object (File)
Apr 24 2025, 6:29 PM
Subscribers

Details

Summary

See https://discourse.phabricator-community.org/t/arc-not-supporting-git-2-17-1/.
When treating it a large file binary, we try to get the "old" and "new" content using git ls-tree and cat-file.
If the file is new or deleted, there is no old file, so we try to work with filename null.

Under git < 2.17.1, that gets treated as git ls-tree -- ., which falls in the next condition under "no such path".
In git 2.18, etc, this is an error.

Explicitly bail out if there is no filename.

Test Plan

Add a new, large (>4Mb) file, arc diff.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable