Page MenuHomePhabricator

Use the customizable "Welcome Mail" message in welcome mail
ClosedPublic

Authored by epriestley on Jan 18 2019, 3:08 AM.
Tags
None
Referenced Files
F13046418: D19995.id47729.diff
Thu, Apr 18, 9:37 AM
F13045680: D19995.id.diff
Thu, Apr 18, 2:08 AM
Unknown Object (File)
Thu, Apr 11, 9:12 AM
Unknown Object (File)
Sat, Apr 6, 9:28 AM
Unknown Object (File)
Tue, Apr 2, 7:15 AM
Unknown Object (File)
Sun, Mar 31, 1:07 PM
Unknown Object (File)
Mar 17 2024, 5:09 PM
Unknown Object (File)
Mar 16 2024, 10:43 AM
Subscribers

Details

Summary

Depends on D19994. See PHI1027. If an install has customized the "Welcome Mail" message, include it in welcome mail. A special custom message from the profile screen overrides it, if provided.

(I fiddled with putting the custom message as "placeholder" text in the remarkup area as a hint, but newlines in "placeholder" text appear to have issues in Safari and Firefox. I think this is probably reasonably clear as-is.)

Make both render remarkup-into-text so things like links work properly, as it's reasonably likely that installs will want to link to things.

Test Plan
  • With custom "Welcome Mail" text, sent mail with no custom override (got custom text) and a custom override (got overridden text).
  • Linked to some stuff, got sensible links in the mail (bin/mail show-outbound).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • When the mail body has a global default, make the reminder text link to it.
This revision is now accepted and ready to land.Jan 19 2019, 12:51 AM
This revision was automatically updated to reflect the committed changes.
avivey added inline comments.
src/applications/people/controller/PhabricatorPeopleWelcomeController.php
51

$default_message may return null under some case - maybe any fresh install/upgrade? Is there a default-default value?

src/applications/people/controller/PhabricatorPeopleWelcomeController.php
51

Fixed by D20001.