Page MenuHomePhabricator
Feed All Stories

Jan 14 2020

epriestley committed rP138ba8703147: Guard call to "get_magic_quotes_gpc()" with "@" to silence PHP 7.4+ warning (authored by epriestley).
Guard call to "get_magic_quotes_gpc()" with "@" to silence PHP 7.4+ warning
Jan 14 2020, 8:23 PM
epriestley closed D20942: Guard call to "get_magic_quotes_gpc()" with "@" to silence PHP 7.4+ warning.
Jan 14 2020, 8:23 PM
epriestley closed T13471: Guard call to "get_magic_quotes_gpc()" during startup as Resolved by committing rP138ba8703147: Guard call to "get_magic_quotes_gpc()" with "@" to silence PHP 7.4+ warning.
Jan 14 2020, 8:23 PM · Infrastructure
epriestley requested review of D20942: Guard call to "get_magic_quotes_gpc()" with "@" to silence PHP 7.4+ warning.
Jan 14 2020, 8:22 PM
epriestley added a revision to T13471: Guard call to "get_magic_quotes_gpc()" during startup: D20942: Guard call to "get_magic_quotes_gpc()" with "@" to silence PHP 7.4+ warning.
Jan 14 2020, 8:21 PM · Infrastructure
epriestley committed rPdb6b4ca480ad: Update deprecated array access syntax in Porter stemmer (authored by epriestley).
Update deprecated array access syntax in Porter stemmer
Jan 14 2020, 8:11 PM
epriestley closed D20941: Update deprecated array access syntax in Porter stemmer.
Jan 14 2020, 8:11 PM
epriestley closed T13472: Porter stemmer library uses obsolete array access syntax which raises warning under PHP 7.4 as Resolved by committing rPdb6b4ca480ad: Update deprecated array access syntax in Porter stemmer.
Jan 14 2020, 8:11 PM · Search
epriestley requested review of D20941: Update deprecated array access syntax in Porter stemmer.
Jan 14 2020, 8:11 PM
epriestley added a revision to T13472: Porter stemmer library uses obsolete array access syntax which raises warning under PHP 7.4: D20941: Update deprecated array access syntax in Porter stemmer.
Jan 14 2020, 8:04 PM · Search
epriestley added a comment to T13472: Porter stemmer library uses obsolete array access syntax which raises warning under PHP 7.4.

I thought this was some kind of complicated mess with the regex on line 420, but it's actually an issue with this:

Jan 14 2020, 8:03 PM · Search
epriestley committed rP767528c0ed55: Move search query parser/compiler classes to Phabricator (authored by epriestley).
Move search query parser/compiler classes to Phabricator
Jan 14 2020, 7:50 PM
epriestley closed D20939: Move search query parser/compiler classes to Phabricator.
Jan 14 2020, 7:49 PM
epriestley committed rPHUcc2a3dbf5903: Move search query compiler / stemmer classes out of libphutil (authored by epriestley).
Move search query compiler / stemmer classes out of libphutil
Jan 14 2020, 7:49 PM
epriestley closed D20940: Move search query compiler / stemmer classes out of libphutil.
Jan 14 2020, 7:49 PM
epriestley requested review of D20940: Move search query compiler / stemmer classes out of libphutil.
Jan 14 2020, 7:49 PM
epriestley added a revision to T13395: Strip libphutil for parts: D20940: Move search query compiler / stemmer classes out of libphutil.
Jan 14 2020, 7:48 PM · libphutil
epriestley added a revision to T13472: Porter stemmer library uses obsolete array access syntax which raises warning under PHP 7.4: D20940: Move search query compiler / stemmer classes out of libphutil.
Jan 14 2020, 7:48 PM · Search
epriestley updated the diff for D20939: Move search query parser/compiler classes to Phabricator.
  • Also move the Porter stemmer.
  • Ran some search queries.
Jan 14 2020, 7:47 PM
epriestley requested review of D20939: Move search query parser/compiler classes to Phabricator.
Jan 14 2020, 7:42 PM
epriestley added a revision to T13472: Porter stemmer library uses obsolete array access syntax which raises warning under PHP 7.4: D20939: Move search query parser/compiler classes to Phabricator.
Jan 14 2020, 7:41 PM · Search
epriestley added a revision to T13395: Strip libphutil for parts: D20939: Move search query parser/compiler classes to Phabricator.
Jan 14 2020, 7:41 PM · libphutil
epriestley added a comment to T13474: Track mentions on an individual field-by-field basis.

(Since a full implementation here will imply that removing a custom field from configuration may "unmention" an arbitrarily large number of relationships, and we can't easily do that inline or at display time, the ultimately implementation would likely include a more robust version of this script.)

Jan 14 2020, 7:21 PM · Infrastructure
epriestley added a comment to T13474: Track mentions on an individual field-by-field basis.

In PHI1602, I proposed a script to "reset" mentions on an object. The use case this serves is:

Jan 14 2020, 7:13 PM · Infrastructure
epriestley triaged T13474: Track mentions on an individual field-by-field basis as Wishlist priority.
Jan 14 2020, 6:32 PM · Infrastructure
epriestley triaged T13473: Provide full payload logging for inbound CircleCI build requests as Low priority.
Jan 14 2020, 6:17 PM · Infrastructure
epriestley accepted D20938: breakout: migrate to python3.

If systems with no binary named python are reasonable to expect, and it sounds like they are, this is fine as-is. I've added you to Blessed Committers so you should be able to land this change yourself (check the project description for some guidance), or let me know if you run into issues. After this lands, I'll land a followup in arc anoid to test for a python3 and emit a friendlier error if it isn't present.

Jan 14 2020, 4:35 PM
epriestley added a member for Blessed Committers: beber.
Jan 14 2020, 4:35 PM
artms added a comment to T5422: Does Phabricator integrate with JIRA?.

In jira 8.6.1 settings are now in:

  • AdministrationApplicationsApplication links
Jan 14 2020, 3:31 PM · Guides, Doorkeeper
leoluk added a comment to D20938: breakout: migrate to python3.

It's possible (and common) to write code that is both valid Python 2 and 3, like in this case.

Jan 14 2020, 3:26 PM

Jan 13 2020

epriestley added a comment to T13470: Unable to upload (crashes) large files (eg. 20mb) via file application upload section: https://secure.phabricator.com/file/upload/.

This page intentionally has a no-Javascript, no-drag-and-drop upload form for users who use obscure Linux window managers that don't support drag and drop.

Jan 13 2020, 7:32 PM
epriestley merged task T13470: Unable to upload (crashes) large files (eg. 20mb) via file application upload section: https://secure.phabricator.com/file/upload/ into T13256: Update storage engines in Files to a modern multi-service configuration.
Jan 13 2020, 7:26 PM
epriestley merged T13470: Unable to upload (crashes) large files (eg. 20mb) via file application upload section: https://secure.phabricator.com/file/upload/ into T13256: Update storage engines in Files to a modern multi-service configuration.
Jan 13 2020, 7:26 PM · Files
epriestley requested changes to D20938: breakout: migrate to python3.

This is almost certainly fine, but I don't actually have this bleeding-edge far-future version of Python installed on my stock Macbook (macOS Mojave):

Jan 13 2020, 6:29 PM
epriestley added a comment to T11162: Unable to Edit Projects as Administrator, Showing Restricted.

If you believe you've found a bug in Phabricator, please report it by creating a new thread on Discourse.

Jan 13 2020, 6:23 PM · Projects, Bug Report (Needs Information)
epriestley triaged T13472: Porter stemmer library uses obsolete array access syntax which raises warning under PHP 7.4 as Wishlist priority.
Jan 13 2020, 4:49 PM · Search

Jan 11 2020

beber requested review of D20938: breakout: migrate to python3.
Jan 11 2020, 9:21 PM

Jan 9 2020

brablc awarded T5427: Force a line break in a table cell a Like token.
Jan 9 2020, 4:18 PM · Remarkup

Jan 8 2020

jacksongabbard added a comment to T11162: Unable to Edit Projects as Administrator, Showing Restricted.

Last follow-up -- no, it was not a custom policy. The log of changes to the Project configuration show that the original setting for the edit policy was indeed "Project Members", which seems to indicate that Phabricator was incorrectly preventing new members from editing the Project.

Jan 8 2020, 1:32 PM · Projects, Bug Report (Needs Information)
jacksongabbard added a comment to T11162: Unable to Edit Projects as Administrator, Showing Restricted.

I was unable to reproduce this with a new Project, which makes me suspect the problem isn't a bug in Phabricator. I suspect the Project that was not editable *actually* had a Custom policy with specific users added to it, rather than a "Project Members" policy.

Jan 8 2020, 1:29 PM · Projects, Bug Report (Needs Information)
jacksongabbard added a comment to T11162: Unable to Edit Projects as Administrator, Showing Restricted.

I ran into this issue today as well. The context was a Project created by a regular user a few months back. He added himself and one other user to the Project. He also set the edit policy for the Project to be "Project Members." A few months later, a couple of other users were added to the Project, but neither of them could edit the Project (all links in the "Manage" UI were disabled, can't create milestones, etc.). The users who were in the group when the edit policy was set were still able to manage the group. One of them had to change the edit policy because the newer members of the group could not.

Jan 8 2020, 1:17 PM · Projects, Bug Report (Needs Information)

Jan 7 2020

n3v3rf411 edited the content of Organizations Using Phabricator.
Jan 7 2020, 2:05 AM

Jan 6 2020

PXke edited the content of Organizations Using Phabricator.
Jan 6 2020, 9:51 PM

Jan 5 2020

20after4 edited the content of Community Resources.
Jan 5 2020, 11:13 AM

Dec 19 2019

epriestley triaged T13471: Guard call to "get_magic_quotes_gpc()" during startup as Wishlist priority.
Dec 19 2019, 6:52 PM · Infrastructure
epriestley added a comment to T13269: Improve initial implementations of Workboard triggers and groups.

See also PHI1594, which wants:

Dec 19 2019, 5:18 PM · Workboards (v3)
epriestley added a comment to T13468: Last block of blocked Jupyter notebook diffs is not displayed in side-by-side view.

See also PHI1579.

Dec 19 2019, 5:11 PM · Differential

Dec 17 2019

shrinidhirao edited the content of Organizations Using Phabricator.
Dec 17 2019, 7:21 PM
artms created T13470: Unable to upload (crashes) large files (eg. 20mb) via file application upload section: https://secure.phabricator.com/file/upload/.
Dec 17 2019, 8:02 AM

Dec 15 2019

jparise edited the content of Community Resources.
Dec 15 2019, 6:37 PM

Dec 13 2019

epriestley edited the content of Changelog.
Dec 13 2019, 6:44 PM
epriestley created an object: 2019 Week 50 (Mid December).
Dec 13 2019, 6:43 PM
epriestley committed rPc4b4a53cad77: (stable) Promote 2019 Week 50 (authored by epriestley).
(stable) Promote 2019 Week 50
Dec 13 2019, 6:42 PM
epriestley committed rP54bcbdaba94a: Fix an XSS issue with certain high-priority remarkup rules embedded inside… (authored by epriestley).
Fix an XSS issue with certain high-priority remarkup rules embedded inside…
Dec 13 2019, 6:38 PM
epriestley closed D20937: Fix an XSS issue with certain high-priority remarkup rules embedded inside lower-priority link rules.
Dec 13 2019, 6:37 PM
epriestley requested review of D20937: Fix an XSS issue with certain high-priority remarkup rules embedded inside lower-priority link rules.
Dec 13 2019, 6:37 PM
artms created T13469: Muting Herald notifications fail with `Unhandled Exception ("PhabricatorApplicationTransactionStructureException")`.
Dec 13 2019, 10:44 AM · Herald

Dec 10 2019

artms committed rP4cd333b33fb1: Use same method to get object URI as used in DifferentialTransactionEditor and… (authored by artms).
Use same method to get object URI as used in DifferentialTransactionEditor and…
Dec 10 2019, 3:37 PM
artms closed D20935: Use same method to get object URI as used in DifferentialTransactionEditor and PhabricatorApplicationTransactionEditor.
Dec 10 2019, 3:37 PM

Dec 9 2019

epriestley accepted D20935: Use same method to get object URI as used in DifferentialTransactionEditor and PhabricatorApplicationTransactionEditor.
Dec 9 2019, 6:38 PM
artms requested review of D20936: Pass context object to PhabricatorMetaMTAMailBody as this is done in parent class.
Dec 9 2019, 11:32 AM
artms updated the test plan for D20935: Use same method to get object URI as used in DifferentialTransactionEditor and PhabricatorApplicationTransactionEditor.
Dec 9 2019, 11:31 AM
artms requested review of D20935: Use same method to get object URI as used in DifferentialTransactionEditor and PhabricatorApplicationTransactionEditor.
Dec 9 2019, 11:28 AM

Dec 5 2019

matelich added a comment to D17756: Remove all "Phabricator Bot" code.

After 2.5 years of not upgrading because I didn't want to lose phabot, we finally have (went fairly smoothly yay). Is there a slightly less terse explanation for how I can do as @joshuaspence said? Or at least a pointer to the right documentation for such a project?

We use the bot quite heavily at my company. Is there anything stopping me from just copying the deleted code into a libphutil extension and continuing to use it? Really, PhabricatorBotLogHandler is what we care about most.

Dec 5 2019, 8:21 PM

Nov 30 2019

epriestley requested review of D20934: Give "Config" a full-width, hierarchical layout.
Nov 30 2019, 8:05 PM
epriestley added a revision to T13362: Push the "Config" application UI out to full-width: D20934: Give "Config" a full-width, hierarchical layout.
Nov 30 2019, 8:03 PM · Design, Config
epriestley updated the task description for T13362: Push the "Config" application UI out to full-width.
Nov 30 2019, 7:55 PM · Design, Config
epriestley updated the task description for T13362: Push the "Config" application UI out to full-width.
Nov 30 2019, 6:38 PM · Design, Config
epriestley added a revision to T13362: Push the "Config" application UI out to full-width: D20933: Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView".
Nov 30 2019, 6:37 PM · Design, Config
epriestley updated the summary of D20933: Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView".
Nov 30 2019, 6:37 PM
epriestley requested review of D20933: Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView".
Nov 30 2019, 6:35 PM

Nov 28 2019

artms created T13468: Last block of blocked Jupyter notebook diffs is not displayed in side-by-side view.
Nov 28 2019, 10:57 AM · Differential

Nov 26 2019

epriestley requested review of D20931: Carve out a separate "Services" section of Config.
Nov 26 2019, 11:32 PM
epriestley added a revision to T13362: Push the "Config" application UI out to full-width: D20931: Carve out a separate "Services" section of Config.
Nov 26 2019, 11:31 PM · Design, Config
epriestley requested review of D20930: Carve out a separate "Modules/Extensions" section of Config.
Nov 26 2019, 11:02 PM
epriestley added a revision to T13362: Push the "Config" application UI out to full-width: D20930: Carve out a separate "Modules/Extensions" section of Config.
Nov 26 2019, 11:01 PM · Design, Config
epriestley triaged T13467: Expand the "ddata003" volume as Low priority.
Nov 26 2019, 6:00 PM · Phacility
CodeMouse92 awarded T10779: Cannot manage base project milestones if base project has subprojects a Party Time token.
Nov 26 2019, 3:17 AM · Restricted Project, Projects, Bug Report
CodeMouse92 added a comment to T10779: Cannot manage base project milestones if base project has subprojects.

Can confirm this is fixed. Yay!

Nov 26 2019, 3:17 AM · Restricted Project, Projects, Bug Report
epriestley closed T10779: Cannot manage base project milestones if base project has subprojects as Resolved.

I believe T13462 resolved this.

Nov 26 2019, 1:52 AM · Restricted Project, Projects, Bug Report
epriestley committed rP33c534f9b74f: Extend Config to full-width (authored by epriestley).
Extend Config to full-width
Nov 26 2019, 12:18 AM
epriestley closed D20925: Extend Config to full-width.
Nov 26 2019, 12:18 AM
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

there is no way to bin/host query against the set of instances using a particular repository shard service

Nov 26 2019, 12:14 AM · Phacility, Ops
epriestley added a revision to T13466: AWS instance termination may fail/hang indefinitely: Unknown Object (Differential Revision).
Nov 26 2019, 12:09 AM · Phacility, Ops

Nov 25 2019

epriestley added a revision to T13466: AWS instance termination may fail/hang indefinitely: Unknown Object (Differential Revision).
Nov 25 2019, 11:57 PM · Phacility, Ops
epriestley committed rP1667acfa5d71: Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them… (authored by epriestley).
Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them…
Nov 25 2019, 11:08 PM
epriestley closed D20927: Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them properly.
Nov 25 2019, 11:08 PM
epriestley added a comment to T11860: Bot email addresses can't be edited.

In D20927, I implemented a policy rule like this:

Nov 25 2019, 11:08 PM · Setup, People
epriestley requested review of D20927: Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them properly.
Nov 25 2019, 11:07 PM
epriestley added a revision to T11860: Bot email addresses can't be edited: D20927: Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them properly.
Nov 25 2019, 11:06 PM · Setup, People
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20927: Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them properly.
Nov 25 2019, 11:06 PM · Diffusion
epriestley added a revision to T13466: AWS instance termination may fail/hang indefinitely: Unknown Object (Differential Revision).
Nov 25 2019, 10:46 PM · Phacility, Ops
epriestley requested review of D20925: Extend Config to full-width.
Nov 25 2019, 10:38 PM
epriestley added a revision to T13362: Push the "Config" application UI out to full-width: D20925: Extend Config to full-width.
Nov 25 2019, 10:37 PM · Design, Config
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

Update Almanac definitions for all instances not on the paired db023 shard.

Nov 25 2019, 5:01 PM · Phacility, Ops
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

PHI1566 is resolved narrowly. These cleanup steps still need to happen.

Nov 25 2019, 4:42 PM · Phacility, Ops
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

(Updating addresses with bin/host query leaves the service address cache dirty (the "mutable structure cache" via PhabricatorRepository->getAlmanacServiceRefs()) so it should be followed with bin/cache purge --caches general.)

Nov 25 2019, 4:29 PM · Phacility, Ops
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

I'll flesh this out more later, but the move away from db123 = repo123 shard pairing, plus bin/host query using mysql makes it difficult to directly query instances using a particular repository service.

Nov 25 2019, 4:15 PM · Phacility, Ops
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

Minor issue that should be looked at during service sync arising from improved validation elsewhere:

Nov 25 2019, 4:06 PM · Phacility, Ops
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

I'm deploying the new host now. We just crossed a release so I'm going to manually restore it to 72f82abe07 once it comes up (see also T13359). Then, I'll resynchronize instance services for active instances.

Nov 25 2019, 3:57 PM · Phacility, Ops