Page MenuHomePhabricator
Create Task
Maniphest T13472

Porter stemmer library uses obsolete array access syntax which raises warning under PHP 7.4
Closed, ResolvedPublic
Actions

Description

See https://discourse.phabricator-community.org/t/error-8192-array-and-string-offset-access-syntax-with-curly-braces-is-deprecated-at-libphutil-externals-porter-stemmer-src-porter-php-424/3435.

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit

Related Objects

Event Timeline

epriestley triaged this task as Wishlist priority.Jan 13 2020, 4:49 PM
epriestley created this task.
Herald added a subscriber: amckinley. · View Herald TranscriptJan 13 2020, 4:49 PM
epriestley added a revision: Restricted Differential Revision.Jan 14 2020, 7:41 PM
epriestley added a revision: Restricted Differential Revision.Jan 14 2020, 7:48 PM
epriestley added a commit: Restricted Diffusion Commit.Jan 14 2020, 7:49 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a comment.Jan 14 2020, 8:03 PM

I thought this was some kind of complicated mess with the regex on line 420, but it's actually an issue with this:

... $matches[1]{2} ...

...on line 422.

The {...} should just be [...].

epriestley added a revision: Restricted Differential Revision.Jan 14 2020, 8:04 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Jan 14 2020, 8:11 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley mentioned this in 2020 Week 5 (Very Late January).Jan 30 2020, 9:35 PM
Phabricator · Built by Phacility