Page MenuHomePhabricator

Remove all "Phabricator Bot" code
ClosedPublic

Authored by epriestley on Apr 21 2017, 7:46 PM.

Details

Summary

Closes T7829 as wontfix. Closes T7965 as wontfix. Closes T7800 as wontfix. Closes T2731 as wontfix. Closes T1271 as wontfix.

We aren't maintaining this at all (see, e.g., T7829) and a user reported a technically accurate security issue via HackerOne: https://hackerone.com/reports/222870

Just throw it away until we get to the eventual Conphernece bot/API update and can do this stuff correctly.

Test Plan

Grepped for phabricatorbot.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 21 2017, 7:46 PM
This revision is now accepted and ready to land.Apr 21 2017, 7:46 PM
epriestley edited the summary of this revision. (Show Details)Apr 21 2017, 7:47 PM
This revision was automatically updated to reflect the committed changes.
reed added a subscriber: reed.Apr 21 2017, 8:48 PM
joshuaspence added a subscriber: joshuaspence.EditedApr 21 2017, 9:57 PM

We use the bot quite heavily at my company. Is there anything stopping me from just copying the deleted code into a libphutil extension and continuing to use it? Really, PhabricatorBotLogHandler is what we care about most.

That'll work fine.

After 2.5 years of not upgrading because I didn't want to lose phabot, we finally have (went fairly smoothly yay). Is there a slightly less terse explanation for how I can do as @joshuaspence said? Or at least a pointer to the right documentation for such a project?

We use the bot quite heavily at my company. Is there anything stopping me from just copying the deleted code into a libphutil extension and continuing to use it? Really, PhabricatorBotLogHandler is what we care about most.

Thanks!