Page MenuHomePhabricator
Feed All Stories

Nov 25 2019

epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

Instance termination completed after about 20 minutes and all the volumes detached. Since the original instance can be recycled, I'm going to reattach and restart it, and throw away the replacement host.

Nov 25 2019, 3:51 PM · Phacility, Ops
epriestley added a project to T13466: AWS instance termination may fail/hang indefinitely: Phacility.
Nov 25 2019, 3:48 PM · Phacility, Ops
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

Normal volume detachment is just spinning, which isn't exactly surprising. I'm going to give it a few minutes and then force detachment.

Nov 25 2019, 3:47 PM · Phacility, Ops
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

To deal with this narrowly, I'm going to:

Nov 25 2019, 3:44 PM · Phacility, Ops
epriestley triaged T13466: AWS instance termination may fail/hang indefinitely as Low priority.
Nov 25 2019, 3:42 PM · Phacility, Ops
epriestley updated the task description for T13362: Push the "Config" application UI out to full-width.
Nov 25 2019, 3:24 PM · Design, Config
epriestley updated the task description for T13362: Push the "Config" application UI out to full-width.
Nov 25 2019, 3:22 PM · Design, Config
epriestley added a comment to T13362: Push the "Config" application UI out to full-width.

...

Nov 25 2019, 3:17 PM · Design, Config
epriestley edited the content of Changelog.
Nov 25 2019, 3:13 PM
epriestley created an object: 2019 Week 47 (Very Late November).
Nov 25 2019, 3:11 PM
epriestley committed rP6de53cf50c38: (stable) Promote 2019 Week 47 (authored by epriestley).
(stable) Promote 2019 Week 47
Nov 25 2019, 3:11 PM

Nov 22 2019

epriestley committed rPeb6df7a2091a: Remove "phlog()" of exeptions during Conduit calls (authored by epriestley).
Remove "phlog()" of exeptions during Conduit calls
Nov 22 2019, 8:03 PM
epriestley closed D20924: Remove "phlog()" of exeptions during Conduit calls.
Nov 22 2019, 8:03 PM
epriestley closed T13465: Stop sending Conduit exceptions to the error log as Resolved by committing rPeb6df7a2091a: Remove "phlog()" of exeptions during Conduit calls.
Nov 22 2019, 8:03 PM · Conduit
epriestley requested review of D20924: Remove "phlog()" of exeptions during Conduit calls.
Nov 22 2019, 7:56 PM
epriestley added a revision to T13465: Stop sending Conduit exceptions to the error log: D20924: Remove "phlog()" of exeptions during Conduit calls.
Nov 22 2019, 7:54 PM · Conduit
epriestley triaged T13465: Stop sending Conduit exceptions to the error log as Low priority.
Nov 22 2019, 7:52 PM · Conduit

Nov 21 2019

epriestley committed rP2abf292821a2: Fix an issue where editing paths in Owners packages could raise an error… (authored by epriestley).
Fix an issue where editing paths in Owners packages could raise an error…
Nov 21 2019, 7:29 PM
epriestley closed T13464: Fix "display" index issue when editing Paths in Owners as Resolved by committing rP2abf292821a2: Fix an issue where editing paths in Owners packages could raise an error….
Nov 21 2019, 7:29 PM · Owners
epriestley closed D20923: Fix an issue where editing paths in Owners packages could raise an error: undefined index "display".
Nov 21 2019, 7:29 PM
epriestley requested review of D20923: Fix an issue where editing paths in Owners packages could raise an error: undefined index "display".
Nov 21 2019, 7:28 PM
epriestley added a revision to T13464: Fix "display" index issue when editing Paths in Owners: D20923: Fix an issue where editing paths in Owners packages could raise an error: undefined index "display".
Nov 21 2019, 7:27 PM · Owners
epriestley triaged T13464: Fix "display" index issue when editing Paths in Owners as Low priority.
Nov 21 2019, 7:18 PM · Owners
epriestley removed a parent task for T3794: Rebuild Diffusion/Audit on top of CustomField infrastructure: T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234".
Nov 21 2019, 4:06 PM · Restricted Project, Diffusion, Custom Fields
epriestley removed a subtask for T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234": T3794: Rebuild Diffusion/Audit on top of CustomField infrastructure.
Nov 21 2019, 4:06 PM · Maniphest
epriestley removed a subtask for T10034: Plan the future of Maniphest task relationships: T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships.
Nov 21 2019, 4:06 PM · Maniphest
epriestley removed a parent task for T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships: T10034: Plan the future of Maniphest task relationships.
Nov 21 2019, 4:06 PM · Customer Impact, Maniphest, Differential
epriestley merged T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234" into T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".
Nov 21 2019, 4:05 PM · Maniphest, Differential, Diffusion
epriestley merged task T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234" into T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".
Nov 21 2019, 4:05 PM · Maniphest
epriestley added a comment to T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234".

T13463 is approximately the same as this, but now ripe; I'm going to merge this there.

Nov 21 2019, 4:04 PM · Maniphest
epriestley added a parent task for T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234": T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".
Nov 21 2019, 4:03 PM · Maniphest
epriestley added a subtask for T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx": T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234".
Nov 21 2019, 4:03 PM · Maniphest, Differential, Diffusion
epriestley added a subtask for T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships: T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".
Nov 21 2019, 4:03 PM · Customer Impact, Maniphest, Differential
epriestley added a parent task for T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx": T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships.
Nov 21 2019, 4:03 PM · Maniphest, Differential, Diffusion
epriestley updated the task description for T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".
Nov 21 2019, 4:02 PM · Maniphest, Differential, Diffusion
epriestley triaged T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx" as Low priority.
Nov 21 2019, 4:02 PM · Maniphest, Differential, Diffusion
epriestley closed T5598: Make "T123" in commit title work like "Ref T123" or "Fixes T123" in the body or test plan or a comment as Wontfix.

I don't currently plan to pursue this.

Nov 21 2019, 3:56 PM · Maniphest, Differential
arielyang edited the content of Community Resources.
Nov 21 2019, 5:28 AM

Nov 20 2019

jonah214 added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

Perfect; thanks!

Nov 20 2019, 1:14 PM · Customer Impact, Diffusion (v3)
epriestley added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

In the general case:

Nov 20 2019, 7:00 AM · Customer Impact, Diffusion (v3)
jonah214 added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

Sorry if this is a stupid question, but now that this is done, how do I actually map between Phabricator users and VCS user strings, in an existing Diffusion repo?

Nov 20 2019, 3:34 AM · Customer Impact, Diffusion (v3)

Nov 19 2019

epriestley committed rP374f8b10b3cf: Add a "--dry-run" flag to "bin/repository rebuild-identities" (authored by epriestley).
Add a "--dry-run" flag to "bin/repository rebuild-identities"
Nov 19 2019, 8:38 PM
epriestley closed D20922: Add a "--dry-run" flag to "bin/repository rebuild-identities".
Nov 19 2019, 8:38 PM
epriestley closed T12164: Put an indirection layer between author/committer strings and user accounts as Resolved.

I think this doesn't have anything actionable left, see T13444 for some followups. This feature probably isn't 100% perfect quite yet, but I think remaining work is just cleanup.

Nov 19 2019, 8:37 PM · Customer Impact, Diffusion (v3)
epriestley requested review of D20922: Add a "--dry-run" flag to "bin/repository rebuild-identities".
Nov 19 2019, 8:36 PM
epriestley claimed T13444: Provide a standalone script entry point for resolving a repository identity.
Nov 19 2019, 8:36 PM · Diffusion
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20922: Add a "--dry-run" flag to "bin/repository rebuild-identities".
Nov 19 2019, 8:34 PM · Diffusion
epriestley committed rP63d84e0b44b7: Improve use of keys when iterating over commits in "bin/audit delete" and… (authored by epriestley).
Improve use of keys when iterating over commits in "bin/audit delete" and…
Nov 19 2019, 6:19 PM
epriestley closed T13457: "phabricator_repository.repository_commit" table has poor keys for naive iteration, a subtask of T13444: Provide a standalone script entry point for resolving a repository identity, as Resolved.
Nov 19 2019, 6:19 PM · Diffusion
epriestley closed T13457: "phabricator_repository.repository_commit" table has poor keys for naive iteration as Resolved by committing rP63d84e0b44b7: Improve use of keys when iterating over commits in "bin/audit delete" and….
Nov 19 2019, 6:19 PM · Diffusion
epriestley closed D20921: Improve use of keys when iterating over commits in "bin/audit delete" and "bin/repository rebuild-identities".
Nov 19 2019, 6:19 PM
epriestley requested review of D20921: Improve use of keys when iterating over commits in "bin/audit delete" and "bin/repository rebuild-identities".
Nov 19 2019, 6:11 PM
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20921: Improve use of keys when iterating over commits in "bin/audit delete" and "bin/repository rebuild-identities".
Nov 19 2019, 6:10 PM · Diffusion
epriestley added a revision to T13457: "phabricator_repository.repository_commit" table has poor keys for naive iteration: D20921: Improve use of keys when iterating over commits in "bin/audit delete" and "bin/repository rebuild-identities".
Nov 19 2019, 6:10 PM · Diffusion
epriestley committed rPa7aca500bcd1: Update repository identities after all mutations to users and email addresses (authored by epriestley).
Update repository identities after all mutations to users and email addresses
Nov 19 2019, 5:42 PM
epriestley closed D20914: Update repository identities after all mutations to users and email addresses.
Nov 19 2019, 5:42 PM
epriestley committed rP89dcf9792a0a: Give "PhabricatorUserEmail" a PHID (authored by epriestley).
Give "PhabricatorUserEmail" a PHID
Nov 19 2019, 5:41 PM
epriestley closed D20913: Give "PhabricatorUserEmail" a PHID.
Nov 19 2019, 5:41 PM
epriestley committed rPd69a7360ea17: Use DestructionEngine to destroy UserEmail objects (authored by epriestley).
Use DestructionEngine to destroy UserEmail objects
Nov 19 2019, 5:41 PM
epriestley closed D20912: Use DestructionEngine to destroy UserEmail objects.
Nov 19 2019, 5:41 PM
epriestley committed rP18da346972b6: Add additional flags to "bin/repository rebuild-identities" to improve… (authored by epriestley).
Add additional flags to "bin/repository rebuild-identities" to improve…
Nov 19 2019, 5:40 PM
epriestley closed D20911: Add additional flags to "bin/repository rebuild-identities" to improve flexibility.
Nov 19 2019, 5:39 PM
epriestley committed rP0014d0404c2d: Consolidate repository identity resolution and detection code (authored by epriestley).
Consolidate repository identity resolution and detection code
Nov 19 2019, 5:39 PM
epriestley closed D20910: Consolidate repository identity resolution and detection code.
Nov 19 2019, 5:39 PM
epriestley committed rP6afbb6102dda: Remove "PhabricatorEventType::TYPE_DIFFUSION_LOOKUPUSER" event (authored by epriestley).
Remove "PhabricatorEventType::TYPE_DIFFUSION_LOOKUPUSER" event
Nov 19 2019, 5:38 PM
epriestley closed D20909: Remove "PhabricatorEventType::TYPE_DIFFUSION_LOOKUPUSER" event.
Nov 19 2019, 5:38 PM
epriestley committed rPa2b2c391a1f1: Distinguish between "Assigned" and "Effective" identity PHIDs more clearly and… (authored by epriestley).
Distinguish between "Assigned" and "Effective" identity PHIDs more clearly and…
Nov 19 2019, 5:37 PM
epriestley closed D20908: Distinguish between "Assigned" and "Effective" identity PHIDs more clearly and consistently.
Nov 19 2019, 5:37 PM
epriestley committed rPdf0f5c6cee03: Make repository identity email address association case-insensitive (authored by epriestley).
Make repository identity email address association case-insensitive
Nov 19 2019, 5:37 PM
epriestley closed D20907: Make repository identity email address association case-insensitive.
Nov 19 2019, 5:37 PM
epriestley edited the content of Changelog.
Nov 19 2019, 5:30 PM
epriestley committed rARCbac2028421a4: (stable) Promote 2019 Week 46 (authored by epriestley).
(stable) Promote 2019 Week 46
Nov 19 2019, 5:29 PM
epriestley committed rPc11506bdf929: (stable) Promote 2019 Week 46 (authored by epriestley).
(stable) Promote 2019 Week 46
Nov 19 2019, 5:29 PM
epriestley created an object: 2019 Week 46 (Late November).
Nov 19 2019, 5:29 PM
epriestley closed T13462: Correct some policy/membership issues in milestone creation as Resolved.
Nov 19 2019, 7:13 AM · Projects, Policy
epriestley committed rPd58eddcf0ad4: When predicting project membership during edits, predict milestones will have… (authored by epriestley).
When predicting project membership during edits, predict milestones will have…
Nov 19 2019, 7:07 AM
epriestley closed D20920: When predicting project membership during edits, predict milestones will have parent membership.
Nov 19 2019, 7:07 AM
epriestley committed rP959504a4881c: When predicting object policies for project milestones, adjust objects so they… (authored by epriestley).
When predicting object policies for project milestones, adjust objects so they…
Nov 19 2019, 7:06 AM
epriestley closed D20919: When predicting object policies for project milestones, adjust objects so they behave like milestones.
Nov 19 2019, 7:06 AM
epriestley requested review of D20920: When predicting project membership during edits, predict milestones will have parent membership.
Nov 19 2019, 6:53 AM
epriestley added a comment to T13462: Correct some policy/membership issues in milestone creation.

We materialize some members into the milestone? This causes no real problems, but we shouldn't materialize members into milestones.

Nov 19 2019, 6:53 AM · Projects, Policy
epriestley added a revision to T13462: Correct some policy/membership issues in milestone creation: D20920: When predicting project membership during edits, predict milestones will have parent membership.
Nov 19 2019, 6:52 AM · Projects, Policy
epriestley added a comment to T13462: Correct some policy/membership issues in milestone creation.

We predict the wrong set of members for the milestone when testing policies: we predict "no members", but should predict "exactly the same as the members of the parent project"?

Nov 19 2019, 6:42 AM · Projects, Policy
epriestley requested review of D20919: When predicting object policies for project milestones, adjust objects so they behave like milestones.
Nov 19 2019, 6:30 AM
epriestley added a revision to T13462: Correct some policy/membership issues in milestone creation: D20919: When predicting object policies for project milestones, adjust objects so they behave like milestones.
Nov 19 2019, 6:29 AM · Projects, Policy
epriestley added a comment to T13462: Correct some policy/membership issues in milestone creation.

We check the wrong edit policy when testing if you can create a milestone: we check the default application policy, but should check the parent project policy?

Nov 19 2019, 6:13 AM · Projects, Policy
epriestley triaged T13462: Correct some policy/membership issues in milestone creation as Normal priority.
Nov 19 2019, 6:09 AM · Projects, Policy
epriestley committed rPde66a8ece185: Remove "stronger/weaker" policy color hints from object headers (authored by epriestley).
Remove "stronger/weaker" policy color hints from object headers
Nov 19 2019, 6:05 AM
epriestley closed D20918: Remove "stronger/weaker" policy color hints from object headers.
Nov 19 2019, 6:05 AM
epriestley closed T13461: Remove policy tag coloration in object header UI as Resolved by committing rPde66a8ece185: Remove "stronger/weaker" policy color hints from object headers.
Nov 19 2019, 6:05 AM · Policy
epriestley updated the task description for T13461: Remove policy tag coloration in object header UI.
Nov 19 2019, 6:04 AM · Policy
epriestley requested review of D20918: Remove "stronger/weaker" policy color hints from object headers.
Nov 19 2019, 6:01 AM
epriestley added a revision to T13461: Remove policy tag coloration in object header UI: D20918: Remove "stronger/weaker" policy color hints from object headers.
Nov 19 2019, 6:00 AM · Policy
epriestley committed rP1996b0cd55c5: Update the "owner can always view/edit" policy exception rule (authored by epriestley).
Update the "owner can always view/edit" policy exception rule
Nov 19 2019, 5:54 AM
epriestley closed D20917: Update the "owner can always view/edit" policy exception rule.
Nov 19 2019, 5:54 AM
epriestley closed T13460: Restore "Owner can view/edit task" policy hint in Task policy explanation dialogs as Resolved by committing rP1996b0cd55c5: Update the "owner can always view/edit" policy exception rule.
Nov 19 2019, 5:54 AM · Policy, Maniphest
epriestley triaged T13461: Remove policy tag coloration in object header UI as Low priority.
Nov 19 2019, 5:49 AM · Policy
epriestley requested review of D20917: Update the "owner can always view/edit" policy exception rule.
Nov 19 2019, 5:42 AM
epriestley added a revision to T13460: Restore "Owner can view/edit task" policy hint in Task policy explanation dialogs: D20917: Update the "owner can always view/edit" policy exception rule.
Nov 19 2019, 5:41 AM · Policy, Maniphest
epriestley triaged T13460: Restore "Owner can view/edit task" policy hint in Task policy explanation dialogs as Low priority.
Nov 19 2019, 5:38 AM · Policy, Maniphest