Page MenuHomePhabricator
Differential D20933

Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView"
ClosedPublic
Actions

Authored by epriestley on Nov 30 2019, 6:34 PM.

Details

Reviewers
None
Maniphest Tasks
T13362: Push the "Config" application UI out to full-width
Commits
rP26c2a1ba68b1: Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView"
Summary

Depends on D20931. Ref T13362. Move all "Console"-style interfaces to use a consistent layout based on a new "LauncherView" which just centers the content.

Test Plan

Viewed all affected interfaces.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Nov 30 2019, 6:34 PM
Owners added a subscriber: Restricted Owners Package.Nov 30 2019, 6:34 PM
Harbormaster completed remote builds in B23708: Diff 49882.Nov 30 2019, 6:35 PM
epriestley requested review of this revision.Nov 30 2019, 6:35 PM
epriestley edited the summary of this revision. (Show Details)Nov 30 2019, 6:37 PM
epriestley added a task: T13362: Push the "Config" application UI out to full-width.
epriestley added a child revision: D20934: Give "Config" a full-width, hierarchical layout.Nov 30 2019, 8:03 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 4 2020, 2:52 PM
Closed by commit rP26c2a1ba68b1: Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP26c2a1ba68b1: Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView".

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
almanac/
controller/
20 lines
dashboard/
controller/
6 lines
diffusion/
controller/
8 lines
drydock/
controller/
6 lines
view/
phui/
20 lines
webroot/
rsrc/
css/
phui/
5 lines

Diff 49949

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/almanac/controller/AlmanacConsoleController.php

Loading...
View Options

src/applications/dashboard/controller/PhabricatorDashboardConsoleController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryEditController.php

Loading...
View Options

src/applications/drydock/controller/DrydockConsoleController.php

Loading...
View Options

src/view/phui/PHUILauncherView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-two-column-view.css

Loading...
Phabricator · Built by Phacility