Differential D20933

Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView"
Needs ReviewPublic
Actions

Authored by epriestley on Nov 30 2019, 6:34 PM.

Details

Reviewers: None
Maniphest Tasks: T13362: Push the "Config" application UI out to full-width

Summary

Depends on D20931. Ref T13362. Move all "Console"-style interfaces to use a consistent layout based on a new "LauncherView" which just centers the content.

Test Plan

Viewed all affected interfaces.

Diff Detail

Repository

rP Phabricator

Branch

config5

Lint

Lint OK

Unit

Unit Tests OK

Build Status

Buildable 23708
Build 32596: Run Core Tests
Build 32595: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 30 2019, 6:34 PM

Owners added a subscriber: Restricted Owners Package.Nov 30 2019, 6:34 PM

Harbormaster completed remote builds in B23708: Diff 49882.Nov 30 2019, 6:35 PM

epriestley requested review of this revision.Nov 30 2019, 6:35 PM

epriestley edited the summary of this revision. (Show Details)Nov 30 2019, 6:37 PM

epriestley added a task: T13362: Push the "Config" application UI out to full-width.

epriestley added a child revision: D20934: Give "Config" a full-width, hierarchical layout.Nov 30 2019, 8:03 PM

Revision Contents
Changeset List

		Path
M		resources/celerity/map.php (6 lines)
M		src/__phutil_library_map__.php (2 lines)
M		src/applications/almanac/controller/AlmanacConsoleController.php (20 lines)
M		src/applications/dashboard/controller/PhabricatorDashboardConsoleController.php (6 lines)
M		src/applications/diffusion/controller/DiffusionRepositoryEditController.php (8 lines)
M		src/applications/drydock/controller/DrydockConsoleController.php (6 lines)
A	M	src/view/phui/PHUILauncherView.php (20 lines)
M		webroot/rsrc/css/phui/phui-two-column-view.css (5 lines)

Commit	Tree	Parents	Author	Summary	Date
2c00793c24f6	018e1349ae8b	d5b98f73524c	epriestley	WIP	Nov 30 2019, 6:28 PM

Status	Author	Revision
Needs Review	epriestley	D20934 Give "Config" a full-width, hierarchical layout
Needs Review	epriestley	D20933 Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView"
Needs Review	epriestley	D20931 Carve out a separate "Services" section of Config
Needs Review	epriestley	D20930 Carve out a separate "Modules/Extensions" section of Config