Page MenuHomePhabricator

Update deprecated array access syntax in Porter stemmer
ClosedPublic

Authored by epriestley on Tue, Jan 14, 8:04 PM.

Details

Summary

Fixes T13472. This library uses $a{0}, but this is deprecated in favor of $a[0].

Test Plan

Ran bin/search index Txxx --force on a task with "filing" in the title (this term reaches the "m" rule of the stemmer).

(I'm not on new enough PHP for this to actually raise an error, but I'll follow up with the reporting user.)

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Tue, Jan 14, 8:04 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Jan 14, 8:06 PM
Harbormaster failed remote builds in B23722: Diff 49896!
epriestley updated this revision to Diff 49897.Tue, Jan 14, 8:09 PM
  • Fix accidental index change which caused a stemming test failure.
This revision was not accepted when it landed; it landed in state Needs Review.Tue, Jan 14, 8:11 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.