Page MenuHomePhabricator

Update deprecated array access syntax in Porter stemmer
ClosedPublic

Authored by epriestley on Jan 14 2020, 8:04 PM.
Tags
None
Referenced Files
F18251723: D20941.id.diff
Thu, Aug 21, 6:33 PM
F18227315: D20941.diff
Wed, Aug 20, 5:55 AM
F18100827: D20941.id.diff
Sat, Aug 9, 12:07 PM
F17948281: D20941.id.diff
Jul 31 2025, 8:42 PM
F17844589: D20941.id49897.diff
Jul 27 2025, 2:19 AM
F17840453: D20941.id49898.diff
Jul 26 2025, 9:09 PM
F17840026: D20941.id49896.diff
Jul 26 2025, 8:40 PM
F17820091: D20941.diff
Jul 26 2025, 1:46 AM
Subscribers
None

Details

Summary

Fixes T13472. This library uses $a{0}, but this is deprecated in favor of $a[0].

Test Plan

Ran bin/search index Txxx --force on a task with "filing" in the title (this term reaches the "m" rule of the stemmer).

(I'm not on new enough PHP for this to actually raise an error, but I'll follow up with the reporting user.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 14 2020, 8:06 PM
Harbormaster failed remote builds in B23722: Diff 49896!
  • Fix accidental index change which caused a stemming test failure.
This revision was not accepted when it landed; it landed in state Needs Review.Jan 14 2020, 8:11 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.