Page MenuHomePhabricator

Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them properly
ClosedPublic

Authored by epriestley on Nov 25 2019, 11:05 PM.
Tags
None
Referenced Files
F20582623: D20927.id49870.diff
Fri, Jun 19, 5:26 PM
Unknown Object (File)
Wed, Jun 10, 2:57 AM
Unknown Object (File)
Apr 14 2026, 11:04 PM
Unknown Object (File)
Feb 5 2026, 9:05 PM
Unknown Object (File)
Dec 2 2025, 12:31 PM
Unknown Object (File)
Nov 24 2025, 4:36 PM
Unknown Object (File)
Nov 23 2025, 2:19 PM
Unknown Object (File)
Nov 21 2025, 12:22 AM
Subscribers
None

Details

Summary

See PHI1558. Ref T11860. Ref T13444. I partly implemented PHIDs for "UserEmail" objects, but they can't load on their own so you can't directly bin/remove destroy them yet.

Allow them to actually load by implementing "PolicyInterface".

Addresses are viewable and editable by the associated user, unless they are a bot/list address, in which case they are viewable and editable by administrators (in preparation for T11860). This has no real impact on anything today.

Test Plan
  • Used bin/remove destroy <phid> to destroy an individual email address.
  • Before: error while loading the object by PHID in the query policy layer.
  • After: clean load and destroy.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable