Page MenuHomePhabricator

Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them properly
ClosedPublic

Authored by epriestley on Nov 25 2019, 11:05 PM.
Tags
None
Referenced Files
F15576597: D20927.diff
Tue, May 6, 9:47 AM
F15541029: D20927.id49871.diff
Fri, Apr 25, 10:17 AM
F15473151: D20927.diff
Apr 5 2025, 7:48 PM
F15437938: D20927.id49870.diff
Mar 25 2025, 10:15 PM
F15434067: D20927.id49871.diff
Mar 25 2025, 1:49 AM
F15429435: D20927.id.diff
Mar 24 2025, 2:15 AM
F15424396: D20927.diff
Mar 22 2025, 10:01 PM
F15402868: D20927.diff
Mar 18 2025, 12:46 AM
Subscribers
None

Details

Summary

See PHI1558. Ref T11860. Ref T13444. I partly implemented PHIDs for "UserEmail" objects, but they can't load on their own so you can't directly bin/remove destroy them yet.

Allow them to actually load by implementing "PolicyInterface".

Addresses are viewable and editable by the associated user, unless they are a bot/list address, in which case they are viewable and editable by administrators (in preparation for T11860). This has no real impact on anything today.

Test Plan
  • Used bin/remove destroy <phid> to destroy an individual email address.
  • Before: error while loading the object by PHID in the query policy layer.
  • After: clean load and destroy.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable