Page MenuHomePhabricator

Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them properly
ClosedPublic

Authored by epriestley on Nov 25 2019, 11:05 PM.
Tags
None
Referenced Files
F19028886: D20927.diff
Mon, Nov 24, 4:36 PM
F19019387: D20927.diff
Sun, Nov 23, 2:19 PM
F19000530: D20927.id.diff
Fri, Nov 21, 12:22 AM
F18985294: D20927.id49870.diff
Mon, Nov 17, 12:58 PM
F18865389: D20927.diff
Mon, Nov 3, 12:03 PM
F18862904: D20927.id49871.diff
Sun, Nov 2, 9:30 PM
F18837476: D20927.id49870.diff
Oct 27 2025, 5:40 AM
F18833776: D20927.id49871.diff
Oct 26 2025, 5:43 AM
Subscribers
None

Details

Summary

See PHI1558. Ref T11860. Ref T13444. I partly implemented PHIDs for "UserEmail" objects, but they can't load on their own so you can't directly bin/remove destroy them yet.

Allow them to actually load by implementing "PolicyInterface".

Addresses are viewable and editable by the associated user, unless they are a bot/list address, in which case they are viewable and editable by administrators (in preparation for T11860). This has no real impact on anything today.

Test Plan
  • Used bin/remove destroy <phid> to destroy an individual email address.
  • Before: error while loading the object by PHID in the query policy layer.
  • After: clean load and destroy.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable