Page MenuHomePhabricator

Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them properly
ClosedPublic

Authored by epriestley on Nov 25 2019, 11:05 PM.
Tags
None
Referenced Files
F15376745: D20927.id49871.diff
Thu, Mar 13, 5:19 AM
F15360732: D20927.diff
Tue, Mar 11, 9:49 AM
Unknown Object (File)
Feb 9 2025, 8:29 AM
Unknown Object (File)
Feb 9 2025, 8:29 AM
Unknown Object (File)
Feb 9 2025, 8:29 AM
Unknown Object (File)
Jan 31 2025, 7:21 PM
Unknown Object (File)
Jan 30 2025, 6:09 AM
Unknown Object (File)
Jan 25 2025, 6:15 AM
Subscribers
None

Details

Summary

See PHI1558. Ref T11860. Ref T13444. I partly implemented PHIDs for "UserEmail" objects, but they can't load on their own so you can't directly bin/remove destroy them yet.

Allow them to actually load by implementing "PolicyInterface".

Addresses are viewable and editable by the associated user, unless they are a bot/list address, in which case they are viewable and editable by administrators (in preparation for T11860). This has no real impact on anything today.

Test Plan
  • Used bin/remove destroy <phid> to destroy an individual email address.
  • Before: error while loading the object by PHID in the query policy layer.
  • After: clean load and destroy.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable