Feed All Stories
Oct 26 2019
Oct 26 2019
(stable) Promote 2019 Week 43
(stable) Promote 2019 Week 43
epriestley committed rP8ff0e3ab351f: Support rich diff rendering with DocumentEngine for added/removed files (authored by epriestley).
Support rich diff rendering with DocumentEngine for added/removed files
Oct 25 2019
Oct 25 2019
swisspol added a comment to T13434: Support Perforce/Git in "arc land".
This makes a lot of sense, thanks or the time to explain.
leoluk awarded D20865: Support rich diff rendering with DocumentEngine for added/removed files a Love token.
epriestley added a comment to T11362: Arcanist tries to land onto identical remote branch instead of 'master'.
I'm going to merge this into T11535 since it's basically the same issue.
epriestley renamed T10300: On branch "xyz", "arc land --onto xyz abc" does not result in update to "xyz" even when "xyz" is not ahead of the remote from Arcanist not always pulling landed branch to On branch "xyz", "arc land --onto xyz abc" does not result in update to "xyz" even when "xyz" is not ahead of the remote.
epriestley closed T5964: When landing, it might be nice if arcanist could check if changes are being pushed to the canonical git repository as Wontfix.
This hasn't come up again, so it looks like it probably isn't a feature that would see a lot of general use.
epriestley moved T5852: arc should ignore abandoned revisions when landing from Backlog to arc land on the Arcanist board.
epriestley moved T11535: Make it possible for arc land to disable upstream branch tracking from Backlog to arc land on the Arcanist board.
epriestley edited projects for T11535: Make it possible for arc land to disable upstream branch tracking, added: Arcanist; removed Feature Request.
epriestley moved T2493: Support `arc land` in stacked commits from Backlog to arc land on the Arcanist board.
epriestley moved T3875: Allow arc to perform cascading rebases, maybe during or after `arc land` from Backlog to arc land on the Arcanist board.
epriestley moved T11362: Arcanist tries to land onto identical remote branch instead of 'master' from Backlog to arc land on the Arcanist board.
epriestley moved T12876: Improve initial arc land experience when destination repo is empty from Backlog to arc land on the Arcanist board.
epriestley moved T13434: Support Perforce/Git in "arc land" from Backlog to arc land on the Arcanist board.
epriestley added a comment to T13434: Support Perforce/Git in "arc land".
Why not just implement the basic path for arc land and fail with an error if the user has some esoteric setup?
swisspol added a comment to T13434: Support Perforce/Git in "arc land".
It's possible I'm misreading/misunderstanding this, so maybe the right algorithm is actually to select the "p4" remote ahead of the "origin" remote, i.e. swap steps (2) and (3).
epriestley triaged T13435: When "phabricator.base-uri" changes, the repository "uriindex" table must be rebuilt as Low priority.
epriestley added a comment to T13434: Support Perforce/Git in "arc land".
the config with the dépôt path to “fetch” latest changelists from is saved inside .git directory
swisspol added a comment to T13434: Support Perforce/Git in "arc land".
You don’t need to pass any arguments to git p4 sync: the config with the dépôt path to “fetch” latest changelists from is saved inside .git directory. Did you follow the exact instructions I provided?
epriestley added a comment to T13434: Support Perforce/Git in "arc land".
I got Git/Perforce working after a large amount of bashing my head into errors like these:
epriestley committed rP38694578e1d0: Improve project member list behaviors related to disabled users (authored by epriestley).
Improve project member list behaviors related to disabled users
epriestley committed rP633aa5288c58: Persist login instructions onto flow-specific login pages (username/password… (authored by epriestley).
Persist login instructions onto flow-specific login pages (username/password…
epriestley requested review of D20864: Improve project member list behaviors related to disabled users.
epriestley added a comment to D20863: Persist login instructions onto flow-specific login pages (username/password and LDAP).
epriestley triaged T13433: Continue showing custom login instructions on provider-specific login screens as Low priority.
epriestley committed rP5b36f0c97ac9: Add default branch, description, and metrics (commit count, recent commit) to… (authored by epriestley).
Add default branch, description, and metrics (commit count, recent commit) to…
Oct 24 2019
Oct 24 2019
epriestley added a comment to T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly.
One change we can make here is to explicitly specify -c diff.suppressBlankEmpty false in the arc diff command, as we currently use --src-prefix and --dst-prefix to override diff.mnemonicprefix. This is likely desirable, but it would be good to also parse these diffs properly if they arrive through --raw or copy/pasting, etc.
Pawka awarded T1022: arc patch fails to properly apply a patch which changes a symlink to a real file a Like token.
epriestley renamed T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly from Diffs that have had tailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly to Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly.
Oct 22 2019
Oct 22 2019
epriestley triaged T13431: Make "Members" lists in projects more clear about disabled members as Low priority.
Oct 21 2019
Oct 21 2019
artms requested review of D20861: Return empty data if fact dimension is missing, not yet available.
Oct 18 2019
Oct 18 2019
artms added a comment to T13427: Task to reproduce lack of transaction object validation.
Thanks!
Oct 17 2019
Oct 17 2019
This now renders properly; see T13429 for followup.
epriestley committed rPf497b93e4311: Fix a fatal in the "Projects" curtain extension when a project edge connects an… (authored by epriestley).
Fix a fatal in the "Projects" curtain extension when a project edge connects an…
epriestley committed rPd34dfa37461b: Fix an error message when calling "transaction.search" with a non-transactional… (authored by epriestley).
Fix an error message when calling "transaction.search" with a non-transactional…
epriestley committed rP5dafabd5b4d0: Fix deprecated argument order for "implode()" (authored by epriestley).
Fix deprecated argument order for "implode()"
epriestley closed T13428: PHP 7.4 now warns about "implode()" argument order as Resolved by committing rP5dafabd5b4d0: Fix deprecated argument order for "implode()".
epriestley committed rARCda6d4f85eefb: Add a lint check for deprecated argument order to "implode()" (authored by epriestley).
Add a lint check for deprecated argument order to "implode()"
epriestley requested review of D20858: Fix deprecated argument order for "implode()".
epriestley updated the task description for T13428: PHP 7.4 now warns about "implode()" argument order.
epriestley requested review of D20857: Add a lint check for deprecated argument order to "implode()".
Oct 15 2019
Oct 15 2019
Krinkle added a comment to T13421: Implement OpenGraph metadata in Phame for Twitter cards.
I did some trial and error last week with Twitter via https://cards-dev.twitter.com/validator. That was for my personal blog, but some of it might apply here as well.
Oct 14 2019
Oct 14 2019
Oct 11 2019
Oct 11 2019
mormegil awarded rPff410134818e: Support animated gif in meme a Love token.
Oct 10 2019
Oct 10 2019
epriestley added a comment to T13322: Allow parent projects to have direct members.