Persist login instructions onto flow-specific login pages (username/password and LDAP)
ClosedPublic
Actions

Authored by epriestley on Oct 25 2019, 1:07 AM.

Details

Reviewers: None
Maniphest Tasks: T13433: Continue showing custom login instructions on provider-specific login screens
Commits: rP633aa5288c58: Persist login instructions onto flow-specific login pages (username/password…

Summary

Fixes T13433. Currently, "Login Screen Instructions" in "Auth" are shown only on the main login screen. If you enter a bad password or bad LDAP credential set and move to the flow-specific login failure screen (for example, "invalid password"), the instructions vanish.

Instead, persist them. There are reasonable cases where this is highly useful and the cases which spring to mind where this is possibly misleading are fairly easy to fix by making the instructions more specific.

Test Plan

Configured login instructions in "Auth".
Viewed main login screen, saw instructions.
Entered a bad username/password and a bad LDAP credential set, got kicked to workflow sub-pages and still saw instructions (previously: no instructions).
Grepped for other callers to buildProviderPageResponse() to look for anything weird, came up empty.