Page MenuHomePhabricator

Persist login instructions onto flow-specific login pages (username/password and LDAP)

Authored by epriestley on Oct 25 2019, 1:07 AM.
Referenced Files
Unknown Object (File)
Fri, Feb 16, 1:38 PM
Unknown Object (File)
Jan 20 2024, 4:39 PM
Unknown Object (File)
Jan 16 2024, 4:07 PM
Unknown Object (File)
Jan 12 2024, 4:44 PM
Unknown Object (File)
Jan 1 2024, 4:26 PM
Unknown Object (File)
Dec 28 2023, 4:36 PM
Unknown Object (File)
Dec 24 2023, 4:24 PM
Unknown Object (File)
Dec 22 2023, 4:00 AM



Fixes T13433. Currently, "Login Screen Instructions" in "Auth" are shown only on the main login screen. If you enter a bad password or bad LDAP credential set and move to the flow-specific login failure screen (for example, "invalid password"), the instructions vanish.

Instead, persist them. There are reasonable cases where this is highly useful and the cases which spring to mind where this is possibly misleading are fairly easy to fix by making the instructions more specific.

Test Plan
  • Configured login instructions in "Auth".
  • Viewed main login screen, saw instructions.
  • Entered a bad username/password and a bad LDAP credential set, got kicked to workflow sub-pages and still saw instructions (previously: no instructions).
  • Grepped for other callers to buildProviderPageResponse() to look for anything weird, came up empty.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable