Page MenuHomePhabricator

Persist login instructions onto flow-specific login pages (username/password and LDAP)
ClosedPublic

Authored by epriestley on Fri, Oct 25, 1:07 AM.

Details

Summary

Fixes T13433. Currently, "Login Screen Instructions" in "Auth" are shown only on the main login screen. If you enter a bad password or bad LDAP credential set and move to the flow-specific login failure screen (for example, "invalid password"), the instructions vanish.

Instead, persist them. There are reasonable cases where this is highly useful and the cases which spring to mind where this is possibly misleading are fairly easy to fix by making the instructions more specific.

Test Plan
  • Configured login instructions in "Auth".
  • Viewed main login screen, saw instructions.
  • Entered a bad username/password and a bad LDAP credential set, got kicked to workflow sub-pages and still saw instructions (previously: no instructions).
  • Grepped for other callers to buildProviderPageResponse() to look for anything weird, came up empty.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Fri, Oct 25, 1:07 AM
epriestley requested review of this revision.Fri, Oct 25, 1:09 AM
This revision was not accepted when it landed; it landed in state Needs Review.Fri, Oct 25, 1:38 AM
This revision was automatically updated to reflect the committed changes.