Differential D20860

Fix a fatal in the "Projects" curtain extension when a project edge connects an object to a non-project
ClosedPublic
Actions

Authored by epriestley on Oct 17 2019, 4:43 PM.

Tags

None

Referenced Files

	F13192292: D20860.diff
	Sun, May 12, 6:42 AM

	Unknown Object (File)
	Sun, May 5, 12:19 AM

	Unknown Object (File)
	Wed, May 1, 8:09 PM

	Unknown Object (File)
	Mon, Apr 29, 12:47 AM

	Unknown Object (File)
	Sun, Apr 28, 9:31 AM

	Unknown Object (File)
	Sat, Apr 20, 7:08 AM

	Unknown Object (File)
	Wed, Apr 17, 3:14 PM

	Unknown Object (File)
	Apr 11 2024, 7:22 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13429: Edge transactions are broadly non-modular and lack transaction hooks, including hooks for validation behavior
Commits: rPf497b93e4311: Fix a fatal in the "Projects" curtain extension when a project edge connects an…

Summary

Ref T13429. It's currently possible to write "TYPE_EDGE" relationships for the "object has project" edge to PHIDs which may not actually be projects. Today, this fatals.

As a first step, unfatal it. T13429 discusses general improvements and greater context.

Test Plan

Used "maniphest.edit" to write a "project" edge to a user PHID, viewed the task in the UI. Previously it fataled; now it renders unusually (the object is "tagged" with a user) but faithfully reflects database state.

Screen Shot 2019-10-17 at 9.41.09 AM.png (142×342 px, 9 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Oct 17 2019, 4:43 PM

Harbormaster completed remote builds in B23558: Diff 49730.Oct 17 2019, 4:45 PM

epriestley requested review of this revision.Oct 17 2019, 4:45 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 17 2019, 4:49 PM

Closed by commit rPf497b93e4311: Fix a fatal in the "Projects" curtain extension when a project edge connects an… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPf497b93e4311: Fix a fatal in the "Projects" curtain extension when a project edge connects an….

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

project/

engine/

PhabricatorBoardLayoutEngine.php

6 lines

interface/

PhabricatorWorkboardInterface.php

3 lines

storage/

PhabricatorProject.php

3 lines

Diff 49731

src/__phutil_library_map__.php

Loading...

src/applications/project/engine/PhabricatorBoardLayoutEngine.php

Loading...

src/applications/project/interface/PhabricatorWorkboardInterface.php

Loading...

src/applications/project/storage/PhabricatorProject.php

Loading...