Page MenuHomePhabricator

Fix a fatal in the "Projects" curtain extension when a project edge connects an object to a non-project
ClosedPublic

Authored by epriestley on Thu, Oct 17, 4:43 PM.

Details

Summary

Ref T13429. It's currently possible to write "TYPE_EDGE" relationships for the "object has project" edge to PHIDs which may not actually be projects. Today, this fatals.

As a first step, unfatal it. T13429 discusses general improvements and greater context.

Test Plan

Used "maniphest.edit" to write a "project" edge to a user PHID, viewed the task in the UI. Previously it fataled; now it renders unusually (the object is "tagged" with a user) but faithfully reflects database state.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Oct 17, 4:43 PM
epriestley requested review of this revision.Thu, Oct 17, 4:45 PM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, Oct 17, 4:49 PM
This revision was automatically updated to reflect the committed changes.