Page MenuHomePhabricator

Fix a fatal in the "Projects" curtain extension when a project edge connects an object to a non-project
ClosedPublic

Authored by epriestley on Oct 17 2019, 4:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 27, 12:41 PM
Unknown Object (File)
Sat, Jan 25, 5:57 AM
Unknown Object (File)
Sat, Jan 25, 5:57 AM
Unknown Object (File)
Sat, Jan 25, 5:57 AM
Unknown Object (File)
Fri, Jan 24, 6:22 PM
Unknown Object (File)
Tue, Jan 21, 11:12 AM
Unknown Object (File)
Fri, Jan 17, 12:30 PM
Unknown Object (File)
Dec 20 2024, 9:48 PM
Subscribers
None

Details

Summary

Ref T13429. It's currently possible to write "TYPE_EDGE" relationships for the "object has project" edge to PHIDs which may not actually be projects. Today, this fatals.

As a first step, unfatal it. T13429 discusses general improvements and greater context.

Test Plan

Used "maniphest.edit" to write a "project" edge to a user PHID, viewed the task in the UI. Previously it fataled; now it renders unusually (the object is "tagged" with a user) but faithfully reflects database state.

Screen Shot 2019-10-17 at 9.41.09 AM.png (142×342 px, 9 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable