Page MenuHomePhabricator
Feed All Stories

Mar 15 2016

vhbit awarded T9640: Make Phabricator compatible with PHP7 a Like token.
Mar 15 2016, 4:42 AM · Prioritized, Restricted Project, Infrastructure
• kaendfinger edited the content of Organizations Using Phabricator.
Mar 15 2016, 4:36 AM
cspeckmim added a comment to T10575: Support project tags on Passphrase credentials.

d'oh - thanks - I feel like at one point that wasn't yet available and must've just assumed it still wasn't.

Mar 15 2016, 2:20 AM · Projects, Passphrase, Feature Request
epriestley added a comment to T10575: Support project tags on Passphrase credentials.

You should be able to do "Visible To: Members of X" already (or use Spaces, even). Tags wouldn't affect visibility.

Mar 15 2016, 2:14 AM · Projects, Passphrase, Feature Request
cspeckmim added a comment to T10584: Allow users to amend revisions they don't own, without commandeering them.

There have only been a handful of occasions where something like this would have been convenient for my team - in the "drive-by" scenario. One developer happens across a bug and fixes it locally in order to continue their testing/development, meanwhile the bug is actually part of a larger problem which another developer is investigating. The options in this scenario are:

  1. Wait for "drive-by" developer's changes to be landed
  2. Have the "drive-by" developer export a diff of the relevant file(s) and email to the other
Mar 15 2016, 1:59 AM · Differential
dmnd edited the content of Organizations Not Using Phabricator.
Mar 15 2016, 1:58 AM
cspeckmim added a comment to T10575: Support project tags on Passphrase credentials.

Would having tags on passphrases mean that they would be usable by members of the group? I just did a check as I thought I had created a task about this previously but does not appear to be the case (maybe I was keeping it in a create form and never submitted).

Mar 15 2016, 1:37 AM · Projects, Passphrase, Feature Request
avivey added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Mar 15 2016, 12:40 AM · Prioritized, Diffusion (v3), KDE, Restricted Project
20after4 added a comment to T10584: Allow users to amend revisions they don't own, without commandeering them.

I like the idea of proposing an update but not automatically applying it until the author clicks 'approve.'

Mar 15 2016, 12:32 AM · Differential
asteinlein added a comment to T5568: Support `.arcunit`, similar to `.arclint`.

Yeah, I understand, although too bad if that task is as low-pri and as large an undertaking as it seems. :/

Mar 15 2016, 12:05 AM · Unit, Arcanist

Mar 14 2016

epriestley added a comment to T10559: Lease Working Copy Hangs on lease failure, but should fail.

(I think that title edit is accurate, let me know if I misunderstood.)

Mar 14 2016, 11:58 PM · Drydock, Bug Report
epriestley renamed T10559: Lease Working Copy Hangs on lease failure, but should fail from Lease Working Copy Hangs to Lease Working Copy Hangs on lease failure, but should fail.
Mar 14 2016, 11:57 PM · Drydock, Bug Report
epriestley added a comment to T5568: Support `.arcunit`, similar to `.arclint`.

@asteinlein, sorry, I missed your earlier question.

Mar 14 2016, 11:51 PM · Unit, Arcanist
asteinlein added a comment to T5568: Support `.arcunit`, similar to `.arclint`.

Any progress on this?

Mar 14 2016, 11:41 PM · Unit, Arcanist
chad added a comment to T10585: Add "Flag for Later" to projects/workboards.

It was a bug that it disappeared.

Mar 14 2016, 10:20 PM · Projects, Flags, Feature Request
isfs added a comment to T10585: Add "Flag for Later" to projects/workboards.

Ah. Looks like I just needed to upgrade as this change was made in the last month or so (I last upgraded late Feb). Didn't see this change mentioned in the changelog, or a task for it, so assumed it still wasn't possible. What you have implemented is perfect for us. Sorry for the noise.

Mar 14 2016, 10:08 PM · Projects, Flags, Feature Request
epriestley added a comment to T10586: Call to undefined function mysql_real_escape_string().

This probably isn't directly related to PHP7.

Mar 14 2016, 9:40 PM · Setup, Bug Report
eadler added a subtask for T9640: Make Phabricator compatible with PHP7: T10586: Call to undefined function mysql_real_escape_string().
Mar 14 2016, 9:35 PM · Prioritized, Restricted Project, Infrastructure
eadler added a parent task for T10586: Call to undefined function mysql_real_escape_string(): T9640: Make Phabricator compatible with PHP7.
Mar 14 2016, 9:35 PM · Setup, Bug Report
eadler added a comment to T10586: Call to undefined function mysql_real_escape_string().

See Also: T9640

Mar 14 2016, 9:34 PM · Setup, Bug Report
epriestley changed the edit policy for Changelog.
Mar 14 2016, 9:25 PM
epriestley edited the content of Changelog.
Mar 14 2016, 9:18 PM
• unityforall deleted Changelog.
Mar 14 2016, 9:16 PM
puls awarded T7820: Add "Closed, Duplicate" option to Status Action in Maniphest a Love token.
Mar 14 2016, 9:11 PM · Restricted Project, User Delight, Maniphest
chad updated the task description for T10586: Call to undefined function mysql_real_escape_string().
Mar 14 2016, 8:51 PM · Setup, Bug Report
epriestley added a comment to T10586: Call to undefined function mysql_real_escape_string().

Can you show me the output of this command on your system?

Mar 14 2016, 8:33 PM · Setup, Bug Report
valentinul created T10586: Call to undefined function mysql_real_escape_string().
Mar 14 2016, 8:29 PM · Setup, Bug Report
avivey added a comment to T1407: Feature Suggestion : Admin LDAP import on people page.

This was probably implemented in rP51d2d06e3722ad807be588dc894e8d0f0e8be076

Mar 14 2016, 8:03 PM · Phabricator, Auth
avivey changed the visibility for D2920: Admin LDAP import on people page.
Mar 14 2016, 7:55 PM
avivey changed the visibility for T1407: Feature Suggestion : Admin LDAP import on people page.
Mar 14 2016, 7:55 PM · Auth, Phabricator
eadler added a comment to T10584: Allow users to amend revisions they don't own, without commandeering them.

GitHub actually encourages reviewers to "Add commits to PRs"; It's a little hard to un-teach once it gets hold.

Mar 14 2016, 7:30 PM · Differential
avivey added a comment to T10584: Allow users to amend revisions they don't own, without commandeering them.

GitHub actually encourages reviewers to "Add commits to PRs"; It's a little hard to un-teach once it gets hold.

Mar 14 2016, 6:40 PM · Differential
epriestley added a comment to T10584: Allow users to amend revisions they don't own, without commandeering them.

It took 6 months before I got my first patch accepted in gerrit.

Mar 14 2016, 6:08 PM · Differential
avivey changed the visibility for T1178: Differential needs a yellow action.
Mar 14 2016, 5:59 PM · Differential
20after4 updated subscribers of T10584: Allow users to amend revisions they don't own, without commandeering them.
Mar 14 2016, 5:00 PM · Differential
20after4 added a comment to T10584: Allow users to amend revisions they don't own, without commandeering them.

An example of a concerning "New Hire" case is a scenario like this:

It's your first day at Big Company, Inc. as a software engineer.
You submit your first a change to fix a bug.
Someone way more senior than you rewrites it, updates over it, then tells you to commit it.

I think this is soul-crushing and incredibly toxic, and want the software to prevent this from being a path-of-least-resistance workflow as much as we reasonably can. The easiest thing should generally be to ask the author to take responsibility/ownership, fix issues, etc., -- the same thing you'd do with a more senior engineer -- so new hires are on equal footing from day one.

Mar 14 2016, 4:47 PM · Differential
20after4 added a comment to T10584: Allow users to amend revisions they don't own, without commandeering them.

FWIW - full time engineers at the WMF do routinely amend each others changes in gerrit, without hesitation.

Mar 14 2016, 4:40 PM · Differential
chad triaged T10582: Support colspan and rowspan in tables as Wishlist priority.
Mar 14 2016, 4:29 PM · Remarkup, Feature Request
eadler moved T10574: A pathway toward "All Reviewers Must Accept" from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Mar 14 2016, 4:24 PM · FreeBSD, Restricted Project, Differential
eadler added a project to T10574: A pathway toward "All Reviewers Must Accept": Restricted Project.
Mar 14 2016, 4:11 PM · FreeBSD, Restricted Project, Differential
chad added a comment to T10565: Make Phriction articles accessible via version control or arc.

"Feature doesn't exist" or "We'd use it" isn't to us a description of a root problem. Let's say for sake of argument, we'll never build that solution into Phabricator. Can you describe what problem you are having using Phabricator and let us determine how to solve it in a way that benefits the most users.

Mar 14 2016, 4:11 PM · Phriction, Feature Request
maxie added a comment to T10565: Make Phriction articles accessible via version control or arc.

Thank you again, I try to describe the situation more clearly.

Mar 14 2016, 3:33 PM · Phriction, Feature Request
epriestley added a comment to T10584: Allow users to amend revisions they don't own, without commandeering them.

Maybe notable is that these use cases seem to be completely different from the use cases discussed in D14104 (where "lightweight diffs are probably a plurality, if not majority"). There is also some possible overlap with T6008.

Mar 14 2016, 2:24 PM · Differential
epriestley added a comment to T10584: Allow users to amend revisions they don't own, without commandeering them.

Here's a general outline of a workflow which might satisfy everything without creating the "stomp all over new hires" tension that I want to avoid:

Mar 14 2016, 2:13 PM · Differential
epriestley added a comment to T10584: Allow users to amend revisions they don't own, without commandeering them.

Here's my best effort to summarize downstream use cases for this by reading through https://phabricator.wikimedia.org/T121751 -- let me know if I'm misunderstanding, missing, or misrepresenting anything:

Mar 14 2016, 2:04 PM · Differential
chad closed T10585: Add "Flag for Later" to projects/workboards as Resolved.

Projects are flaggable under the manage page. We have no plans to make Workboards flaggable.

Mar 14 2016, 1:52 PM · Projects, Flags, Feature Request
PhoneixS added a comment to T7260: EXCEPTION: (AphrontCharacterSetQueryException) Attempting to construct a query using a non-utf8 string when utf8 is expected.

Well I have searched and the problem is windows encode names in non utf-8 code (usually Windows-1252) and commit this files names in mercurial. Then the parser extract this file names supposing the are correctly encoded in utf8 and as they aren't other classes (like commit parsers) do wrong things (for example try to insert with %s when it isn't utf).

Mar 14 2016, 12:59 PM
epriestley added a comment to T10584: Allow users to amend revisions they don't own, without commandeering them.

To provide some background and context, we added Commandeer in D2257 to deal with use cases like this:

Mar 14 2016, 12:53 PM · Differential
isfs created T10585: Add "Flag for Later" to projects/workboards.
Mar 14 2016, 12:51 PM · Projects, Flags, Feature Request
epriestley added a revision to T10584: Allow users to amend revisions they don't own, without commandeering them: Unknown Object (Differential Revision).
Mar 14 2016, 12:24 PM · Differential
epriestley created T10584: Allow users to amend revisions they don't own, without commandeering them.
Mar 14 2016, 12:24 PM · Differential
• Instinct64 awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Mar 14 2016, 11:49 AM · Workboards (v3), Restricted Project
sascha-egerer created T10582: Support colspan and rowspan in tables.
Mar 14 2016, 11:07 AM · Remarkup, Feature Request
PhoneixS added a comment to T7260: EXCEPTION: (AphrontCharacterSetQueryException) Attempting to construct a query using a non-utf8 string when utf8 is expected.

Still having the same issue although I updated to last version.

Mar 14 2016, 8:22 AM
epriestley awarded T10577: Table of contents on unattached diff view lost a margin a Pterodactyl token.
Mar 14 2016, 3:25 AM · Differential
joshuaspence closed T10561: Make code coverage optional by default as Resolved.

Yep, that works. I didn't realize that null was a possible return value.

Mar 14 2016, 3:10 AM · Unit, Bug Report, Arcanist
chad closed T10581: test as Invalid.
Mar 14 2016, 2:17 AM · Bug Report
HPX created T10581: test.
Mar 14 2016, 1:44 AM · Bug Report

Mar 13 2016

chad closed T10577: Table of contents on unattached diff view lost a margin as Resolved.
Mar 13 2016, 11:28 PM · Differential
chad added a revision to T10577: Table of contents on unattached diff view lost a margin: Unknown Object (Differential Revision).
Mar 13 2016, 11:28 PM · Differential
Krenair added a comment to T10579: Consistency of status search fields across applications.

Sure, so it's not the idea of consistency here that's the issue, it's which existing implementation to actually go with, and you're not convinced Maniphest's one is the way forward?

Mar 13 2016, 10:45 PM · Audit, Differential, Feature Request
epriestley closed T10580: People Invites 'Advanced Search' is not very advanced. as Wontfix.

This isn't a bug, there are just no fields available.

Mar 13 2016, 10:32 PM · People, Bug Report
chad added a comment to T9372: Plan the future of "Bucketing" Query UIs.

T10579 mentions being able to query / build panels based on multiple states of a Diff or Audit.

Mar 13 2016, 10:31 PM · Restricted Project, Audit, ApplicationSearch, Differential
chad added a comment to T10579: Consistency of status search fields across applications.

Yeah, overall I don't think using a tokenizer universally is a good idea for statuses across Phabricator, but they make a lot of sense perhaps in a few key applications like the ones you mention. I just don't want us to make some forms harder to use/understand for the sake of consistency.

Mar 13 2016, 10:27 PM · Audit, Differential, Feature Request
Krenair added a comment to T10579: Consistency of status search fields across applications.

We generally don't want to be in the business of spending time debating design opinions

Mar 13 2016, 10:22 PM · Audit, Differential, Feature Request
chad updated subscribers of T9372: Plan the future of "Bucketing" Query UIs.
Mar 13 2016, 10:20 PM · Restricted Project, Audit, ApplicationSearch, Differential
chad merged task T10579: Consistency of status search fields across applications into T9372: Plan the future of "Bucketing" Query UIs.
Mar 13 2016, 10:20 PM · Audit, Differential, Feature Request
chad added a comment to T10579: Consistency of status search fields across applications.

For Differentia/Auditl see T9372 for the task to improve search and bucketing.

Mar 13 2016, 10:19 PM · Audit, Differential, Feature Request
chad added a comment to T10579: Consistency of status search fields across applications.

Sounds like Design Feedback (see T10208) as a general task, which we generally don't accept.

Mar 13 2016, 10:16 PM · Audit, Differential, Feature Request
Krenair created T10580: People Invites 'Advanced Search' is not very advanced..
Mar 13 2016, 10:02 PM · People, Bug Report
Krenair created T10579: Consistency of status search fields across applications.
Mar 13 2016, 9:59 PM · Audit, Differential, Feature Request
Luke081515.2 closed mock M1462: Test Mock.
Mar 13 2016, 7:52 PM · Android
alawson added a comment to T10575: Support project tags on Passphrase credentials.

EDIT: I removed my prior replies to clean up the thread and avoid anyone in the future mistaking what I wrote as anything but a simple misunderstanding.

Mar 13 2016, 5:12 PM · Projects, Passphrase, Feature Request
epriestley added a comment to T10576: Wrong highlighting for manually uploaded diff.

I didn't purge the cache here, but here's an updated version of the original diff without the rendering error:

Mar 13 2016, 4:53 PM · XHPAST, Differential, Bug Report
epriestley closed T10576: Wrong highlighting for manually uploaded diff as Resolved.
Mar 13 2016, 4:50 PM · XHPAST, Differential, Bug Report
epriestley added a comment to T10575: Support project tags on Passphrase credentials.

(I did half a diff on tags-on-credentials yesterday but Passphrase uses a couple of unique elements (like a "password" control) that don't currently have field support in EditEngine, so conversion wasn't entirely straightfoward.)

Mar 13 2016, 4:48 PM · Projects, Passphrase, Feature Request
epriestley renamed T10575: Support project tags on Passphrase credentials from Folders or tags for Projects to Support project tags on Passphrase credentials.
Mar 13 2016, 4:47 PM · Projects, Passphrase, Feature Request
epriestley added a comment to T10575: Support project tags on Passphrase credentials.

His reply was sent to everyone on this task (you, me, and himself).

Mar 13 2016, 4:46 PM · Projects, Passphrase, Feature Request
chad added a comment to T10575: Support project tags on Passphrase credentials.

Oh my reply was for myself because Evan beat me to a reply by a minute if you check the time stamps. Sorry for the confusion.

Mar 13 2016, 4:43 PM · Projects, Passphrase, Feature Request
alawson added a comment to T10575: Support project tags on Passphrase credentials.
Mar 13 2016, 4:40 PM · Projects, Passphrase, Feature Request
richardvanvelzen added a comment to T10576: Wrong highlighting for manually uploaded diff.

I wouldn't have expected the issue to be in xhpast at all. Thanks for the quick resolution!

Mar 13 2016, 2:52 PM · XHPAST, Differential, Bug Report
epriestley claimed T10576: Wrong highlighting for manually uploaded diff.
Mar 13 2016, 2:31 PM · XHPAST, Differential, Bug Report
epriestley added a comment to T10578: Provide 'Sort by Points' option in workboards.

This is made difficult by the nature of dragging cards into sorted positions on workboards: if you drag a card between a 5-point task and an 11-point task, we need to give it some number of points between 5 and 11, break the sort order of the column, or fling the card to the correct position in the column, which may be offscreen. Currently, in the simpler case of priority sorts, users don't seem to expect any of these behaviors, and all of these interactions are confusing to some users (today, we change priority).

Mar 13 2016, 2:29 PM · Workboards (v3), Feature Request
epriestley added a comment to T10576: Wrong highlighting for manually uploaded diff.

Thanks, that test case was very helpful.

Mar 13 2016, 2:17 PM · XHPAST, Differential, Bug Report
jdforrester added a comment to T10578: Provide 'Sort by Points' option in workboards.

Follow-up comment not worthy of the description: I'm not sure if this should be provided for projects unconditionally, or only if the project 'uses' points (which sounds like an expensive query, or Yet Another Damn Setting™ for project owners to have to set).

Mar 13 2016, 2:15 PM · Workboards (v3), Feature Request
jdforrester created T10578: Provide 'Sort by Points' option in workboards.
Mar 13 2016, 2:14 PM · Workboards (v3), Feature Request
epriestley added a revision to T10576: Wrong highlighting for manually uploaded diff: Unknown Object (Differential Revision).
Mar 13 2016, 2:07 PM · XHPAST, Differential, Bug Report
epriestley created T10577: Table of contents on unattached diff view lost a margin.
Mar 13 2016, 12:54 PM · Differential
epriestley added a comment to T10575: Support project tags on Passphrase credentials.

Being rude isn't a good way to attract people to a product.

Mar 13 2016, 12:51 PM · Projects, Passphrase, Feature Request
richardvanvelzen created T10576: Wrong highlighting for manually uploaded diff.
Mar 13 2016, 12:42 PM · XHPAST, Differential, Bug Report
alawson added a comment to T10575: Support project tags on Passphrase credentials.

Thanks for your replies. I searched pretty thoroughly for tagging and
didn't find specific examples so I didn't think it was possible to do these.

Mar 13 2016, 11:32 AM · Projects, Passphrase, Feature Request
alawson added a comment to T10575: Support project tags on Passphrase credentials.
Mar 13 2016, 11:23 AM · Projects, Passphrase, Feature Request
chad added a comment to Blog Post: Development Notes (2016 Week 10).

We certainly prefer consistency if possible, but I'm not opposed to being inconsistent if it's better for that individual product (ie, many installs only use Differential). But not sure the 'subheader' layout is going to be it. We'll get everything converted and live with it and see. There may be other options too, but at some point I need to move on.

Mar 13 2016, 5:21 AM
chad added a comment to Blog Post: Development Notes (2016 Week 10).

I think the owner of a task is the person assigned. The owner of a revision is the author.

Mar 13 2016, 5:12 AM
jcowgar added a comment to Blog Post: Development Notes (2016 Week 10).

You know, I just noticed the way that Differential shows created date... Not suggesting a change, just offering it up as a potential place for consistency?

Mar 13 2016, 5:10 AM

Mar 12 2016

chad added a comment to T9905: Upgrading: ApplicationEditor changes in Maniphest.

@rdfree50 see https://secure.phabricator.com/book/phabricator/article/support/ for what free support services are available for Phabricator. If you need direct 1 on 1 support from Phacility, we're happy to offer that as well (see https://secure.phabricator.com/w/consulting/).

Mar 12 2016, 11:09 PM · Maniphest, Installing & Upgrading
rdfree50 added a comment to T9905: Upgrading: ApplicationEditor changes in Maniphest.

Hi Evan,

Mar 12 2016, 10:51 PM · Maniphest, Installing & Upgrading
chad added a comment to T10575: Support project tags on Passphrase credentials.

i r slo

Mar 12 2016, 9:48 PM · Projects, Passphrase, Feature Request
chad added a comment to T10575: Support project tags on Passphrase credentials.

You can customize a project's sidenav with links to Pholio or Passphrase now. In the future we'll allow these links to be dashboards on the project itself.

Mar 12 2016, 9:48 PM · Projects, Passphrase, Feature Request
epriestley added a comment to T10575: Support project tags on Passphrase credentials.

or through Pholio

Mar 12 2016, 9:46 PM · Projects, Passphrase, Feature Request