Page MenuHomePhabricator
Feed All Stories

Mar 12 2016

alawson created T10575: Support project tags on Passphrase credentials.
Mar 12 2016, 9:30 PM · Projects, Passphrase, Feature Request
epriestley edited the content of Changelog.
Mar 12 2016, 7:31 PM
epriestley edited the content of Changelog.
Mar 12 2016, 7:31 PM
epriestley edited the content of 2016 Week 11 (Mid March).
Mar 12 2016, 7:31 PM
epriestley created 2016 Week 11 (Mid March).
Mar 12 2016, 7:29 PM
Luke081515.2 added a comment to T4887: Extend the blocking reviewers functionality universally.

Maybe a good idea too:

  • What about if you can configure at owners, if the owners should added as (blocking) reviewers automatically? Makes this simple too.
Mar 12 2016, 6:18 PM · Restricted Project, Herald, Differential
epriestley updated the task description for T10574: A pathway toward "All Reviewers Must Accept".
Mar 12 2016, 4:52 PM · FreeBSD, Restricted Project, Differential
epriestley added a parent task for T4887: Extend the blocking reviewers functionality universally: T10574: A pathway toward "All Reviewers Must Accept".
Mar 12 2016, 4:52 PM · Restricted Project, Herald, Differential
epriestley added a subtask for T10574: A pathway toward "All Reviewers Must Accept": T4887: Extend the blocking reviewers functionality universally.
Mar 12 2016, 4:52 PM · FreeBSD, Restricted Project, Differential
epriestley added a parent task for T731: Allow revisions to have alternate acceptance conditions: T10574: A pathway toward "All Reviewers Must Accept".
Mar 12 2016, 4:52 PM · Restricted Project, Restricted Project, Differential
epriestley added subtasks for T10574: A pathway toward "All Reviewers Must Accept": T731: Allow revisions to have alternate acceptance conditions, T9372: Plan the future of "Bucketing" Query UIs.
Mar 12 2016, 4:52 PM · FreeBSD, Restricted Project, Differential
epriestley added a parent task for T9372: Plan the future of "Bucketing" Query UIs: T10574: A pathway toward "All Reviewers Must Accept".
Mar 12 2016, 4:52 PM · Restricted Project, Audit, ApplicationSearch, Differential
epriestley created T10574: A pathway toward "All Reviewers Must Accept".
Mar 12 2016, 4:51 PM · FreeBSD, Restricted Project, Differential
epriestley closed T10570: Default quote action breaks tables as Resolved by committing Restricted Diffusion Commit.
Mar 12 2016, 3:57 PM · Wikimedia, Maniphest, Bug Report
epriestley closed T10539: Email not respecting TO and CC as Resolved by committing Restricted Diffusion Commit.
Mar 12 2016, 3:30 PM · Mail, Restricted Project, Bug Report
epriestley added a comment to T10571: Default quote action breaks text between lists.

This one's slightly trickier than T10570 because leading whitespace is semantic in lists.

Mar 12 2016, 3:09 PM · Remarkup, Wikimedia
epriestley added a revision to T10570: Default quote action breaks tables: Unknown Object (Differential Revision).
Mar 12 2016, 3:07 PM · Wikimedia, Maniphest, Bug Report
epriestley added a comment to T10565: Make Phriction articles accessible via version control or arc.

Thanks for the feature request! This feature request doesn't have the information we need to move forward, so I'd like to start by trying to understand why it doesn't. Specifically, it does not describe the root problem you are facing, and instead asks for a specific feature.

Mar 12 2016, 2:50 PM · Phriction, Feature Request
epriestley claimed T10539: Email not respecting TO and CC .
Mar 12 2016, 1:25 PM · Mail, Restricted Project, Bug Report
epriestley updated the task description for T1130: Add Mercurial tag/bookmark support to Diffusion.
Mar 12 2016, 1:03 PM · Mercurial, Diffusion
epriestley merged T10573: Show Mercurial bookmarks in Diffusion into T1130: Add Mercurial tag/bookmark support to Diffusion.
Mar 12 2016, 1:02 PM · Mercurial, Diffusion
epriestley merged task T10573: Show Mercurial bookmarks in Diffusion into T1130: Add Mercurial tag/bookmark support to Diffusion.
Mar 12 2016, 1:02 PM · Mercurial, Diffusion, Feature Request
epriestley renamed T1130: Add Mercurial tag/bookmark support to Diffusion from Add Mercurial tag support to Diffusion to Add Mercurial tag/bookmark support to Diffusion.
Mar 12 2016, 1:02 PM · Mercurial, Diffusion
epriestley added a comment to T1130: Add Mercurial tag/bookmark support to Diffusion.

Ah, you're right, thanks! I misread that page -- that does make Mercurial tags a lot easier to deal with.

Mar 12 2016, 1:02 PM · Mercurial, Diffusion
wschroo awarded T10333: Add groups to workboard columns a Like token.
Mar 12 2016, 8:28 AM · Restricted Project, Restricted Project, Workboards (v3)
isfs added a comment to T1130: Add Mercurial tag/bookmark support to Diffusion.

They're a function of an individual commit instead of being a function of the repository as a whole, so we'd have to do a lot more work to support them (it's not meaningful to, say, "list all tags in the repository", as it is with Git), ...

Mar 12 2016, 8:25 AM · Mercurial, Diffusion
isfs created T10573: Show Mercurial bookmarks in Diffusion.
Mar 12 2016, 8:10 AM · Mercurial, Diffusion, Feature Request
dereckson changed the visibility for D3673: Allow to push revisions to review by himself to Differential (bug T1879, change 1/2, Differential part).
Mar 12 2016, 6:26 AM
dereckson changed the visibility for D3674: Allow to push revisions to review by himself to Differential (bug T1879, change 2/2, Arcanist part).
Mar 12 2016, 6:26 AM
chad added projects to T10569: Subproject tasks in parent project backlog: Projects, Workboards.
Mar 12 2016, 12:48 AM · Workboards, Projects, Feature Request
chad added projects to T10568: Report partially failed builds better in Diffusion history: Diffusion, Harbormaster.
Mar 12 2016, 12:48 AM · Restricted Project, Harbormaster, Diffusion, Feature Request
zhiyuchen awarded T10333: Add groups to workboard columns a Like token.
Mar 12 2016, 12:42 AM · Restricted Project, Restricted Project, Workboards (v3)
epriestley added a comment to T10569: Subproject tasks in parent project backlog.

Make it possible to add "subproject columns" in the parent's workboard

Mar 12 2016, 12:23 AM · Workboards, Projects, Feature Request
chad added a comment to T4863: Allow Workboard Cards to be customized for display.

See T10333

Mar 12 2016, 12:22 AM · Projects, Wikimedia, Workboards
zhiyuchen added a comment to T4863: Allow Workboard Cards to be customized for display.

Not sure if this is the right place to request for this, in an earlier build, the cards have username of the task owner on it, which is convenient to do a quick search using Ctrl+F to find tasks by a particular username. In the latest stable build, usernames on the cards are replaced with user photos instead, which makes Ctrl+F by username impossible. I understand that "Advanced Filter" is a workaround, but it is less convenient.

Mar 12 2016, 12:20 AM · Projects, Wikimedia, Workboards
epriestley added a revision to T10539: Email not respecting TO and CC : Unknown Object (Differential Revision).
Mar 12 2016, 12:04 AM · Mail, Restricted Project, Bug Report

Mar 11 2016

epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 11 2016, 11:47 PM · Nuance (v1)
epriestley closed T10572: Call to undefined function msortv() as Resolved.
Mar 11 2016, 11:37 PM · Bug Report
Luke081515.2 added a comment to T10572: Call to undefined function msortv().
Mar 11 2016, 11:36 PM · Bug Report
epriestley added a comment to T10572: Call to undefined function msortv().

What version is libphutil at? This function was introduced in 821cad81.

Mar 11 2016, 11:31 PM · Bug Report
Luke081515.2 created T10572: Call to undefined function msortv().
Mar 11 2016, 11:29 PM · Bug Report
Krinkle created T10571: Default quote action breaks text between lists.
Mar 11 2016, 10:51 PM · Remarkup, Wikimedia
Krinkle created T10570: Default quote action breaks tables.
Mar 11 2016, 10:49 PM · Wikimedia, Maniphest, Bug Report
jpetso created T10569: Subproject tasks in parent project backlog.
Mar 11 2016, 10:44 PM · Workboards, Projects, Feature Request
michiel3 awarded Nuance a Like token.
Mar 11 2016, 10:39 PM
swisspol created T10568: Report partially failed builds better in Diffusion history.
Mar 11 2016, 9:49 PM · Restricted Project, Harbormaster, Diffusion, Feature Request
chad added a comment to Blog Post: Development Notes (2016 Week 10).

Maybe that's how GitHub works. There is some discussion on D15432 on why that's not likely easy for us. I do want to clean that up and get a "Claim/Unclaim" action built for Maniphest though.

Mar 11 2016, 9:25 PM
eadler closed T10566: Selecting custom policy does not show policy editor as Invalid.

Interesting. I just went and tried it again and different times its failing in different ways. I'm going to give up and assume this is something wonky in my browser until I prove otherwise.

Mar 11 2016, 9:24 PM · Policy, Bug Report
sweenzor awarded T7789: Support Git Large File Storage a Love token.
Mar 11 2016, 8:34 PM · Customer Impact, Restricted Project, Files, Diffusion
avivey added a comment to Blog Post: Development Notes (2016 Week 10).

For some reason, I now look for a "quick edit" button on each of the fields in the right pane (like "Projects"). Maybe because they look bigger now?

Mar 11 2016, 8:12 PM
avivey added a project to T10567: Ability to know who can do what in Maniphest EditEngine: ApplicationEditor.
Mar 11 2016, 8:11 PM · ApplicationEditor, Maniphest, Feature Request
revi created T10567: Ability to know who can do what in Maniphest EditEngine.
Mar 11 2016, 7:16 PM · ApplicationEditor, Maniphest, Feature Request
eadler added a comment to T10566: Selecting custom policy does not show policy editor.
  1. Go to a project, e.g., https://secure.phabricator.com/project/view/1408/
  2. Click manage - see https://secure.phabricator.com/project/manage/1408/
  3. Click "edit details"
  4. Select "visible too"
  5. [ note that the current policy is "custom policy" ]
  6. Select "custom policy"
Mar 11 2016, 7:11 PM · Policy, Bug Report
epriestley added a comment to T10566: Selecting custom policy does not show policy editor.

Yeah, persistent details would be helpful. My best guess at repro steps from the screenshot is:

Mar 11 2016, 6:27 PM · Policy, Bug Report
chad added a comment to T10566: Selecting custom policy does not show policy editor.

If you don't mind, can you provide specific steps to reproduce and attach actual photos to the task? External links can change/etc and we'd prefer to have a complete record. Thanks!

Mar 11 2016, 6:19 PM · Policy, Bug Report
eadler created T10566: Selecting custom policy does not show policy editor.
Mar 11 2016, 6:00 PM · Policy, Bug Report
eadler moved T731: Allow revisions to have alternate acceptance conditions from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Mar 11 2016, 5:57 PM · Restricted Project, Restricted Project, Differential
simenheg added a comment to T6473: Provide Arcanist option to disable ANSI colours / Disable ANSI colours on Windows.

I'd also very much welcome an option to turn off colors, since they don't work very well in the Emacs shell.

Mar 11 2016, 4:52 PM · libphutil, Arcanist
chad marked Q124: Is it possible to run the Phabricator daemons (phd) in the foreground? (Answer 343) as hidden.
Mar 11 2016, 3:16 PM
• peertheer added Q124: Is it possible to run the Phabricator daemons (phd) in the foreground? (Answer 343).
Mar 11 2016, 11:00 AM
maxie created T10565: Make Phriction articles accessible via version control or arc.
Mar 11 2016, 10:22 AM · Phriction, Feature Request
magnetik awarded T10364: Conpherence v4 (UI/UX) a Mountain of Wealth token.
Mar 11 2016, 9:02 AM · Conpherence (v4)
eadler added a comment to T731: Allow revisions to have alternate acceptance conditions.

T8887 is also related to this task

Mar 11 2016, 6:47 AM · Restricted Project, Restricted Project, Differential
eadler moved T731: Allow revisions to have alternate acceptance conditions from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Mar 11 2016, 6:25 AM · Restricted Project, Restricted Project, Differential
eadler edited projects for T8804: Replacing a Herald rule with a Doorkeeper extension, added: Restricted Project; removed Restricted Project.
Mar 11 2016, 6:24 AM · Restricted Project, Herald, Doorkeeper
chad added a comment to Q335: Is it possible to set a default # of points on Maniphest tasks....

yeah it might be weird to have it be a tag, then be in the title. Maybe you're right it should just be [t/p] (total tasks/points) in a tag.

Mar 11 2016, 2:52 AM · Maniphest
epriestley added a comment to Q335: Is it possible to set a default # of points on Maniphest tasks....

It needs a pile o' JS since it needs to change as you drag stuff around, but we can start with that.

Mar 11 2016, 2:48 AM · Maniphest
chad added a comment to Q335: Is it possible to set a default # of points on Maniphest tasks....

pht(‘%s (%d)’, $title, $task_count);

Mar 11 2016, 2:47 AM · Maniphest
epriestley closed T10546: Time Tracking info no longer shown in Maniphest tasks as Resolved by committing Restricted Diffusion Commit.
Mar 11 2016, 2:45 AM · Phrequent, Bug Report
epriestley closed T10556: edit policy message as Invalid.

I'm going to close this since there's no pathway forward that I can see. We might just not understand your request.

Mar 11 2016, 2:23 AM · Bug Report
epriestley closed T10549: Getting PhutilTypeCheckException on certaion Differential pages as Resolved by committing Restricted Diffusion Commit.
Mar 11 2016, 2:16 AM · Differential, Bug Report
epriestley added a revision to T10546: Time Tracking info no longer shown in Maniphest tasks: Unknown Object (Differential Revision).
Mar 11 2016, 2:14 AM · Phrequent, Bug Report
epriestley added a comment to Q335: Is it possible to set a default # of points on Maniphest tasks....

I slightly miss the card counts too, since we have points enabled on this install but don't really use them.

Mar 11 2016, 2:06 AM · Maniphest
avivey renamed T10564: Mail "Delivery" tab is confusing. from Mail void reasons always(?) declare "Self Mail" to Mail "Delivery" tab is confusing..
Mar 11 2016, 1:59 AM · Restricted Project, Mail, Bug Report
eadler added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

Hrm, I'm going to do some followup with our DBAs as well. The performance numbers above were copied from the DBA analysis; however, when I make the change in production, rather than in staging, some of the behavior does not directly replicate.

Mar 11 2016, 1:51 AM · Infrastructure
epriestley claimed T10546: Time Tracking info no longer shown in Maniphest tasks.

I'm going to write a CurtainExtension for it (I just missed it in the original round) but you might have to fix my bad stylin'.

Mar 11 2016, 1:42 AM · Phrequent, Bug Report
chad added a comment to T10546: Time Tracking info no longer shown in Maniphest tasks.

Not sure offhand how to fix this.

Mar 11 2016, 1:41 AM · Phrequent, Bug Report
chad updated subscribers of T10546: Time Tracking info no longer shown in Maniphest tasks.
Mar 11 2016, 1:41 AM · Phrequent, Bug Report
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

I'll leave this open for now since the behavior still feels a bit spooky to me, let me know how things go once you get the key in place? If they're smooth, we can chalk this up to be being bad at MySQL.

Mar 11 2016, 1:41 AM · Infrastructure
epriestley added a revision to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates: Unknown Object (Differential Revision).
Mar 11 2016, 1:36 AM · Infrastructure
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

I suppose the originally proposed key may be better than I think. I was imagining that it couldn't use the third part of the key (on changeType) but I suppose it actually can. I'm still confused by the UNION ALL behavior, but if the key's working on your dataset I think it's fine to add it -- it takes <1 second to add to our dataset, so even for large datasets it shouldn't be wildly unreasonable, even if we do find a better key later.

Mar 11 2016, 1:32 AM · Infrastructure
epriestley added a comment to T10564: Mail "Delivery" tab is confusing..

I'm seeing a replay of the (current?) rules about this message?

Mar 11 2016, 1:26 AM · Restricted Project, Mail, Bug Report
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

That's fine -- it looks like it's picking up the keys, I'm just not sure why it's then examining 303 million rows when it has the keys available.

Mar 11 2016, 1:24 AM · Infrastructure
eadler added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

to clarify: I removed the key I originally added

KEY `commitID` (`commitID`,`isDirect`,`changeType`)

was I not supposed to do that?

Mar 11 2016, 1:13 AM · Infrastructure
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

Hrrm, let me see if I can reproduce anything like that, that's totally bizarre to me.

Mar 11 2016, 1:11 AM · Infrastructure
eadler added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.
KEY `cidid` (`commitID`,`isDirect`),
KEY `cidct` (`commitID`,`changeType`)

are the keys created

Mar 11 2016, 1:09 AM · Infrastructure
eadler added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.
id	select_type	table	type	possible_keys	key	key_len	ref	rows	Extra
1	PRIMARY	repository_pathchange	index	PRIMARY,cidid,cidct	cidid	5	NULL	303320447	Using where; Using index
2	UNION	repository_pathchange	index	PRIMARY,cidid,cidct	cidct	8	NULL	303320447	Using where; Using index
NULL	UNION RESULT	<union1,2>	ALL	NULL	NULL	NULL	NULL	NULL	Using temporary
Mar 11 2016, 1:08 AM · Infrastructure
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

Hmm, weird. Can you show me the EXPLAIN SELECT ... for that?

Mar 11 2016, 1:08 AM · Infrastructure
eadler added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

That variant of the query is slow as well.

Mar 11 2016, 1:07 AM · Infrastructure
avivey added a comment to T10564: Mail "Delivery" tab is confusing..

It's definitely a little surprising that "Outbox > Delivery" is describing a sort of hypothetical scenario that assumes you were a recipient in the first place.

Mar 11 2016, 1:03 AM · Restricted Project, Mail, Bug Report
epriestley added a comment to T10564: Mail "Delivery" tab is confusing..

Maybe we could add a "you weren't a recipient in the first place" reason which has priority over the other reasons, and make the text on the page more clear. Or just remove "Outbox" completely, I'm not sure it's really useful.

Mar 11 2016, 1:02 AM · Restricted Project, Mail, Bug Report
epriestley added a comment to T10564: Mail "Delivery" tab is confusing..

That is, "Delivery" is "delivery to you, the viewer". Maybe that's what's unclear?

Mar 11 2016, 1:01 AM · Restricted Project, Mail, Bug Report
epriestley added a comment to T10564: Mail "Delivery" tab is confusing..

The "Delivery" tab is specific to the viewer, not the mail. There's no way to see see why mail was or wasn't delivered to other users.

Mar 11 2016, 12:58 AM · Restricted Project, Mail, Bug Report
epriestley added a comment to T10564: Mail "Delivery" tab is confusing..

223663 is you adding a comment to Conpherence.
184911 is you moving a task on a workboard.
219192 is you attaching a task to a revision.

Mar 11 2016, 12:56 AM · Restricted Project, Mail, Bug Report
avivey added a comment to T10564: Mail "Delivery" tab is confusing..

If I understand the mail visibility, you should be able to see 229037
(PHID-MTAM-qfsqnqkebrkuaohcacsg), because it's "to" you?

Mar 11 2016, 12:54 AM · Restricted Project, Mail, Bug Report
avivey added a comment to T10564: Mail "Delivery" tab is confusing..

My last comment added 3 messages in my outbox:

Mar 11 2016, 12:52 AM · Restricted Project, Mail, Bug Report
epriestley added a comment to T10564: Mail "Delivery" tab is confusing..

I can't actually see them, let me go pull up the console.

Mar 11 2016, 12:50 AM · Restricted Project, Mail, Bug Report
avivey added a comment to T10564: Mail "Delivery" tab is confusing..

I think all of those are not self-mail - they are all have "TO" as other users than myself.

Mar 11 2016, 12:48 AM · Restricted Project, Mail, Bug Report
epriestley added a comment to T10564: Mail "Delivery" tab is confusing..

In all of them, I'm the actor, but they specify "Self Mail" as the (a) reason for voiding.
I do have "self mail" disabled, so it might be taking that?

Mar 11 2016, 12:43 AM · Restricted Project, Mail, Bug Report
epriestley closed T10562: Inline comments can become separated if replies cross update boundaries as Resolved by committing Restricted Diffusion Commit.
Mar 11 2016, 12:41 AM · Differential, Restricted Project