Page MenuHomePhabricator
Feed All Stories

Sun, Jan 10

epriestley added a task to D21496: Remove final from private functions for PHP 8 compatibility: T13588: PHP 8 Compatibility.
Sun, Jan 10, 10:23 PM
epriestley added revisions to T13588: PHP 8 Compatibility: D21498: Fix error handler on PHP 8, D21497: Suppress PHP 8 deprecation warning in __arcanist_init_script__, D21496: Remove final from private functions for PHP 8 compatibility.
Sun, Jan 10, 10:23 PM · Infrastructure
epriestley triaged T13588: PHP 8 Compatibility as Low priority.
Sun, Jan 10, 10:23 PM · Infrastructure
jrtc27 closed D21497: Suppress PHP 8 deprecation warning in __arcanist_init_script__.
Sun, Jan 10, 10:21 PM
jrtc27 committed rARC930f7e117d81: Suppress PHP 8 deprecation warning in __arcanist_init_script__ (authored by jrtc27).
Suppress PHP 8 deprecation warning in __arcanist_init_script__
Sun, Jan 10, 10:21 PM
epriestley accepted D21497: Suppress PHP 8 deprecation warning in __arcanist_init_script__.

Ah, great. Making this variation of the change will probably never actually matter compared to the first version, but I'll sleep at least a little better at night.

Sun, Jan 10, 10:20 PM
jrtc27 retitled D21497: Suppress PHP 8 deprecation warning in __arcanist_init_script__ from Fix PHP 8 deprecation warning in __arcanist_init_script__ to Suppress PHP 8 deprecation warning in __arcanist_init_script__.
Sun, Jan 10, 10:19 PM
jrtc27 added a comment to D21497: Suppress PHP 8 deprecation warning in __arcanist_init_script__.

What's the specific issue you run into with PHP8 with the existing code -- the function emits a deprecation warning when called?

Since the attack surface on the XML entity loader is huge/scary (historically, see D8049), I'd prefer to continue explicitly disabling it if we can. Although there's probably no real risk, I can imagine scenarios like some distro shipping a version of PHP which enables it by default, or users enabling it by default because they run some other software that needs it alongside Phabricator. In these cases, we're a little better off at runtime if we continue disabling the loader.

If this just raises a deprecation warning under PHP8, I'd be more comfortable "fixing" it by suppressing the warning with @ (so @libxml_disable_entity_loader(true); -- not sure how familiar you are with PHP) so that we're still making sure the loader is disabled. Is that reasonable, or does it create more problems?

Sun, Jan 10, 10:19 PM
jrtc27 updated the diff for D21497: Suppress PHP 8 deprecation warning in __arcanist_init_script__.

Suppress deprecation warning with @ rather than skip the function call.

Sun, Jan 10, 10:19 PM
epriestley accepted D21498: Fix error handler on PHP 8.

It's possible that third party code which installs custom error listeners via setErrorListener() that expect 'context' to be populated may exist, I'm not aware of any such code and think it probably does not exist. It would also be easy to update any such code in response to this change, so I think it's not worth retaining backward compatibility with a dummy parameter and that this is the most-desirable version of this change.

Sun, Jan 10, 10:17 PM
epriestley requested changes to D21497: Suppress PHP 8 deprecation warning in __arcanist_init_script__.

What's the specific issue you run into with PHP8 with the existing code -- the function emits a deprecation warning when called?

Sun, Jan 10, 10:08 PM
jrtc27 closed D21496: Remove final from private functions for PHP 8 compatibility.
Sun, Jan 10, 10:05 PM
jrtc27 committed rARC3ab2b407db4a: Remove final from private functions for PHP 8 compatibility (authored by jrtc27).
Remove final from private functions for PHP 8 compatibility
Sun, Jan 10, 10:05 PM
epriestley added a comment to D21496: Remove final from private functions for PHP 8 compatibility.

I added you to Blessed Committers, so you should be able to arc land this yourself. See the description of that project for more detailed instructions, or let me know if you run into issues. "Land Revision" here in the web UI should also work, or I can just pull it for you if that's easier.

Sun, Jan 10, 10:02 PM
epriestley added a member for Blessed Committers: jrtc27.
Sun, Jan 10, 10:01 PM
epriestley accepted D21496: Remove final from private functions for PHP 8 compatibility.

Thanks! There are some similar linters already (e.g., for final in a final class, or final on an abstract method) but this particular combination (private + final) slipped through. I'll add a linter so these don't get re-introduced and apply an equivalent change to Phabricator.

Sun, Jan 10, 10:00 PM
epriestley removed a reviewer for D21496: Remove final from private functions for PHP 8 compatibility: Unknown Object (Owners Package).
Sun, Jan 10, 9:55 PM
jrtc27 requested review of D21498: Fix error handler on PHP 8.
Sun, Jan 10, 9:54 PM
jrtc27 requested review of D21497: Suppress PHP 8 deprecation warning in __arcanist_init_script__.
Sun, Jan 10, 9:54 PM
jrtc27 requested review of D21496: Remove final from private functions for PHP 8 compatibility.
Sun, Jan 10, 9:54 PM

Fri, Jan 8

yuanchen.zhu added a comment to T11091: Make `arc patch` try the local working copy and staging areas.

Just want to add a note that with git lfs managed files, arc patch won't work unless one fetch the ref tag and then the lfs bobs from the staging server first. See https://discourse.phabricator-community.org/t/arc-patch-fails-with-git-lfs-files/2447/3

Fri, Jan 8, 2:06 AM · Haskell.org, Arcanist

Tue, Dec 22

flippingtables updated flippingtables.
Tue, Dec 22, 1:35 PM

Dec 18 2020

epriestley added a comment to T13230: Native Applications.

As of macOS X 11 (Big Sur), php on the CLI emits:

Dec 18 2020, 12:48 AM · Phacility

Dec 3 2020

epriestley added a comment to T13269: Improve initial implementations of Workboard triggers and groups.

That seems reasonable. I also ran into a couple of other suggestions elsewhere:

Dec 3 2020, 4:32 PM · Workboards (v3)
20after4 added a comment to T13269: Improve initial implementations of Workboard triggers and groups.

Off the wall suggestion: how about a trigger that sets the subtype:

Dec 3 2020, 7:31 AM · Workboards (v3)

Nov 19 2020

amckinley closed D21494: Change baseURI for Packages to avoid 404.
Nov 19 2020, 9:48 PM
amckinley committed rPb2ab18f8f3d0: Change baseURI for Packages to avoid 404 (authored by amckinley).
Change baseURI for Packages to avoid 404
Nov 19 2020, 9:48 PM
amckinley updated the diff for D21494: Change baseURI for Packages to avoid 404.

Trailing slash

Nov 19 2020, 9:47 PM
epriestley requested review of D21495: When updating a Ferret search index document, reuse existing rows where possible.
Nov 19 2020, 9:37 PM
epriestley added a revision to T13587: Ferret may exhaust AUTO_INCREMENT ID space of "ngrams" table after many reindexes: D21495: When updating a Ferret search index document, reuse existing rows where possible.
Nov 19 2020, 9:36 PM · Search
epriestley accepted D21494: Change baseURI for Packages to avoid 404.

Seems reasonable, definitely the highest impact-per-character change I can come up with.

Nov 19 2020, 9:35 PM
amckinley requested review of D21494: Change baseURI for Packages to avoid 404.
Nov 19 2020, 9:33 PM
epriestley triaged T13587: Ferret may exhaust AUTO_INCREMENT ID space of "ngrams" table after many reindexes as Normal priority.
Nov 19 2020, 8:24 PM · Search

Nov 7 2020

epriestley requested review of D21493: Separate Herald transcripts into several different views.
Nov 7 2020, 12:21 AM
epriestley added a revision to T13586: In Herald transcripts, surface exceptions encountered while evaluating fields: D21493: Separate Herald transcripts into several different views.
Nov 7 2020, 12:20 AM · Herald
epriestley triaged T13586: In Herald transcripts, surface exceptions encountered while evaluating fields as Low priority.
Nov 7 2020, 12:18 AM · Herald
epriestley closed T13298: Improve Herald profiling information available in transcripts as Resolved.

The profiling in D20566 seems satisfactory, and has been useful in resolving or understanding a few performance-related issues.

Nov 7 2020, 12:09 AM · Herald

Nov 6 2020

artms requested review of D21492: Fix php code example for conduit calls.
Nov 6 2020, 7:49 PM
artms added a comment to D19666: Improve Herald Rule execution speed for Personal Herald rules by avoiding expensive lookup for all adapters and instead use specific adapter check.

On my personal resource limited RasberryPI alike server (4x1.2ghz ARM A53, 2GB ram, php 7.4.12) running Phabricator - this changes saves ~15ms of runtime (180ms vs 167ms after) when running:

./bin/herald test --object T19 --type HeraldManiphestTaskAdapter
Nov 6 2020, 7:38 PM
artms updated the diff for D19666: Improve Herald Rule execution speed for Personal Herald rules by avoiding expensive lookup for all adapters and instead use specific adapter check.

Rebase

Nov 6 2020, 7:33 PM
artms requested review of D21049: Add Email command to mute notifications for object.
Nov 6 2020, 7:11 PM
artms abandoned D20972: `arc patch --arcbundle` might require authentification if it can't find base commit.

This change is probably no longer relevant with recent large refactoring of arcanist

Nov 6 2020, 7:10 PM
artms requested review of D21048: Do not count hidden changesets as changed changesets during diff comparison.
Nov 6 2020, 7:07 PM
artms updated subscribers of D21491: Handle case when Differential Revision diff is an empty commit.
Nov 6 2020, 7:03 PM
artms requested review of D21491: Handle case when Differential Revision diff is an empty commit.
Nov 6 2020, 7:01 PM
artms requested review of D21490: Empty commit change.
Nov 6 2020, 6:51 PM

Nov 3 2020

epriestley closed D21488: Add a basic "harbormaster.step.search" API method.
Nov 3 2020, 8:50 PM
epriestley committed rPbf8707d3a9bf: Add a basic "harbormaster.step.search" API method (authored by epriestley).
Add a basic "harbormaster.step.search" API method
Nov 3 2020, 8:50 PM
epriestley closed D21489: Add a basic "harbormaster.step.edit" API method.
Nov 3 2020, 8:50 PM
epriestley committed rP34082efb02c7: Add a basic "harbormaster.step.edit" API method (authored by epriestley).
Add a basic "harbormaster.step.edit" API method
Nov 3 2020, 8:50 PM
epriestley added a revision to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit: D21488: Add a basic "harbormaster.step.search" API method.
Nov 3 2020, 8:50 PM · Conduit, Harbormaster
epriestley updated the summary of D21488: Add a basic "harbormaster.step.search" API method.
Nov 3 2020, 8:50 PM
epriestley added a comment to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit.
  • There is no way to pull custom field values with *.search. See above.
    • There is no way to edit non-custom field values with *.edit. The underlying transactions haven't been modularized yet; they should be, then EditEngine should get appropriate EditField definitions.
    • There's no way to identify which custom fields can be edited. This overlaps with T13248, but is also a Conduit API Console UI problem. The web UI should have some way to inspect parameter variations per object subtype for available subtypes.
      • As a workaround, you can try to edit an invalid field. The error message will identify valid fields.
    • There's no way to create steps with *.edit because you can't specify a step type. See T13449 for a general variation of the "type is required to initialize objects" problem.
Nov 3 2020, 8:49 PM · Conduit, Harbormaster
epriestley requested review of D21489: Add a basic "harbormaster.step.edit" API method.
Nov 3 2020, 8:47 PM
epriestley added a revision to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit: D21489: Add a basic "harbormaster.step.edit" API method.
Nov 3 2020, 8:46 PM · Conduit, Harbormaster
epriestley renamed T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit from Expose "harbormaster.buildstep.edit" and "harbormaster.buildstep.search" over Conduit to Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit.
Nov 3 2020, 8:45 PM · Conduit, Harbormaster
epriestley updated the diff for D21488: Add a basic "harbormaster.step.search" API method.
  • Use more consistent capitalization.
Nov 3 2020, 8:38 PM
epriestley requested review of D21488: Add a basic "harbormaster.step.search" API method.
Nov 3 2020, 8:36 PM
epriestley added a comment to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit.

HarbormasterBuildStepCoreCustomField emits no fields if a BuildStep has no attached Implementation object. This dates from D15352 and is conceptually reasonable ("don't crash if a build step exists but the implementation no longer does") but should probably be represented differently (e.g., an explicit "InvalidImplementation").

Nov 3 2020, 8:18 PM · Conduit, Harbormaster
epriestley triaged T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit as Normal priority.
Nov 3 2020, 8:17 PM · Conduit, Harbormaster
epriestley renamed T13100: PCRE segfaults readily with default "pcre.backtrack_limit" and "pcre.recursion_limit" values from PCRE segfaults readily with default "pcre.backtrace_limit" and "pcre.recursion_limit" values to PCRE segfaults readily with default "pcre.backtrack_limit" and "pcre.recursion_limit" values.
Nov 3 2020, 7:36 PM · Phacility
epriestley committed rPae5a38f3349f: Guarantee terms in PhabricatorAuthPasswordEngine are strings (authored by epriestley).
Guarantee terms in PhabricatorAuthPasswordEngine are strings
Nov 3 2020, 7:05 PM
epriestley closed D21487: Guarantee terms in PhabricatorAuthPasswordEngine are strings.
Nov 3 2020, 7:04 PM
epriestley closed T13584: Shallow Git clones fail under recent versions of Git as Resolved.

This appears fixed by D21484 (and @20after4 confirmed the fix on rPc0414732 -- thanks!) so I'm going to mark it as resolved.

Nov 3 2020, 7:04 PM · Diffusion
epriestley requested review of D21487: Guarantee terms in PhabricatorAuthPasswordEngine are strings.
Nov 3 2020, 6:56 PM
epriestley added a revision to T2312: Modifying PHP: D21487: Guarantee terms in PhabricatorAuthPasswordEngine are strings.
Nov 3 2020, 6:37 PM · Infrastructure
epriestley added a comment to T2312: Modifying PHP.

See https://discourse.phabricator-community.org/t/strpos-throwing-in-phabricatorauthpasswordengine/4335, and D21477.

Nov 3 2020, 6:19 PM · Infrastructure

Nov 2 2020

20after4 accepted rPc04147328fa3: Fix isValidGitShallowCloneResponse.

This has been tested in wmf production and the fix is working.

Nov 2 2020, 10:21 PM

Oct 30 2020

epriestley added a comment to D21484: Fix isValidGitShallowCloneResponse.

Ah, thanks for the pointers!

Oct 30 2020, 11:30 PM · Diffusion
dzduvall added a comment to D21484: Fix isValidGitShallowCloneResponse.

Minor nitpicks inlines, I'll just tweak them locally as I land this.

(Since this wasn't submitted with arc, the Git "Author" information has been lost and the commit will be incorrectly attributed to me as an author. If you submit further patches, you can use arc to retain authorship information if you'd like.)

Oct 30 2020, 10:48 PM · Diffusion
epriestley committed rPc04147328fa3: Fix isValidGitShallowCloneResponse (authored by epriestley).
Fix isValidGitShallowCloneResponse
Oct 30 2020, 8:46 PM
epriestley closed D21484: Fix isValidGitShallowCloneResponse.
Oct 30 2020, 8:46 PM · Diffusion
epriestley accepted D21484: Fix isValidGitShallowCloneResponse.

Minor nitpicks inlines, I'll just tweak them locally as I land this.

Oct 30 2020, 8:32 PM · Diffusion
epriestley committed rP671986592baf: Add a missing "GROUP BY" to MailQuery when querying for multiple recipients (authored by epriestley).
Add a missing "GROUP BY" to MailQuery when querying for multiple recipients
Oct 30 2020, 8:02 PM
epriestley closed D21486: Add a missing "GROUP BY" to MailQuery when querying for multiple recipients.
Oct 30 2020, 8:02 PM
epriestley requested review of D21486: Add a missing "GROUP BY" to MailQuery when querying for multiple recipients.
Oct 30 2020, 7:58 PM
jcox updated jcox.
Oct 30 2020, 5:31 PM
avivey published D21485: Packages: Load'em from .cache for review.
Oct 30 2020, 4:54 PM
avivey added a revision to T5055: Distribution mechanism for arc extensions: D21485: Packages: Load'em from .cache.
Oct 30 2020, 4:50 PM · Arcanist

Oct 26 2020

sshannin added a comment to T4627: PhabricatorTaskmasterDaemon 100% CPU load.

I know it's an old thread, but I am encountering what is, as far as I can tell, exactly the same issue. I'm on the latest version of trunk (~Oct 26) with php 5.5.9 on Linux 3.13.0. I also observed the issue on the May 30 version.

Oct 26 2020, 11:17 PM · Daemons
altendky added a comment to T5508: Add branch name parameter to Harbormaster "Make HTTP Request" build step.

I think I've got a small tidbit to add on a specific use-case with Jenkins. I had been using pipeline builds which are working nicely but I just tried to setup a multi-branch pipeline build and this requires the branch name in the Jenkins URL of the HTTP request triggering the build. I suspect in this case the proper thing to do would be to trigger and build twice. I guess that's more of an on-branch-change sort of situation than on-commit and using those triggers in Herald (they look to be present, I haven't used them) and having that information passed on to Harbormaster as mentioned could fill the need.

Oct 26 2020, 9:40 PM · Restricted Project, Harbormaster

Oct 24 2020

epriestley triaged T13584: Shallow Git clones fail under recent versions of Git as Low priority.
Oct 24 2020, 11:05 PM · Diffusion
dzduvall requested review of D21484: Fix isValidGitShallowCloneResponse.
Oct 24 2020, 10:43 PM · Diffusion

Oct 22 2020

artms added a comment to D21287: Fix an issue where inline comments with only edit suggestions are considered empty.

@epriestley - empty inline comment with suggestion renders rather peculiar transaction which is somewhat confusing and odd... Any plans on tackling it? Like See context greyed out...

Oct 22 2020, 9:02 AM

Oct 19 2020

bastiao added a comment to T13576: Certain "arc land" merges fail when they should succeed.

Same issue here.

Oct 19 2020, 10:32 PM · Arcanist
epriestley committed rP86ad69863930: (stable) When a new, deleted, draft inline is revived with "Undo", undelete it (authored by epriestley).
(stable) When a new, deleted, draft inline is revived with "Undo", undelete it
Oct 19 2020, 7:37 PM
epriestley committed rPbc4f86d27996: When a new, deleted, draft inline is revived with "Undo", undelete it (authored by epriestley).
When a new, deleted, draft inline is revived with "Undo", undelete it
Oct 19 2020, 7:34 PM
epriestley closed D21483: When a new, deleted, draft inline is revived with "Undo", undelete it.
Oct 19 2020, 7:34 PM
epriestley requested review of D21483: When a new, deleted, draft inline is revived with "Undo", undelete it.
Oct 19 2020, 7:32 PM
epriestley edited the content of Changelog.
Oct 19 2020, 7:05 PM
epriestley created an object: 2020 Week 42.
Oct 19 2020, 7:04 PM
epriestley committed rARCac54d61d7af2: (stable) Promote 2020 Week 42 (authored by epriestley).
(stable) Promote 2020 Week 42
Oct 19 2020, 7:04 PM
epriestley committed rP916bce119a2b: (stable) Promote 2020 Week 42 (authored by epriestley).
(stable) Promote 2020 Week 42
Oct 19 2020, 7:04 PM
epriestley committed rPb2e96df3a3be: Update "arc call-conduit" instructions in Conduit API console for required "--" (authored by epriestley).
Update "arc call-conduit" instructions in Conduit API console for required "--"
Oct 19 2020, 7:02 PM
epriestley closed D21482: Update "arc call-conduit" instructions in Conduit API console for required "--".
Oct 19 2020, 7:02 PM
epriestley requested review of D21482: Update "arc call-conduit" instructions in Conduit API console for required "--".
Oct 19 2020, 6:55 PM
epriestley added a revision to T13491: Why does Arcanist require "--"?: D21482: Update "arc call-conduit" instructions in Conduit API console for required "--".
Oct 19 2020, 6:54 PM · Guides

Oct 16 2020

epriestley committed rARC4b3baca999a4: Fix a typo of "previously" in FutureIterator (authored by epriestley).
Fix a typo of "previously" in FutureIterator
Oct 16 2020, 9:23 PM
epriestley closed D21478: Fix a typo of "previously" in FutureIterator.
Oct 16 2020, 9:23 PM
epriestley committed rP2b8bbae5fb27: Set an explicit height when drawing the dependent revision graph (authored by epriestley).
Set an explicit height when drawing the dependent revision graph
Oct 16 2020, 9:10 PM