Paths

Table of Contentst

Differential D21486

Add a missing "GROUP BY" to MailQuery when querying for multiple recipients
ClosedPublic
Actions

Authored by epriestley on Oct 30 2020, 7:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 16, 4:16 AM

	Unknown Object (File)
	Mon, Dec 16, 1:49 AM

	Unknown Object (File)
	Mon, Dec 9, 4:00 AM

	Unknown Object (File)
	Wed, Dec 4, 7:48 PM

	Unknown Object (File)
	Wed, Dec 4, 5:29 PM

	Unknown Object (File)
	Wed, Dec 4, 4:28 PM

	Unknown Object (File)
	Wed, Nov 27, 8:52 AM

	Unknown Object (File)
	Tue, Nov 26, 7:18 PM

Subscribers

None

Details

Reviewers: None
Commits: rP671986592baf: Add a missing "GROUP BY" to MailQuery when querying for multiple recipients

Summary

See https://discourse.phabricator-community.org/t/mail-details-view-broken/4315. The change in D21400 detects a missing "GROUP BY" in some variations of this query.

Specifically, we may join multiple recipient rows (since mail may have multiple recipients) and then fail to group the results.

Fix this by adding the "GROUP BY". Additionally, remove the special-cased behavior when no authors or recipients are specified -- it's complicated and not entirely correct (e.g., may produce a "no object" instead of a policy error when querying by ID), and likely predates overheating.

Test Plan

Disabled metamta.one-mail-per-recipient in Config.
Generated a message to 2+ recipients.
Viewed the message detail; queried for the message by specifying 2+ recipients.
Viewed the unfiltered list of messages, saw the query overheat.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Oct 30 2020, 7:57 PM

Harbormaster completed remote builds in B24953: Diff 51139.Oct 30 2020, 7:58 PM

epriestley requested review of this revision.Oct 30 2020, 7:58 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 30 2020, 8:02 PM

Closed by commit rP671986592baf: Add a missing "GROUP BY" to MailQuery when querying for multiple recipients (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP671986592baf: Add a missing "GROUP BY" to MailQuery when querying for multiple recipients.

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

query/

PhabricatorMetaMTAMailQuery.php

53 lines

infrastructure/

query/

policy/

PhabricatorPolicyAwareQuery.php

2 lines

Diff 51140

src/applications/metamta/query/PhabricatorMetaMTAMailQuery.php

Loading...

src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php

Loading...