Page MenuHomePhabricator

Add a missing "GROUP BY" to MailQuery when querying for multiple recipients
ClosedPublic

Authored by epriestley on Oct 30 2020, 7:57 PM.

Details

Summary

See https://discourse.phabricator-community.org/t/mail-details-view-broken/4315. The change in D21400 detects a missing "GROUP BY" in some variations of this query.

Specifically, we may join multiple recipient rows (since mail may have multiple recipients) and then fail to group the results.

Fix this by adding the "GROUP BY". Additionally, remove the special-cased behavior when no authors or recipients are specified -- it's complicated and not entirely correct (e.g., may produce a "no object" instead of a policy error when querying by ID), and likely predates overheating.

Test Plan
  • Disabled metamta.one-mail-per-recipient in Config.
  • Generated a message to 2+ recipients.
  • Viewed the message detail; queried for the message by specifying 2+ recipients.
  • Viewed the unfiltered list of messages, saw the query overheat.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Oct 30 2020, 8:02 PM
This revision was automatically updated to reflect the committed changes.