Page MenuHomePhabricator

Handle case when Differential Revision diff is an empty commit
Needs ReviewPublic

Authored by artms on Fri, Nov 6, 7:00 PM.

Details

Reviewers
None
Group Reviewers
Blessed Reviewers
Summary

Diff with empty changeset causes Differential Revision rendering failure (see: https://secure.phabricator.com/D21490).
Such situation might happen if such empty commit was commited to repository and Phabricator picks it up to close corresponding Differential Revsion (this happened in our instance).
It is possible to also reproduce it with heavily modified arcanist where "emptiness" checks are on purpose removed (D21490 case).

Test Plan

Pre patch generate Diff with empty changeset D21490. Try opening - fails. Apply patch - try opening - works, change as expected is displayed as empty

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint OK
Unit
Unit Tests Skipped
Build Status
Buildable 24965
Build 34447: Run Core Tests
Build 34446: arc lint + arc unit