HomePhabricator

Remove final from private functions for PHP 8 compatibility

Description

Remove final from private functions for PHP 8 compatibility

Summary:
This combination does not make sense and PHP 8 errors with:

Private methods cannot be final as they are never overridden by other classes

Thus remove the redundant final from all such functions.

Test Plan: Used to create this revision with PHP 8 on macOS

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D21496

Details

Provenance
jrtc27Authored on Jan 10 2021, 10:05 PM
industryPushed on Jan 10 2021, 10:05 PM
Reviewer
Blessed Reviewers
Differential Revision
D21496: Remove final from private functions for PHP 8 compatibility
Parents
rARC4b3baca999a4: Fix a typo of "previously" in FutureIterator
Branches
Unknown
Tags
Unknown
Build Status
Buildable 24978
Build 34468: Run Core Tests