Page MenuHomePhabricator

Do not count hidden changesets as changed changesets during diff comparison
Needs ReviewPublic

Authored by artms on Apr 2 2020, 12:18 PM.

Details

Reviewers
epriestley
Pawka
Group Reviewers
Blessed Reviewers
Summary

Phabricator will bailout to compare diff changes in revision even though changes between diffs was small

Test Plan

Compared diffs in revision which has +1k files changed but diff between changeset is actually small - saw difference instead of warning that This very large diff affects more than 1,000 files. Use the Changeset List to browse changes.

Diff Detail

Repository
rP Phabricator
Branch
arcpatch-D21048
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 24966
Build 34449: Run Core Tests
Build 34448: arc lint + arc unit

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 2 2020, 12:18 PM
Harbormaster failed remote builds in B23967: Diff 50148!
src/applications/differential/controller/DifferentialRevisionViewController.php
16

We also can substract hidden changesets here instead of setting changeset size artificially smaller...

Tests failed due to:

PHP Fatal error:  Cannot override final method Future::getResult() in /core/data/drydock/workingcopy-89/repo/phabricator/src/applications/harbormaster/future/HarbormasterExecFuture.php on line 50

Looks like some broken refactoring?

artms edited the summary of this revision. (Show Details)
artms edited the summary of this revision. (Show Details)
artms edited the summary of this revision. (Show Details)
artms edited the summary of this revision. (Show Details)
artms edited the summary of this revision. (Show Details)
artms requested review of this revision.Fri, Nov 6, 7:07 PM