Page MenuHomePhabricator

Fix error handler on PHP 8
ClosedPublic

Authored by jrtc27 on Sun, Jan 10, 9:54 PM.

Details

Summary

PHP 7.2.0 deprecated the 5th parameter and PHP 8 removed it, so stop
using it and provide a default value to avoid erroring with:

Too few arguments to function PhutilErrorHandler::handleError(), 4 passed and exactly 5 expected
Test Plan

Used to create this revision with PHP 8 on macOS

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Owners added a reviewer: Unknown Object (Owners Package).Sun, Jan 10, 9:54 PM
epriestley removed a reviewer: Unknown Object (Owners Package).Sun, Jan 10, 9:55 PM

It's possible that third party code which installs custom error listeners via setErrorListener() that expect 'context' to be populated may exist, I'm not aware of any such code and think it probably does not exist. It would also be easy to update any such code in response to this change, so I think it's not worth retaining backward compatibility with a dummy parameter and that this is the most-desirable version of this change.

This revision is now accepted and ready to land.Sun, Jan 10, 10:17 PM

Trivially rebased for landing

This revision was automatically updated to reflect the committed changes.