Fix error handler on PHP 8
ClosedPublic
Actions

Authored by jrtc27 on Jan 10 2021, 9:54 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T13588: PHP 8 Compatibility

Commits

rARC446dcf1ccdcd: Fix error handler on PHP 8

Required Signatures

L28 Phacility Individual Contributor License Agreement

Summary

PHP 7.2.0 deprecated the 5th parameter and PHP 8 removed it, so stop
using it and provide a default value to avoid erroring with:

Too few arguments to function PhutilErrorHandler::handleError(), 4 passed and exactly 5 expected

Test Plan

Used to create this revision with PHP 8 on macOS

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jrtc27 created this revision.Jan 10 2021, 9:54 PM

Owners added a reviewer: Unknown Object (Owners Package).Jan 10 2021, 9:54 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 10 2021, 9:54 PM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

jrtc27 requested review of this revision.Jan 10 2021, 9:54 PM

Harbormaster completed remote builds in B24977: Diff 51164.Jan 10 2021, 9:54 PM

Herald added a subscriber: Korvin. · View Herald TranscriptJan 10 2021, 9:54 PM

epriestley removed a reviewer: Unknown Object (Owners Package).Jan 10 2021, 9:55 PM

It's possible that third party code which installs custom error listeners via setErrorListener() that expect 'context' to be populated may exist, I'm not aware of any such code and think it probably does not exist. It would also be easy to update any such code in response to this change, so I think it's not worth retaining backward compatibility with a dummy parameter and that this is the most-desirable version of this change.

This revision is now accepted and ready to land.Jan 10 2021, 10:17 PM

epriestley added a task: T13588: PHP 8 Compatibility.Jan 10 2021, 10:23 PM

Trivially rebased for landing

Harbormaster completed remote builds in B24981: Diff 51168.Jan 11 2021, 2:01 AM

Closed by commit rARC446dcf1ccdcd: Fix error handler on PHP 8 (authored by jrtc27). · Explain WhyJan 11 2021, 2:02 AM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rARC446dcf1ccdcd: Fix error handler on PHP 8.