Page MenuHomePhabricator

Disable XML entity loader by default in libphutil
ClosedPublic

Authored by epriestley on Jan 23 2014, 9:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 20, 10:44 PM
Unknown Object (File)
Tue, Jul 16, 9:38 PM
Unknown Object (File)
Fri, Jul 12, 7:58 PM
Unknown Object (File)
Sat, Jul 6, 8:48 PM
Unknown Object (File)
Fri, Jul 5, 6:40 PM
Unknown Object (File)
Jun 22 2024, 11:04 PM
Unknown Object (File)
Jun 19 2024, 12:33 AM
Unknown Object (File)
Jun 18 2024, 1:44 AM
Subscribers

Details

Summary

See https://www.facebook.com/BugBounty/posts/778897822124446 and http://www.ubercomp.com/posts/2014-01-16_facebook_remote_code_execution.

By default, SimpleXMLElement will pretty much just run whatever code you want when handed a specially crafted document. We currently load XML only from trusted (S3, EC2, git/svn/hg) or local sources (unit test runners) so there are no concrete vulnerabilities in Phabricator, but this behavior is incredibly dangerous, surprising, and highly undesirable.

Test Plan

There's an example of a document which does bad things on http://www.php.net/manual/en/function.libxml-disable-entity-loader.php. I verified that SimpleXMLElement reads /etc/passwd when handed this document, then applied the fix. It no longer reads arbitrary files off disk.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped