HomePhabricator

(stable) When a new, deleted, draft inline is revived with "Undo", undelete it

Description

(stable) When a new, deleted, draft inline is revived with "Undo", undelete it

Summary:
See PHI1876. Normally, deleted inlines are undeleted with an "undelete" operation, which clears the "isDeleted" flag.

However, when an inline is deleted implicitly by using "Cancel" without first saving it, the flag currently isn't cleared properly. This can lead to cases where inlines seem to vanish (they are shown to the user in the UI, but treated as deleted on submission).

Test Plan:
There are two affected sequences here:

  • Create a new inline, type text, cancel, undo.
  • Create a new inline, type text, cancel, undo, save.

The former sequence triggers an "edit" operation. The subsequent "Save" in the second sequence triggers a "save" operation.

It's normally impossible in the UI to execute a "save" without executing an "edit" first, but "save" clearly should undelete the comment if you get there somehow, so this change clears the deleted flag in both cases for completeness.

  • Executed both sequences, saw comment persist in preview, on reload, and after submission.

Differential Revision: https://secure.phabricator.com/D21483

Details

Provenance
epriestleyAuthored on Oct 19 2020, 7:21 PM
epriestleyPushed on Oct 19 2020, 7:36 PM
Differential Revision
D21483: When a new, deleted, draft inline is revived with "Undo", undelete it
Parents
rP916bce119a2b: (stable) Promote 2020 Week 42
Branches
Unknown
Tags
Unknown
References
stable
Build Status
Buildable 24951
Build 34424: Run Core Tests