Page MenuHomePhabricator
Feed All Stories

May 10 2019

epriestley added parent tasks for T13287: Build general healthcheck infrastructure for monitoring services: T13286: When nodes in a cluster repository fail, reads are still routed with the same weight and failed reads do not recover, T13285: Service failures in JIRA can cascade into service failures in Phabricator.
May 10 2019, 5:45 PM · Clusters, Almanac
epriestley created T13287: Build general healthcheck infrastructure for monitoring services.
May 10 2019, 5:45 PM · Clusters, Almanac
epriestley triaged T13286: When nodes in a cluster repository fail, reads are still routed with the same weight and failed reads do not recover as Normal priority.
May 10 2019, 5:24 PM · Clusters, Diffusion
epriestley added a parent task for T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): T13285: Service failures in JIRA can cascade into service failures in Phabricator.
May 10 2019, 2:15 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley added a subtask for T13285: Service failures in JIRA can cascade into service failures in Phabricator: T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).
May 10 2019, 2:15 PM · Doorkeeper
epriestley triaged T13285: Service failures in JIRA can cascade into service failures in Phabricator as Normal priority.
May 10 2019, 2:15 PM · Doorkeeper
joshuaspence edited the content of Community Resources.
May 10 2019, 12:52 AM

May 9 2019

epriestley added a revision to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): Unknown Object (Differential Revision).
May 9 2019, 8:34 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
igoldberg added a comment to T5474: Support workboard column triggers which activate when a task is dropped into a column.

Got it, thanks for clarifying.

May 9 2019, 8:05 PM · Workboards (v3), Restricted Project
epriestley added a revision to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): Unknown Object (Differential Revision).
May 9 2019, 7:59 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley added a comment to T5474: Support workboard column triggers which activate when a task is dropped into a column.

It looks like these triggers don't run when you move tasks via "Move on Workboard" (instead of drag and drop). Is this expected / intentional?

May 9 2019, 6:54 PM · Workboards (v3), Restricted Project
igoldberg added a comment to T5474: Support workboard column triggers which activate when a task is dropped into a column.

It looks like these triggers don't run when you move tasks via "Move on Workboard" (instead of drag and drop).

May 9 2019, 6:51 PM · Workboards (v3), Restricted Project
epriestley added a subtask for T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): T9720: Provide a way to link to Diffusion files.
May 9 2019, 6:31 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley added a parent task for T9720: Provide a way to link to Diffusion files: T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).
May 9 2019, 6:31 PM · Restricted Project, Remarkup
epriestley added a comment to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).

PHI1224 describes a somewhat-adjacent situation: an install would like a way for external automated tooling to reference source files and generate editor links for them.

May 9 2019, 6:31 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley claimed T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).
May 9 2019, 6:23 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley removed a parent task for T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): T7443: Include full link to Maniphest tasks in commit messages.
May 9 2019, 6:23 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley removed a subtask for T7443: Include full link to Maniphest tasks in commit messages: T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).
May 9 2019, 6:23 PM · Diffusion, Arcanist
epriestley added a revision to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): Unknown Object (Differential Revision).
May 9 2019, 6:23 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley added a revision to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): Unknown Object (Differential Revision).
May 9 2019, 6:21 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley added a comment to T13125: Plans: Code coverage reporting.

PHI1231 would like API access to coverage.

May 9 2019, 5:51 PM · Diffusion, Plans
epriestley moved T11372: Multiple coverage columns for different types of code coverage from Backlog to Coverage on the Diffusion board.
May 9 2019, 5:05 PM · Diffusion, Restricted Project
epriestley edited projects for T11372: Multiple coverage columns for different types of code coverage, added: Diffusion; removed Feature Request.
May 9 2019, 5:05 PM · Diffusion, Restricted Project
epriestley closed T6737: Task doesn't get "mentioned in revision N" log record if revision comment contains "fix" or "fixed" and auto-close is off for the repository as Resolved.

My expectation is that this is effectively resolved by T13277. Since "Autoclose" is no longer a separate permission from "Publish", commits should now always mention + close or never mention + close.

May 9 2019, 5:05 PM · Transactions, Diffusion
epriestley moved T13284: When a previously non-permanent ref is marked permanent, unpublished commits reachable from that ref are not published from Backlog to "Track Only" on the Diffusion board.
May 9 2019, 5:03 PM · Diffusion
epriestley moved T9524: Show aggregate subdirectory coverage in Diffusion browse views from Backlog to Coverage on the Diffusion board.
May 9 2019, 5:00 PM · Diffusion, Restricted Project
epriestley moved T13125: Plans: Code coverage reporting from Backlog to Coverage on the Diffusion board.
May 9 2019, 5:00 PM · Diffusion, Plans

May 8 2019

epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
May 8 2019, 7:54 PM · Plans, Facts
epriestley added a comment to T13279: Build Charting for Facts.

The actual facts Maniphest currently generates need to be adjusted to properly support stacked-area-by-reason: currently, when a task is closed, we don't have enough data to figure out whether it should be removed from the "created into this project" area, the "reopened work" area, or the "moved work" area.

May 8 2019, 7:14 PM · Plans, Facts
epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
May 8 2019, 4:35 PM · Plans, Facts
epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
May 8 2019, 3:55 PM · Plans, Facts
epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
May 8 2019, 3:44 PM · Plans, Facts
epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
May 8 2019, 2:22 PM · Plans, Facts
epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
May 8 2019, 1:55 PM · Plans, Facts
wppd edited the content of Organizations Using Phabricator.
May 8 2019, 10:13 AM

May 7 2019

epriestley added a comment to T13279: Build Charting for Facts.

One issue with model we're evolving toward is that if you view a chart in Klingon, then send the link to a user whose primary language is Kerbal, we'd prefer to relabel the chart in Kerbal, not restore serialized Klingon-language chart labels. That means label generation has to be at render time, not at chart construction time, and I'm serializing a data-structure which is slightly too low-level for common application cases.

May 7 2019, 2:07 PM · Plans, Facts

May 5 2019

epriestley added a comment to T13279: Build Charting for Facts.

This is a little ways out, but the actual facts Maniphest currently generates need to be adjusted to properly support stacked-area-by-reason: currently, when a task is closed, we don't have enough data to figure out whether it should be removed from the "created into this project" area, the "reopened work" area, or the "moved work" area. This is okay if we're summing the opens/closes but not precise enough if we're breaking them down.

May 5 2019, 2:48 PM · Plans, Facts

May 4 2019

epriestley added a comment to T13284: When a previously non-permanent ref is marked permanent, unpublished commits reachable from that ref are not published.

Probably, push another commit to Y

May 4 2019, 5:28 PM · Diffusion

May 3 2019

epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
May 3 2019, 10:44 PM · Plans, Facts
epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
May 3 2019, 10:15 PM · Plans, Facts
epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
May 3 2019, 7:16 PM · Plans, Facts
epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
May 3 2019, 6:54 PM · Plans, Facts
epriestley updated the task description for T13284: When a previously non-permanent ref is marked permanent, unpublished commits reachable from that ref are not published.
May 3 2019, 5:37 PM · Diffusion
epriestley triaged T13284: When a previously non-permanent ref is marked permanent, unpublished commits reachable from that ref are not published as Low priority.
May 3 2019, 5:35 PM · Diffusion
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": Unknown Object (Differential Revision).
May 3 2019, 5:11 PM · Plans, Diffusion
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: Unknown Object (Differential Revision).
May 3 2019, 3:00 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a comment to T13279: Build Charting for Facts.

Multiple Project Burnups Stacked in an Area Chart

May 3 2019, 2:56 PM · Plans, Facts
epriestley added a comment to T13279: Build Charting for Facts.

See also PHI1226. An install has an environment where automatic rules (Herald/Owners) frequently trigger group reviewers (projects/packages), and some groups are not prompt about performing review.

May 3 2019, 2:35 PM · Plans, Facts
epriestley moved T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time from Backlog to Next on the Herald board.
May 3 2019, 5:11 AM · Diffusion, Harbormaster, Herald, Audit
epriestley triaged T13283: When Herald acts, include the transaction group as part of the "state" it acts upon as Normal priority.
May 3 2019, 5:11 AM · Herald
epriestley added a comment to T6491: Herald rules based on age.

See PHI1107, which requests Auto-Abandon for old changes and also has a technical outline for this great and wholesome feature.

May 3 2019, 5:04 AM · Restricted Project, Herald
joshuaspence edited the content of Community Resources.
May 3 2019, 4:59 AM
joshuaspence edited the content of Community Resources.
May 3 2019, 4:58 AM
epriestley closed T5462: How do I publish Phabricator events into remote systems? as Resolved.

The answer here is now pretty unambiguously "Use Webhooks". feed.http-hooks is formally deprecated, Herald remains a terrible idea, and anyone brave enough to touch Doorkeeper can probably figure things out for themselves.

May 3 2019, 4:57 AM · Guides, Doorkeeper, Feed, Herald
epriestley closed T5547: Allow members of a project to add rules with project reviewers as Wontfix.

We don't have any current customer interest in this as far as I'm aware. We could revisit this in the future, but I'd like better / more modern use cases (e.g., that aren't addressed by an approach with Owners).

May 3 2019, 4:56 AM · Restricted Project, Herald
epriestley moved T6491: Herald rules based on age from Backlog to Next on the Herald board.
May 3 2019, 4:53 AM · Restricted Project, Herald
epriestley closed T7703: Policy checks may execute incompletely for non-viewers, a subtask of T6183: Allow any user to watch projects, as Resolved.
May 3 2019, 4:53 AM · Wikimedia, Projects
epriestley closed T7703: Policy checks may execute incompletely for non-viewers as Resolved.

Although I'm not entirely confident that 100% of objects which should implement ExtendedPolicyInterface actually do today, I think we've gotten pretty much all of them. This approach also seems stable.

May 3 2019, 4:53 AM · Policy, Herald, Flags
epriestley closed T7703: Policy checks may execute incompletely for non-viewers, a subtask of T8377: Build the core "Spaces" Application, as Resolved.
May 3 2019, 4:53 AM · Spaces, Wikimedia, Policy
epriestley moved T9136: '(Disabled)' rules show up multi times under 'Another Herald Rule' from Backlog to Next on the Herald board.
May 3 2019, 4:44 AM · Restricted Project, Herald
epriestley closed T9766: Expose conduit API to activate/disable Herald rules as Wontfix.

I don't believe there are remaining outstanding requests for this.

May 3 2019, 4:44 AM · Restricted Project, Restricted Project, Conduit, Herald
epriestley moved T13166: Herald "block" and "send an email" actions are mutually exclusive, which isn't intuitive from Backlog to Far Future on the Herald board.
May 3 2019, 4:40 AM · Diffusion, Herald
epriestley closed T11118: Herald Rule to assign Owners to an Audit as Wontfix.

Owners review and auditing now have 6 and 4 options respectively, which I think cover most of the needs here. They don't handle everything (e.g. excluding merge commits) but think we're mostly in a reasonable place now and don't have any current plans to add additional shorthands.

May 3 2019, 4:39 AM · Restricted Project, Audit, Herald, Owners, Feature Request
epriestley renamed T406: Support "Oncall" Users from Build Oncall / Alerting / Monitoring tool, similar to PagerDuty to Support "Oncall" Users.
May 3 2019, 4:22 AM · Nuance, Oncall Tool, Facebook

May 1 2019

epriestley closed T7216: Make it easier to update the ApplicationSearch saved query used by a dashboard panel as Resolved by committing Restricted Diffusion Commit.
May 1 2019, 6:01 PM · Dashboards
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: Unknown Object (Differential Revision).
May 1 2019, 3:47 PM · Diffusion, Harbormaster, Herald, Audit
epriestley updated the task description for T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time.
May 1 2019, 3:45 PM · Diffusion, Harbormaster, Herald, Audit

Apr 30 2019

epriestley added a comment to T13279: Build Charting for Facts.

I think a possible model for the UI is to have some base ChartConfigurationEngine, similar to SearchEngine, which defines a set of fields. Some fields would be common (e.g., all time-series charts can have time controls for domains).

Apr 30 2019, 10:31 PM · Plans, Facts
epriestley added a comment to T13279: Build Charting for Facts.

The concrete use cases that are currently filed are:

Apr 30 2019, 10:23 PM · Plans, Facts
epriestley removed a parent task for T4171: Building reporting and data systems: T6821: Allow querying for open Maniphest tasks with an assignee set for ages ("cookie licking").
Apr 30 2019, 8:57 PM · Restricted Project, FreeBSD, Wikimedia, Facts
epriestley removed a subtask for T6821: Allow querying for open Maniphest tasks with an assignee set for ages ("cookie licking"): T4171: Building reporting and data systems.
Apr 30 2019, 8:57 PM · Maniphest
epriestley closed T4171: Building reporting and data systems as Resolved.

This is approximately coming into existence and this task no longer serves much of a purpose. See T13083 / T13279 for followups.

Apr 30 2019, 8:57 PM · Restricted Project, FreeBSD, Wikimedia, Facts
epriestley closed T4171: Building reporting and data systems, a subtask of T4434: Track object closed/completed date and actor, as Resolved.
Apr 30 2019, 8:57 PM · Restricted Project, Maniphest, Projects
epriestley closed T4171: Building reporting and data systems, a subtask of T6821: Allow querying for open Maniphest tasks with an assignee set for ages ("cookie licking"), as Resolved.
Apr 30 2019, 8:57 PM · Maniphest
epriestley closed T1562: Build "Facts", an ETL pipeline and charting application as Resolved.

This now approximately exists and is no longer of much use as a standalone task. See T13279 and elsewhere for followups.

Apr 30 2019, 8:52 PM · Restricted Project, Wikimedia, Facts
epriestley closed T1562: Build "Facts", an ETL pipeline and charting application, a subtask of T4171: Building reporting and data systems, as Resolved.
Apr 30 2019, 8:52 PM · Restricted Project, FreeBSD, Wikimedia, Facts
epriestley closed T1562: Build "Facts", an ETL pipeline and charting application, a subtask of T1135: Build ETL-based statistics for Differential, as Resolved.
Apr 30 2019, 8:52 PM · Differential
epriestley closed T1562: Build "Facts", an ETL pipeline and charting application, a subtask of T6041: Metrics for Maniphest, as Resolved.
Apr 30 2019, 8:52 PM · Wikimedia, Facts, Maniphest
epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
Apr 30 2019, 4:52 PM · Plans, Facts
epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
Apr 30 2019, 3:56 PM · Plans, Facts
epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
Apr 30 2019, 3:42 PM · Plans, Facts
epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
Apr 30 2019, 3:36 PM · Plans, Facts
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: Unknown Object (Differential Revision).
Apr 30 2019, 3:34 PM · Dashboards
epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
Apr 30 2019, 3:31 PM · Plans, Facts
epriestley added a comment to T13279: Build Charting for Facts.

hmmm

Apr 30 2019, 3:18 PM · Plans, Facts

Apr 29 2019

cspeckmim added a comment to T13161: Plans: Improve Differential diff display behaviors.

Wow thank you for this. I came across a diff that mixed a lot of whitespace with minimal code change it's much easier to differentiate what happened.

otterlygreat.gif (177×315 px, 1 MB)

Apr 29 2019, 8:47 PM · Differential, Plans

Apr 28 2019

epriestley added a comment to T4453: When multiple commits correspond to a single revision, Differential updates to show one of them arbitrarily.

The complexity of handling this makes adding a "the whole repository is caught up, deal with it" from T4453#13 sort of step more attractive. This would be far easier to motivate if we had more stuff that suffered from similar issues, though.

Apr 28 2019, 3:05 PM · Restricted Project, Prioritized, Differential

Apr 27 2019

epriestley edited the content of Changelog.
Apr 27 2019, 6:31 PM
epriestley created 2019 Week 17 (Very Late April).
Apr 27 2019, 6:28 PM
epriestley moved T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does) from Backlog to Next on the Remarkup board.
Apr 27 2019, 5:12 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley moved T9720: Provide a way to link to Diffusion files from Backlog to Next on the Remarkup board.
Apr 27 2019, 5:12 PM · Restricted Project, Remarkup
epriestley closed T10571: Default quote action breaks text between lists as Resolved.

I believe this was resolved by D20327 / D20393.

Apr 27 2019, 5:11 PM · Remarkup, Wikimedia
epriestley moved T13063: Maybe render all text with IMPRESSIVE illuminated drop caps from Backlog to Tomfoolery on the Remarkup board.
Apr 27 2019, 5:10 PM · Remarkup
epriestley closed T11229: Quotes breaks headings by default as Resolved.

I believe this has been fixed by D20327 / D20393 -- at least, the examples above no longer seem to reproduce any bad behavior.

Apr 27 2019, 5:07 PM · Remarkup, Bug Report

Apr 25 2019

epriestley updated the task description for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
Apr 25 2019, 10:11 PM · Arcanist, Differential
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: Unknown Object (Differential Revision).
Apr 25 2019, 7:04 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: Unknown Object (Differential Revision).
Apr 25 2019, 6:39 PM · Dashboards
epriestley added a revision to T7216: Make it easier to update the ApplicationSearch saved query used by a dashboard panel: Unknown Object (Differential Revision).
Apr 25 2019, 6:05 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: Restricted Differential Revision.
Apr 25 2019, 6:05 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: Unknown Object (Differential Revision).
Apr 25 2019, 5:38 PM · Dashboards