The phids constraints matches transactions with specific PHIDs (PHID-XACT-...). Usually, you'll have a list of transaction PHIDs when you're responding to a webhook callback, so the phids constraint is most useful for webhooks.

This change broke the search dialog on tags typeaheads...

Probably a good idea, but not worth keeping a task around for.

This is probably a natural feature if we iterate here, but not worth keeping a task around for.

We have no customer interest in this and no current plans to pursue it.

I'm looking at these storage/backend changes:

Presuming resolved by D19748 since we don't have an actual reproduction case.

D20196 removes this code.

I think it had some white-space removed from its end.

After D20194, expansion of tabs now uses the correct rule (expand tabs to the next tabstop) instead of the old rule (hard-coded replacement with a fixed number of spaces).

There are probably still a few remaining kinks to work out here, but I believe this is substantially resolved:

• The "<<" and ">>" indicators are rendering in places where indentation has changed but the entire line is also different. This is not intended.
• The ScopeEngine can raise an exception on diffs with partial context. We should probably just skip this feature if we're missing context.
• The indent depth indicators are probably generally too bright / high-vis.
• There's no color blind scheme for the indicators.
• The indentation indicators in one-up mode aren't great (?)

I'd propose for simplicity that the focus switch from largefiles to lfs support for Mercurial repositories. lfs has been added to Phabricator for Git already T7789 and it seems that there'd be less work involved to piggyback on that.

I'm probably not going to fix this since it's pretty minor and moderately complicated to fix, but this interaction is not ideal:

In Firefox, selecting a range which crosses an inline comment currently drops the line after the comment. Here, return arra does not copy:

Note that T6791 has an example of a change where removing the whitespace options is going to cause a behavioral regression. Here's an example:

This report is generally unclear / hard to reproduce / unusual so I'm not sure how to move forward. It's likely mooted by D20181.

See PHI701. This behavior is not ideal:

I'm going to start here, and implement this proposed rule, which I think is the simpler and more intuitive of the proposals:

It sounds like real-time updates will more-or-less moot this.

(See T13251 for followup.)

I believe all (?) of these are now fixed in both master and stable.

A related issue here is exemplified in https://discourse.phabricator-community.org/t/importing-libphutil-repository-on-fresh-phabricator-triggers-an-error/2391/, which basically amounts to:

Both tables have this key:

I believe we haven't seen more of this in two years, and "make the worker always exit in less than 2 hours" is a more-or-less reasonable remedy. Getting one extra email every two hours also isn't a huge problem even if we do get this wrong.