Page MenuHomePhabricator
Feed All Stories

Mar 1 2019

epriestley added a revision to T13121: Remove "-q" from SSH commands executed by `bin/remote` and similar cluster commands: Restricted Differential Revision.
Mar 1 2019, 5:52 PM · Phacility, Ops
epriestley added a comment to T13121: Remove "-q" from SSH commands executed by `bin/remote` and similar cluster commands.

Another possible approach is to use -o LogLevel=ERROR. This gets us into trouble if there are useful INFO messages other than "permanently added X to list of known hosts", but presumably all the important stuff is rasied at ERROR or better.

Mar 1 2019, 5:43 PM · Phacility, Ops
epriestley added a comment to T13121: Remove "-q" from SSH commands executed by `bin/remote` and similar cluster commands.

For Drydock/Harbormaster, the only real way forward I see here is:

Mar 1 2019, 5:38 PM · Phacility, Ops
epriestley added a comment to T13261: Update upstream build steps to include timeouts and limits.

Currently, properties on upstream build steps are driven by CustomFields. T13248 briefly discusses a bit of context.

Mar 1 2019, 5:23 PM · Harbormaster
epriestley updated the task description for T13257: Plans: Unbeta New Harbormaster Log UI.
Mar 1 2019, 5:20 PM · Plans, Harbormaster
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Mar 1 2019, 5:20 PM · Plans, Harbormaster
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Mar 1 2019, 5:19 PM · Plans, Harbormaster
epriestley triaged T13261: Update upstream build steps to include timeouts and limits as Normal priority.
Mar 1 2019, 5:19 PM · Harbormaster
epriestley added a comment to T13248: Support enabling and disabling (and making other adjustments to) custom fields based on object subtypes.

(This is likely to be very long, very rambling, and not particularly enlightening or useful.)

Mar 1 2019, 4:55 PM · Custom Fields, Maniphest
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): Unknown Object (Differential Revision).
Mar 1 2019, 3:54 PM · Plans, Harbormaster
epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": Unknown Object (Differential Revision).
Mar 1 2019, 3:16 PM · Diffusion
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): Unknown Object (Differential Revision).
Mar 1 2019, 2:13 PM · Plans, Harbormaster
epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

somewhat tricky to explain, and somewhat tricky to resolve

Mar 1 2019, 4:19 AM · Diffusion
epriestley closed T13260: Google auth fails and throws exception about missing client state parameter as Resolved by committing Restricted Diffusion Commit.
Mar 1 2019, 3:50 AM · Auth
epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": Unknown Object (Differential Revision).
Mar 1 2019, 3:47 AM · Diffusion
epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": Unknown Object (Differential Revision).
Mar 1 2019, 3:28 AM · Diffusion
epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

From onsite:

Mar 1 2019, 2:53 AM · Diffusion
ysood added a comment to T5391: Support custom fields in 'Export to Excel'.

Resolved by D18959 + D18960. See also T13049.

Not all custom field types have export support today, but the infrastructure is in place and additional support is generally straightforward.

Mar 1 2019, 1:22 AM · Data Exporters

Feb 28 2019

reed added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

and now when I re-run the command again, it gets another 7 commits and fails again. So, perhaps by me viewing the commit, I kick off a job that rebuilds something on the backend?

Feb 28 2019, 10:16 PM · Diffusion
reed added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

It's now failing on this one (consistently if I keep running it):

Feb 28 2019, 10:10 PM · Diffusion
epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

Thanks. That looks like a perfectly normal object to me so I'm not sure what could cause it to fail to load.

Feb 28 2019, 9:31 PM · Diffusion
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

You will soon be able to give builds different "Hold Drafts" behaviors. See T13258.

Feb 28 2019, 9:29 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
reed added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".
mysql> SELECT * FROM phabricator_repository.repository_commit WHERE id = 71471;
+-------+--------------+--------------------------------+------------------------------------------+------------+------------+-------------+---------+--------------+--------------------+-----------------------+
| id    | repositoryID | phid                           | commitIdentifier                         | epoch      | authorPHID | auditStatus | summary | importStatus | authorIdentityPHID | committerIdentityPHID |
+-------+--------------+--------------------------------+------------------------------------------+------------+------------+-------------+---------+--------------+--------------------+-----------------------+
| 71471 |           41 | PHID-CMIT-ohupojjoniypwpghvlr2 | 43034ccb9eac4ca8a655f655b726f73c5e551413 | 1438182566 | NULL       | none        |         |         1024 | NULL               | NULL                  |
+-------+--------------+--------------------------------+------------------------------------------+------------+------------+-------------+---------+--------------+--------------------+-----------------------+
1 row in set (0.01 sec)
Feb 28 2019, 9:28 PM · Diffusion
20after4 added a comment to T13248: Support enabling and disabling (and making other adjustments to) custom fields based on object subtypes.

Making a way to set fields to default: disabled would make this feature even better ;)

Feb 28 2019, 9:27 PM · Custom Fields, Maniphest
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): Unknown Object (Differential Revision).
Feb 28 2019, 9:24 PM · Plans, Harbormaster
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): Unknown Object (Differential Revision).
Feb 28 2019, 9:12 PM · Plans, Harbormaster
epriestley updated the task description for T784: Allow Differential changesets to be marked with various attributes.
Feb 28 2019, 8:54 PM · Restricted Project, Restricted Project, Restricted Project, Differential, Arcanist
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): Unknown Object (Differential Revision).
Feb 28 2019, 8:05 PM · Plans, Harbormaster
epriestley added a comment to T11415: Would like people who can't edit Harbormaster plans to be able to run them.

After D20229, the rules are:

Feb 28 2019, 7:44 PM · Restricted Project, Harbormaster, Feature Request
epriestley added a revision to T11415: Would like people who can't edit Harbormaster plans to be able to run them: Unknown Object (Differential Revision).
Feb 28 2019, 7:41 PM · Restricted Project, Harbormaster, Feature Request
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): Unknown Object (Differential Revision).
Feb 28 2019, 7:41 PM · Plans, Harbormaster
epriestley added a comment to T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds.

I'll call this out in the changelog, but behavior here is changing slightly (see T13258 and T11415):

Feb 28 2019, 7:30 PM · Harbormaster (v3), Restricted Project
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): Unknown Object (Differential Revision).
Feb 28 2019, 7:01 PM · Plans, Harbormaster
epriestley added a comment to T13260: Google auth fails and throws exception about missing client state parameter.

I'll update the documentation/setup guidance in the upstream.

Feb 28 2019, 6:44 PM · Auth
epriestley added a revision to T13260: Google auth fails and throws exception about missing client state parameter: Unknown Object (Differential Revision).
Feb 28 2019, 6:42 PM · Auth
epriestley claimed T13260: Google auth fails and throws exception about missing client state parameter.
Feb 28 2019, 6:36 PM · Auth
epriestley added a comment to T13260: Google auth fails and throws exception about missing client state parameter.

Great! Thanks for the report, and for your help tracking this down by going through the diagnostic steps.

Feb 28 2019, 6:29 PM · Auth
reed added a comment to T13260: Google auth fails and throws exception about missing client state parameter.

https://phabricator.example.com/debug/?a=b returns:

Feb 28 2019, 6:20 PM · Auth
epriestley updated the task description for T12164: Put an indirection layer between author/committer strings and user accounts.
Feb 28 2019, 5:29 PM · Customer Impact, Diffusion (v3)
epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

Here's what's happening in general:

Feb 28 2019, 1:55 PM · Diffusion
epriestley added a comment to T13260: Google auth fails and throws exception about missing client state parameter.

I can't immediately reproduce this: I can log into my local development install and into secure.phabricator.com using Google OAuth without any issues right now.

Feb 28 2019, 1:41 PM · Auth
spawnlt awarded T13074: Plans: Workboard triggers, groups, and subproject columns a Party Time token.
Feb 28 2019, 1:12 PM · Workboards (v3), Plans, Projects
spawnlt awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Party Time token.
Feb 28 2019, 1:03 PM · Workboards (v3), Restricted Project
spawnlt awarded T12586: Support for multiple "Move on Workboard" actions in single Maniphest update a Party Time token.
Feb 28 2019, 12:51 PM · Maniphest, Workboards, Feature Request
spawnlt added a comment to T6409: Link Task Status to Work board Column.

Would be happy to see this feature. My company use different team names as columns of the work board. When a task is reassigned from a dev to a tester, I need to manually move it from Dev column to QA column.
With this feature implemented, I would be able to configure a rule that when a task is assigned to a specific person, the task will be automatically moved to a column, say the Dev column for example.

Feb 28 2019, 12:49 PM · Workboards
reed updated the task description for T13260: Google auth fails and throws exception about missing client state parameter.
Feb 28 2019, 9:05 AM · Auth
reed added a comment to T13260: Google auth fails and throws exception about missing client state parameter.

I thought rPHU4d21f105b17f250aaaeb8937142ae4cbc978389f was meant to fix this, but apparently not.

Feb 28 2019, 9:03 AM · Auth
reed updated the task description for T13260: Google auth fails and throws exception about missing client state parameter.
Feb 28 2019, 9:02 AM · Auth
reed created T13260: Google auth fails and throws exception about missing client state parameter.
Feb 28 2019, 8:56 AM · Auth
reed updated the task description for T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".
Feb 28 2019, 8:36 AM · Diffusion
reed updated the task description for T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".
Feb 28 2019, 8:36 AM · Diffusion
reed created T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".
Feb 28 2019, 8:32 AM · Diffusion
n3v3rf411 awarded T13248: Support enabling and disabling (and making other adjustments to) custom fields based on object subtypes a Cup of Joe token.
Feb 28 2019, 4:38 AM · Custom Fields, Maniphest

Feb 26 2019

epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): Unknown Object (Differential Revision).
Feb 26 2019, 5:45 PM · Plans, Harbormaster
epriestley added a revision to T11415: Would like people who can't edit Harbormaster plans to be able to run them: Unknown Object (Differential Revision).
Feb 26 2019, 5:45 PM · Restricted Project, Harbormaster, Feature Request
20after4 awarded T13248: Support enabling and disabling (and making other adjustments to) custom fields based on object subtypes a Mountain of Wealth token.
Feb 26 2019, 3:58 PM · Custom Fields, Maniphest
20after4 added a comment to T13255: transaction.search should accept user PHIDs as constraints.

quack

Feb 26 2019, 3:57 PM · Conduit, Transactions
20after4 awarded T13255: transaction.search should accept user PHIDs as constraints a Pterodactyl token.
Feb 26 2019, 3:55 PM · Conduit, Transactions
epriestley added a parent task for T11415: Would like people who can't edit Harbormaster plans to be able to run them: T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc).
Feb 26 2019, 3:27 PM · Restricted Project, Harbormaster, Feature Request
epriestley added a subtask for T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): T11415: Would like people who can't edit Harbormaster plans to be able to run them.
Feb 26 2019, 3:27 PM · Plans, Harbormaster
epriestley updated the task description for T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc).
Feb 26 2019, 3:26 PM · Plans, Harbormaster
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): Unknown Object (Differential Revision).
Feb 26 2019, 1:49 PM · Plans, Harbormaster
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): Unknown Object (Differential Revision).
Feb 26 2019, 1:24 PM · Plans, Harbormaster
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): Unknown Object (Differential Revision).
Feb 26 2019, 1:17 PM · Plans, Harbormaster
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Feb 26 2019, 12:48 PM · Plans, Harbormaster
epriestley updated the task description for T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc).
Feb 26 2019, 12:48 PM · Plans, Harbormaster
epriestley triaged T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc) as Normal priority.
Feb 26 2019, 12:41 PM · Plans, Harbormaster
epriestley triaged T13257: Plans: Unbeta New Harbormaster Log UI as Normal priority.
Feb 26 2019, 12:36 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: Unknown Object (Differential Revision).
Feb 26 2019, 12:35 PM · Plans, Harbormaster
n3v3rf411 added a comment to T10350: Scripts to migrate old "points" fields and move projects beneath other projects.

Calling PhabricatorProjectsMembershipIndexEngineExtension's rematerialize in move_to_root.php should automatically set hasSubprojects and hasMilestones

Feb 26 2019, 7:16 AM · Projects (v3)
epriestley created U45 Adding New Classes.
Feb 26 2019, 2:55 AM

Feb 25 2019

epriestley closed T7773: Allow code reviews across multiple repos, a subtask of T9287: Working with many repositories, as Wontfix.
Feb 25 2019, 9:45 PM · Restricted Project, Restricted Project, Diffusion
epriestley closed T7773: Allow code reviews across multiple repos as Wontfix.

I'm going to close this as non-actionable since it doesn't clearly describe a use case, there's no current customer interest, and it's not clear what problems we'd like to solve that aren't already solved by a stronger "Depends On". The "Depends On" relationship has also become stronger and better integrated since this was originally filed, and it's possible it addresses some or all of the original use cases.

Feb 25 2019, 9:45 PM · Restricted Project, Differential
epriestley updated the task description for T784: Allow Differential changesets to be marked with various attributes.
Feb 25 2019, 9:29 PM · Restricted Project, Restricted Project, Restricted Project, Differential, Arcanist
epriestley updated the task description for T784: Allow Differential changesets to be marked with various attributes.
Feb 25 2019, 9:28 PM · Restricted Project, Restricted Project, Restricted Project, Differential, Arcanist
leoluk added a comment to Q531: Can an administrator invalidate a user's session to force a logout and relogin? (Answer 485).

This has been implemented in the meantime:

Feb 25 2019, 9:01 PM
leoluk added a comment to Q531: Can an administrator invalidate a user's session to force a logout and relogin? (Answer 485).
Feb 25 2019, 9:00 PM
epriestley updated the task description for T784: Allow Differential changesets to be marked with various attributes.
Feb 25 2019, 8:58 PM · Restricted Project, Restricted Project, Restricted Project, Differential, Arcanist
epriestley updated the task description for T784: Allow Differential changesets to be marked with various attributes.
Feb 25 2019, 8:55 PM · Restricted Project, Restricted Project, Restricted Project, Differential, Arcanist
epriestley closed T10853: Make `setCWD('/does/not/exist')` safer on ExecFuture as Resolved by committing Restricted Diffusion Commit.
Feb 25 2019, 8:14 PM · Infrastructure
epriestley updated the task description for T13230: Native Applications.
Feb 25 2019, 8:03 PM · Phacility
klachance added a comment to T3498: Allow ignore whitespace in Audit/Diffusion diffs.

Thank you !

Feb 25 2019, 7:41 PM · Diffusion
epriestley closed T13255: transaction.search should accept user PHIDs as constraints as Resolved.
  • D20208 adds an authorPHIDs constraint.
  • D20209 provides details for transactions which add or remove projects. See above for format and rationale, or just query something and see what pops out.
  • D20211 makes the documentation less bare-bones.
Feb 25 2019, 7:08 PM · Conduit, Transactions
epriestley added a revision to T13255: transaction.search should accept user PHIDs as constraints: Unknown Object (Differential Revision).
Feb 25 2019, 3:26 PM · Conduit, Transactions
epriestley added a comment to T13068: Refinements for "Mute Notifications".

A very mild point in favor of this feature is that we haven't seen any negative feedback or confusion, although I think you might be the first user to say they actually like/use it.

Feb 25 2019, 2:31 PM · Notifications, Mail
epriestley added a comment to T11760: Phacility Cluster: Ad-Hoc Query Log.

I ran a query against a subset of instances to determine if "Mute Notifications" sees any usage whatsover (see T13068):

Feb 25 2019, 2:29 PM · Phacility
20after4 added a comment to T13068: Refinements for "Mute Notifications".

FWIW I appreciate and use the mute feature (though only occasionally)

Feb 25 2019, 2:16 PM · Notifications, Mail
epriestley added a revision to T13255: transaction.search should accept user PHIDs as constraints: Unknown Object (Differential Revision).
Feb 25 2019, 1:35 PM · Conduit, Transactions
epriestley added a comment to T13255: transaction.search should accept user PHIDs as constraints.

Currently, project tag changes and subscriber changes don't expose data in "transaction.search" because there's no "obviously correct" way to represent these changes in a future-proof way.

Feb 25 2019, 1:27 PM · Conduit, Transactions
epriestley added a comment to T13255: transaction.search should accept user PHIDs as constraints.

To my surprise, it also seems the method does not output any project tag changes that happened on a task?

Feb 25 2019, 1:24 PM · Conduit, Transactions
epriestley added a revision to T13255: transaction.search should accept user PHIDs as constraints: Unknown Object (Differential Revision).
Feb 25 2019, 1:02 PM · Conduit, Transactions
epriestley added a parent task for T4752: Daemons may not have permission to remove files from local disk storage engine: T13256: Update storage engines in Files to a modern multi-service configuration.
Feb 25 2019, 12:55 PM · Files
epriestley added a subtask for T13256: Update storage engines in Files to a modern multi-service configuration: T4752: Daemons may not have permission to remove files from local disk storage engine.
Feb 25 2019, 12:55 PM · Files

Feb 24 2019

aklapper added a comment to T13255: transaction.search should accept user PHIDs as constraints.

Thanks for the quick reply!
Haven't played with webhooks yet so I did not know/realize it's transaction PHIDs only - "PHID" sounded generic enough that I incorrectly expected any kinds of PHIDs to be accepted as input. So this task is somewhere between either "clarify documentation that only transaction PHIDs are supported" or a "support other PHIDs" low-prio enhancement request.

Feb 24 2019, 2:13 PM · Conduit, Transactions
arielyang updated arielyang.
Feb 24 2019, 12:07 PM
arielyang updated arielyang.
Feb 24 2019, 12:06 PM

Feb 23 2019

epriestley closed T9169: Downloading Attachment Extremely Slow as Wontfix.

We no longer offer support for this kind of problem (that technically has reproduction steps, but is sufficiently involved to reproduce that no one has time to follow them, e.g. build a new server from scratch with assorted specific software versions).

Feb 23 2019, 3:37 PM · Bug Report (Needs Information), Files
epriestley triaged T13256: Update storage engines in Files to a modern multi-service configuration as Low priority.
Feb 23 2019, 3:26 PM · Files
epriestley edited the content of Changelog.
Feb 23 2019, 2:19 PM
epriestley created 2019 Week 8 (Late February).
Feb 23 2019, 2:18 PM