- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Mar 16 2018
is there a chance that this problem will get fixed?
The change D17989 is already from May 2017 without any reviewer...
Mar 15 2018
Having looked at the code some more, I see when the HeraldPreCommitRefAdapter runs, there is no parsed commit object yet, so there's no way to invoke harbormaster (what would the container PHID be?). This kind of makes sense.
It would be nice if exemptions could be granted for all members of a given Phabricator group, rather than only on a user basis.
Use case: having a group of employees of a given organization, who don't need to sign a DCO-like document, because their employment contracts take care of it; while at the same time requiring DCO signing by external contributors.
Some of this got fixed, some ended up in T13081.
Mar 14 2018
With that stuff, we're down from 473 to 227 on T9950. That's still awful, but not quite as ridiculous.
See T13069 for mail stamp plans.
This was largely tackled above.
I'm having some difficulty merging (5) and (6), or either of them into (2). My local test also has a lot of nonsense going on that a real install shouldn't. I'm going to land what I've got so far and see how much progress we've made here.
Queries are down to 139 for me locally.
Queries are now down from 151 to 145 for me locally.
Next problem:
For my local test task (T369), the initial page query load was 199 queries. After D19222 we're down slightly to 151 queries.
Some of this is:
This was resolved by the introduction of PhabricatorExtendedPolicyInterface. Older cases with missing policy proxies occasionally crop up, but I believe most of them are resolved at HEAD of master. These errors always fail closed (deny access which should be acceptable), never fail open (allow impermissible access) so there's no urgency to hunting them down.
See followup in T13105.
See followup in T13105.