Page MenuHomePhabricator
Feed All Stories

Mar 16 2018

epriestley closed D19232: Reduce the severity of policy fatals when building the Harbormaster "build status" element.
Mar 16 2018, 8:28 PM
epriestley requested review of D19232: Reduce the severity of policy fatals when building the Harbormaster "build status" element.
Mar 16 2018, 8:27 PM
epriestley added a revision to T13102: Plans: 2018 Week 11 Bonus Content: D19232: Reduce the severity of policy fatals when building the Harbormaster "build status" element.
Mar 16 2018, 8:26 PM · Plans
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Mar 16 2018, 8:20 PM · Plans, Harbormaster
epriestley committed rP667955b8aeca: Clarify that a PHUITagView API argument is boolean, not a value in "millimeters" (authored by epriestley).
Clarify that a PHUITagView API argument is boolean, not a value in "millimeters"
Mar 16 2018, 8:11 PM
epriestley closed D19231: Clarify that a PHUITagView API argument is boolean, not a value in "millimeters".
Mar 16 2018, 8:11 PM
epriestley requested review of D19231: Clarify that a PHUITagView API argument is boolean, not a value in "millimeters".
Mar 16 2018, 8:09 PM
epriestley committed rPc216fd40728b: Allow projects to be queried by slug in "project.search" (authored by epriestley).
Allow projects to be queried by slug in "project.search"
Mar 16 2018, 8:08 PM
epriestley closed D19230: Allow projects to be queried by slug in "project.search".
Mar 16 2018, 8:08 PM
epriestley added a revision to T13102: Plans: 2018 Week 11 Bonus Content: D19231: Clarify that a PHUITagView API argument is boolean, not a value in "millimeters".
Mar 16 2018, 8:08 PM · Plans
epriestley requested review of D19230: Allow projects to be queried by slug in "project.search".
Mar 16 2018, 7:58 PM
epriestley updated the task description for T13102: Plans: 2018 Week 11 Bonus Content.
Mar 16 2018, 7:57 PM · Plans
epriestley added a revision to T13102: Plans: 2018 Week 11 Bonus Content: D19230: Allow projects to be queried by slug in "project.search".
Mar 16 2018, 7:56 PM · Plans
epriestley updated the task description for T13102: Plans: 2018 Week 11 Bonus Content.
Mar 16 2018, 7:28 PM · Plans
1stone added a comment to T12727: Mail handler unable to parse e-mail from MS Outlook 12, Failed to JSON encode value.

is there a chance that this problem will get fixed?
The change D17989 is already from May 2017 without any reviewer...

Mar 16 2018, 2:49 PM · Bug Report
ftdysa awarded T13107: Git, Slowly and Painfully a Party Time token.
Mar 16 2018, 1:07 PM · Guides
asherkin awarded T13107: Git, Slowly and Painfully a 100 token.
Mar 16 2018, 1:01 PM · Guides
avivey awarded T13107: Git, Slowly and Painfully a Mountain of Wealth token.
Mar 16 2018, 11:19 AM · Guides
garoevans removed a watcher for Harbormaster: garoevans.
Mar 16 2018, 9:54 AM
jmeador awarded T13107: Git, Slowly and Painfully a The World Burns token.
Mar 16 2018, 7:34 AM · Guides
epriestley triaged T13107: Git, Slowly and Painfully as Wishlist priority.
Mar 16 2018, 3:25 AM · Guides

Mar 15 2018

jbrownEP added a comment to T9821: Allow Harbormaster build plans to run on branch push instead of per-commit.

Having looked at the code some more, I see when the HeraldPreCommitRefAdapter runs, there is no parsed commit object yet, so there's no way to invoke harbormaster (what would the container PHID be?). This kind of makes sense.

Mar 15 2018, 11:54 PM · Restricted Project, Harbormaster
epriestley updated the task description for T13102: Plans: 2018 Week 11 Bonus Content.
Mar 15 2018, 11:30 PM · Plans
arend.danielek added a watcher for Security: arend.danielek.
Mar 15 2018, 9:46 PM
arend.danielek awarded T11932: Manual Activity: Rebuild Search Index a Love token.
Mar 15 2018, 8:29 PM · Search, Guides
janitorial awarded T13105: Plans: Rich presentation and diff rendering pipelines for various file types a Pterodactyl token.
Mar 15 2018, 1:49 PM · Plans, Files, Differential, Diffusion
zacchiro added a comment to T5505: Plan Legalpad v2.

It would be nice if exemptions could be granted for all members of a given Phabricator group, rather than only on a user basis.
Use case: having a group of employees of a given organization, who don't need to sign a DCO-like document, because their employment contracts take care of it; while at the same time requiring DCO signing by external contributors.

Mar 15 2018, 9:03 AM · Restricted Project, Restricted Project
epriestley closed T13106: Task detail pages are issuing an egregious number of queries? as Resolved.

Some of this got fixed, some ended up in T13081.

Mar 15 2018, 3:37 AM · Performance
epriestley committed rP2b5c73fc3d70: In "Analyze Query Plans" mode, collect service call stack traces in DarkConsole (authored by epriestley).
In "Analyze Query Plans" mode, collect service call stack traces in DarkConsole
Mar 15 2018, 3:34 AM
epriestley closed D19221: In "Analyze Query Plans" mode, collect service call stack traces in DarkConsole.
Mar 15 2018, 3:34 AM
epriestley committed rPHU1ad42491e44a: Add a ServiceProfiler mode to collect traces (authored by epriestley).
Add a ServiceProfiler mode to collect traces
Mar 15 2018, 3:34 AM
epriestley closed D19220: Add a ServiceProfiler mode to collect traces.
Mar 15 2018, 3:34 AM
epriestley committed rARC49a3ae9dad4c: Improve help and prompts for the "--draft" flag (authored by epriestley).
Improve help and prompts for the "--draft" flag
Mar 15 2018, 3:24 AM
epriestley closed D19229: Improve help and prompts for the "--draft" flag.
Mar 15 2018, 3:24 AM
epriestley requested review of D19229: Improve help and prompts for the "--draft" flag.
Mar 15 2018, 3:23 AM

Mar 14 2018

epriestley closed T9950: Provide a URL that indicates Harbormaster build status as an image as Wontfix.
Mar 14 2018, 9:24 PM · Restricted Project, Harbormaster, Feature Request
epriestley added a comment to T13106: Task detail pages are issuing an egregious number of queries?.

With that stuff, we're down from 473 to 227 on T9950. That's still awful, but not quite as ridiculous.

Mar 14 2018, 9:24 PM · Performance
epriestley closed T10102: No way to control PonderAnswer emails/notifications as Wontfix.

See T13069 for mail stamp plans.

Mar 14 2018, 9:18 PM · Restricted Project, Ponder
epriestley closed T10122: ctrl+enter to commit in all fields as Wontfix.
Mar 14 2018, 9:18 PM · Restricted Project, ApplicationEditor, Feature Request
epriestley closed T10078: Implement global readthrough cache pools as Resolved.

This was largely tackled above.

Mar 14 2018, 9:17 PM · Restricted Project, Infrastructure, Performance
epriestley committed rPaf8269d2fb06: Allow draft revisions to be commandeered (authored by epriestley).
Allow draft revisions to be commandeered
Mar 14 2018, 9:04 PM
epriestley closed D19228: Allow draft revisions to be commandeered.
Mar 14 2018, 9:04 PM
epriestley requested review of D19228: Allow draft revisions to be commandeered.
Mar 14 2018, 9:02 PM
epriestley committed rPcd7ba6cd7bf9: Improve documentation around using Mail stamps with Gmail (authored by epriestley).
Improve documentation around using Mail stamps with Gmail
Mar 14 2018, 8:09 PM
epriestley closed D19227: Improve documentation around using Mail stamps with Gmail.
Mar 14 2018, 8:09 PM
epriestley requested review of D19227: Improve documentation around using Mail stamps with Gmail.
Mar 14 2018, 8:08 PM
epriestley added a revision to T13069: Make mail stamps routable on the server, include transaction information, and replace mail tags: D19227: Improve documentation around using Mail stamps with Gmail.
Mar 14 2018, 8:07 PM · Mail
epriestley committed rPf348721aed42: When loading project membership to evaluate the "Subscribers" policy, use the… (authored by epriestley).
When loading project membership to evaluate the "Subscribers" policy, use the…
Mar 14 2018, 7:59 PM
epriestley closed D19226: When loading project membership to evaluate the "Subscribers" policy, use the ominipotent viewer.
Mar 14 2018, 7:59 PM
epriestley requested review of D19226: When loading project membership to evaluate the "Subscribers" policy, use the ominipotent viewer.
Mar 14 2018, 7:51 PM
epriestley added a revision to T13106: Task detail pages are issuing an egregious number of queries?: D19226: When loading project membership to evaluate the "Subscribers" policy, use the ominipotent viewer.
Mar 14 2018, 7:49 PM · Performance
epriestley committed rPce6e020d5ddb: Don't make an expensive, unused call to test if a viewer can reassign a task (authored by epriestley).
Don't make an expensive, unused call to test if a viewer can reassign a task
Mar 14 2018, 7:46 PM
epriestley closed D19225: Don't make an expensive, unused call to test if a viewer can reassign a task.
Mar 14 2018, 7:46 PM
epriestley committed rPd80a53abccc7: Skip loading file transform sources when we know a file is not transformed (authored by epriestley).
Skip loading file transform sources when we know a file is not transformed
Mar 14 2018, 7:45 PM
epriestley closed D19224: Skip loading file transform sources when we know a file is not transformed.
Mar 14 2018, 7:45 PM
epriestley committed rP31bd3679f025: Skip loading attached objects for files when we know the file is visible (authored by epriestley).
Skip loading attached objects for files when we know the file is visible
Mar 14 2018, 7:36 PM
epriestley closed D19223: Skip loading attached objects for files when we know the file is visible.
Mar 14 2018, 7:36 PM
epriestley committed rP49e6358fce27: Bulk load builtin project default profile images (authored by epriestley).
Bulk load builtin project default profile images
Mar 14 2018, 7:35 PM
epriestley closed D19222: Bulk load builtin project default profile images.
Mar 14 2018, 7:35 PM
epriestley added a comment to T13106: Task detail pages are issuing an egregious number of queries?.

I'm having some difficulty merging (5) and (6), or either of them into (2). My local test also has a lot of nonsense going on that a real install shouldn't. I'm going to land what I've got so far and see how much progress we've made here.

Mar 14 2018, 7:33 PM · Performance
epriestley requested review of D19225: Don't make an expensive, unused call to test if a viewer can reassign a task.
Mar 14 2018, 7:15 PM
epriestley added a revision to T13106: Task detail pages are issuing an egregious number of queries?: D19225: Don't make an expensive, unused call to test if a viewer can reassign a task.
Mar 14 2018, 7:14 PM · Performance
epriestley added a comment to T13106: Task detail pages are issuing an egregious number of queries?.

Queries are down to 139 for me locally.

Mar 14 2018, 7:10 PM · Performance
epriestley requested review of D19224: Skip loading file transform sources when we know a file is not transformed.
Mar 14 2018, 6:59 PM
epriestley added a revision to T13106: Task detail pages are issuing an egregious number of queries?: D19224: Skip loading file transform sources when we know a file is not transformed.
Mar 14 2018, 6:57 PM · Performance
epriestley added a comment to T13106: Task detail pages are issuing an egregious number of queries?.

Queries are now down from 151 to 145 for me locally.

Mar 14 2018, 6:48 PM · Performance
epriestley requested review of D19223: Skip loading attached objects for files when we know the file is visible.
Mar 14 2018, 6:48 PM
epriestley added a revision to T13106: Task detail pages are issuing an egregious number of queries?: D19223: Skip loading attached objects for files when we know the file is visible.
Mar 14 2018, 6:47 PM · Performance
epriestley added a comment to T13106: Task detail pages are issuing an egregious number of queries?.

Next problem:

Mar 14 2018, 6:34 PM · Performance
epriestley requested review of D19222: Bulk load builtin project default profile images.
Mar 14 2018, 6:26 PM
epriestley added a comment to T13106: Task detail pages are issuing an egregious number of queries?.

For my local test task (T369), the initial page query load was 199 queries. After D19222 we're down slightly to 151 queries.

Mar 14 2018, 6:26 PM · Performance
epriestley added a revision to T13106: Task detail pages are issuing an egregious number of queries?: D19222: Bulk load builtin project default profile images.
Mar 14 2018, 6:25 PM · Performance
epriestley updated the task description for T13105: Plans: Rich presentation and diff rendering pipelines for various file types.
Mar 14 2018, 6:24 PM · Plans, Files, Differential, Diffusion
epriestley requested review of D19221: In "Analyze Query Plans" mode, collect service call stack traces in DarkConsole.
Mar 14 2018, 6:09 PM
epriestley added a revision to T13106: Task detail pages are issuing an egregious number of queries?: D19221: In "Analyze Query Plans" mode, collect service call stack traces in DarkConsole.
Mar 14 2018, 6:08 PM · Performance
epriestley updated the task description for T13106: Task detail pages are issuing an egregious number of queries?.
Mar 14 2018, 6:05 PM · Performance
epriestley requested review of D19220: Add a ServiceProfiler mode to collect traces.
Mar 14 2018, 5:55 PM
epriestley added a revision to T13106: Task detail pages are issuing an egregious number of queries?: D19220: Add a ServiceProfiler mode to collect traces.
Mar 14 2018, 5:55 PM · Performance
epriestley added a comment to T13106: Task detail pages are issuing an egregious number of queries?.

Some of this is:

Mar 14 2018, 5:53 PM · Performance
epriestley updated the task description for T13106: Task detail pages are issuing an egregious number of queries?.
Mar 14 2018, 5:31 PM · Performance
epriestley updated the task description for T13081: Quicksand breaks the back button after a reload, et al.
Mar 14 2018, 5:27 PM · Quicksand
epriestley triaged T13106: Task detail pages are issuing an egregious number of queries? as Normal priority.
Mar 14 2018, 5:17 PM · Performance
epriestley closed T9972: Profile image from Google not being picked up as Wontfix.
Mar 14 2018, 5:11 PM · Auth, Bug Report
epriestley closed T10004: ApplicationEditor Errata as Resolved.
Mar 14 2018, 5:11 PM · ApplicationEditor
epriestley closed T10061: Split the view policy into "space" and "visible to" line in forms as Wontfix.
Mar 14 2018, 5:09 PM · Maniphest, Spaces, Feature Request
epriestley closed T10103: Proxied object policies are not evaluated in the proper context as Resolved.

This was resolved by the introduction of PhabricatorExtendedPolicyInterface. Older cases with missing policy proxies occasionally crop up, but I believe most of them are resolved at HEAD of master. These errors always fail closed (deny access which should be acceptable), never fail open (allow impermissible access) so there's no urgency to hunting them down.

Mar 14 2018, 5:04 PM · Policy
epriestley updated the task description for T13064: `arc patch` can fail when a non-UTF8 file is detected as binary and moved (?).
Mar 14 2018, 3:30 PM · Arcanist, Differential
epriestley committed rP403dd629362d: Update the "Support Resources" documentation for pacts instead of consulting (authored by epriestley).
Update the "Support Resources" documentation for pacts instead of consulting
Mar 14 2018, 3:27 PM
epriestley closed D19219: Update the "Support Resources" documentation for pacts instead of consulting.
Mar 14 2018, 3:27 PM
epriestley requested review of D19219: Update the "Support Resources" documentation for pacts instead of consulting.
Mar 14 2018, 3:21 PM
epriestley edited the content of Welcome.
Mar 14 2018, 3:10 PM
epriestley edited the content of Paid Prioritization.
Mar 14 2018, 3:09 PM
epriestley edited the content of Consulting.
Mar 14 2018, 3:06 PM
epriestley updated the task description for T13105: Plans: Rich presentation and diff rendering pipelines for various file types.
Mar 14 2018, 2:55 PM · Plans, Files, Differential, Diffusion
epriestley updated the task description for T13105: Plans: Rich presentation and diff rendering pipelines for various file types.
Mar 14 2018, 2:48 PM · Plans, Files, Differential, Diffusion
epriestley closed T2849: Implement alternate markup engines (Markdown, reStructuredText, ...) as Wontfix.

See followup in T13105.

Mar 14 2018, 6:45 AM · Remarkup
epriestley closed T2849: Implement alternate markup engines (Markdown, reStructuredText, ...), a subtask of T2815: Render Remarkup files in Diffusion, as Wontfix.
Mar 14 2018, 6:45 AM · Diffusion
epriestley closed T5698: Github-style Remarkup previews on a checked-in resource as Wontfix.

See followup in T13105.

Mar 14 2018, 6:45 AM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup
epriestley added a project to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Plans.
Mar 14 2018, 6:43 AM · Plans, Files, Differential, Diffusion
epriestley triaged T13105: Plans: Rich presentation and diff rendering pipelines for various file types as Normal priority.
Mar 14 2018, 6:43 AM · Plans, Files, Differential, Diffusion