Paths

Table of Contentst

Differential D19228

Allow draft revisions to be commandeered
ClosedPublic
Actions

Authored by epriestley on Mar 14 2018, 9:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Feb 20, 4:52 PM

	Unknown Object (File)
	Thu, Feb 20, 4:52 PM

	Unknown Object (File)
	Thu, Feb 20, 4:52 PM

	Unknown Object (File)
	Thu, Feb 20, 4:52 PM

	Unknown Object (File)
	Sun, Feb 9, 5:43 AM

	Unknown Object (File)
	Sun, Feb 9, 5:43 AM

	Unknown Object (File)
	Sun, Feb 9, 5:43 AM

	Unknown Object (File)
	Sun, Feb 9, 5:43 AM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rPaf8269d2fb06: Allow draft revisions to be commandeered

Summary

See PHI457. There's no real reason not to allow this, it just wasn't clear if it was useful. See D18626.

An install had a user arc diff and then sprint out the door to take a very long vacation before the builds finished. One failed, so the revision is stuck as a draft forever. This seems like a reasonable motivation for allowing "Commandeer".

Test Plan

Successfully commandeered a draft.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 14 2018, 9:01 PM

Harbormaster completed remote builds in B19856: Diff 46039.Mar 14 2018, 9:02 PM

epriestley requested review of this revision.Mar 14 2018, 9:02 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 14 2018, 9:04 PM

Closed by commit rPaf8269d2fb06: Allow draft revisions to be commandeered (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

xaction/

DifferentialRevisionCommandeerTransaction.php

5 lines

Diff 46040

View Options

src/applications/differential/xaction/DifferentialRevisionCommandeerTransaction.php

Allow draft revisions to be commandeeredClosedPublicActions