Differential D19220

Add a ServiceProfiler mode to collect traces
ClosedPublic
Actions

Authored by epriestley on Mar 14 2018, 5:55 PM.

Tags

None

Referenced Files

	F14011715: D19220.diff
	Fri, Nov 1, 5:10 AM

	F14000469: D19220.diff
	Thu, Oct 24, 10:00 PM

	F13966465: D19220.id46025.diff
	Oct 16 2024, 8:08 AM

	Unknown Object (File)
	Sep 14 2024, 9:07 AM

	Unknown Object (File)
	Sep 6 2024, 2:49 AM

	Unknown Object (File)
	Sep 6 2024, 2:49 AM

	Unknown Object (File)
	Sep 6 2024, 2:49 AM

	Unknown Object (File)
	Sep 4 2024, 4:06 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13106: Task detail pages are issuing an egregious number of queries?
Commits: rPHU47cfa511ca67: (stable) Promote 2018 Week 11
rPHU1ad42491e44a: Add a ServiceProfiler mode to collect traces

Summary

Ref T13106. This is a little awkward (the traces are blobs of text in a denormalized format with redundant library version information) but better than nothing.

Test Plan

In a future change, made "Analyze Query Plans" enable stack trace mode. Collected and rendered stack traces.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 14 2018, 5:55 PM

Harbormaster completed remote builds in B19842: Diff 46025.Mar 14 2018, 5:55 PM

epriestley requested review of this revision.Mar 14 2018, 5:55 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 15 2018, 3:34 AM

Closed by commit rPHU1ad42491e44a: Add a ServiceProfiler mode to collect traces (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

serviceprofiler/

PhutilServiceProfiler.php

18 lines

Diff 46043

View Options

src/serviceprofiler/PhutilServiceProfiler.php

Add a ServiceProfiler mode to collect tracesClosedPublicActions