Page MenuHomePhabricator

Clarify that a PHUITagView API argument is boolean, not a value in "millimeters"
ClosedPublic

Authored by epriestley on Mar 16 2018, 8:08 PM.
Tags
None
Referenced Files
F18757875: D19231.diff
Sun, Oct 5, 7:54 PM
F18740829: D19231.id.diff
Thu, Oct 2, 6:02 AM
F18738151: D19231.diff
Wed, Oct 1, 2:20 PM
F18733782: D19231.id.diff
Tue, Sep 30, 10:41 PM
F18647972: D19231.diff
Fri, Sep 19, 3:25 PM
F18509447: D19231.id.diff
Sep 5 2025, 3:24 AM
F18502409: D19231.diff
Sep 4 2025, 10:25 PM
F18227462: D19231.id.diff
Aug 20 2025, 6:14 AM
Subscribers
None

Details

Summary

See PHI454. Ref T13102. This parameter is not named as clearly as it could be.

This is a buff to API humor.

See also https://secure.phabricator.com/differential/diff/46024/.

Test Plan

Read API method, laughed aloud ("LAL") much harder because the humor was now less subtle. Subtle humor is unsuitable for this project.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 16 2018, 8:09 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.