Page MenuHomePhabricator

Clarify that a PHUITagView API argument is boolean, not a value in "millimeters"
ClosedPublic

Authored by epriestley on Mar 16 2018, 8:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 11:33 PM
Unknown Object (File)
Jan 23 2024, 9:27 AM
Unknown Object (File)
Jan 18 2024, 7:43 PM
Unknown Object (File)
Jan 11 2024, 12:13 PM
Unknown Object (File)
Jan 6 2024, 8:43 PM
Unknown Object (File)
Dec 29 2023, 1:40 PM
Unknown Object (File)
Dec 23 2023, 6:18 AM
Unknown Object (File)
Dec 21 2023, 11:41 PM
Subscribers
None

Details

Summary

See PHI454. Ref T13102. This parameter is not named as clearly as it could be.

This is a buff to API humor.

See also https://secure.phabricator.com/differential/diff/46024/.

Test Plan

Read API method, laughed aloud ("LAL") much harder because the humor was now less subtle. Subtle humor is unsuitable for this project.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 16 2018, 8:09 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.