Differential D19231

Clarify that a PHUITagView API argument is boolean, not a value in "millimeters"
ClosedPublic
Actions

Authored by epriestley on Mar 16 2018, 8:08 PM.

Tags

None

Referenced Files

	F18804277: D19231.id46050.diff
	Sat, Oct 18, 7:10 AM

	F18803882: D19231.id46050.diff
	Sat, Oct 18, 4:27 AM

	F18766640: D19231.id46048.diff
	Tue, Oct 7, 5:42 PM

	F18757875: D19231.diff
	Sun, Oct 5, 7:54 PM

	F18740829: D19231.id.diff
	Thu, Oct 2, 6:02 AM

	F18738151: D19231.diff
	Wed, Oct 1, 2:20 PM

	F18733782: D19231.id.diff
	Tue, Sep 30, 10:41 PM

	F18647972: D19231.diff
	Sep 19 2025, 3:25 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13102: Plans: 2018 Week 11 Bonus Content
Commits: rP667955b8aeca: Clarify that a PHUITagView API argument is boolean, not a value in "millimeters"

Summary

See PHI454. Ref T13102. This parameter is not named as clearly as it could be.

This is a buff to API humor.

Test Plan

Read API method, laughed aloud ("LAL") much harder because the humor was now less subtle. Subtle humor is unsuitable for this project.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 16 2018, 8:08 PM

Harbormaster completed remote builds in B19865: Diff 46048.Mar 16 2018, 8:09 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 16 2018, 8:09 PM

epriestley requested review of this revision.

Closed by commit rP667955b8aeca: Clarify that a PHUITagView API argument is boolean, not a value in "millimeters" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

phui/

PHUITagView.php

4 lines

Diff 46050

View Options

src/view/phui/PHUITagView.php

Clarify that a PHUITagView API argument is boolean, not a value in "millimeters"ClosedPublicActions