Page MenuHomePhabricator

Skip loading file transform sources when we know a file is not transformed
ClosedPublic

Authored by epriestley on Mar 14 2018, 6:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 5:43 AM
Unknown Object (File)
Sun, Feb 9, 5:43 AM
Unknown Object (File)
Sun, Feb 9, 5:43 AM
Unknown Object (File)
Mon, Jan 27, 5:49 AM
Unknown Object (File)
Sat, Jan 25, 12:44 AM
Unknown Object (File)
Sat, Jan 25, 12:44 AM
Unknown Object (File)
Sat, Jan 25, 12:44 AM
Unknown Object (File)
Wed, Jan 22, 11:04 PM
Subscribers
None

Details

Summary

Depends on D19223. Ref T13106. When we're loading a file, we currently test if it's a transformed version of another file (usually, a thumbnail) and apply policy behavior if it is.

We know that builtins and profile images are never transforms and that the policy behavior for these files doesn't matter anyway. Skip loading transforms for these files.

Test Plan

Saw local queries drop from 146 to 139 with no change in behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable