Page MenuHomePhabricator

Improve help and prompts for the "--draft" flag
ClosedPublic

Authored by epriestley on Mar 15 2018, 3:22 AM.
Tags
None
Referenced Files
F14025763: D19229.diff
Thu, Nov 7, 8:01 PM
F14010252: D19229.id46041.diff
Thu, Oct 31, 6:43 AM
F14004822: D19229.diff
Sun, Oct 27, 3:16 AM
F14003413: D19229.id46041.diff
Sat, Oct 26, 5:57 AM
F13999271: D19229.id46042.diff
Thu, Oct 24, 1:52 PM
F13955895: D19229.id46041.diff
Mon, Oct 14, 3:26 AM
Unknown Object (File)
Fri, Oct 11, 1:52 AM
Unknown Object (File)
Sep 21 2024, 1:43 AM
Subscribers
None

Details

Summary

See PHI458. The help text and prompting for "arc diff --draft" aren't very clear about whether updating publishes or not, nor about whether you need to keep passing "--draft" every time.

Make these behaviors more clear.

Test Plan
  • Ran arc help diff, read text.
  • Updated a draft with "--draft", got new warning but it went through.
  • Updated a published revision with "--draft", got new error.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 15 2018, 3:23 AM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.