Improve help and prompts for the "--draft" flag
ClosedPublic
Actions

Authored by epriestley on Mar 15 2018, 3:22 AM.

Tags

None

Referenced Files

	F15375339: D19229.id.diff
	Wed, Mar 12, 10:42 PM

	F15334153: D19229.id46041.diff
	Sat, Mar 8, 7:06 AM

	F15334152: D19229.id46041.diff
	Sat, Mar 8, 7:06 AM

	F15332019: D19229.diff
	Fri, Mar 7, 4:04 PM

	F15332018: D19229.diff
	Fri, Mar 7, 4:04 PM

	F15302834: D19229.id46042.diff
	Wed, Mar 5, 10:42 PM

	F15302833: D19229.id46042.diff
	Wed, Mar 5, 10:42 PM

	Unknown Object (File)
	Feb 4 2025, 4:01 AM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rARC49a3ae9dad4c: Improve help and prompts for the "--draft" flag

Summary

See PHI458. The help text and prompting for "arc diff --draft" aren't very clear about whether updating publishes or not, nor about whether you need to keep passing "--draft" every time.

Make these behaviors more clear.

Test Plan

Ran arc help diff, read text.
Updated a draft with "--draft", got new warning but it went through.
Updated a published revision with "--draft", got new error.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 15 2018, 3:22 AM

Harbormaster completed remote builds in B19858: Diff 46041.Mar 15 2018, 3:23 AM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 15 2018, 3:23 AM

epriestley requested review of this revision.

Closed by commit rARC49a3ae9dad4c: Improve help and prompts for the "--draft" flag (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistDiffWorkflow.php

38 lines

Diff 46042

View Options

src/workflow/ArcanistDiffWorkflow.php

Improve help and prompts for the "--draft" flagClosedPublicActions