Page MenuHomePhabricator

Improve help and prompts for the "--draft" flag
ClosedPublic

Authored by epriestley on Mar 15 2018, 3:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 3:33 AM
Unknown Object (File)
Sat, Nov 16, 8:20 AM
Unknown Object (File)
Tue, Nov 12, 10:33 AM
Unknown Object (File)
Tue, Nov 12, 6:50 AM
Unknown Object (File)
Thu, Nov 7, 8:01 PM
Unknown Object (File)
Thu, Oct 31, 6:43 AM
Unknown Object (File)
Oct 27 2024, 3:16 AM
Unknown Object (File)
Oct 26 2024, 5:57 AM
Subscribers
None

Details

Summary

See PHI458. The help text and prompting for "arc diff --draft" aren't very clear about whether updating publishes or not, nor about whether you need to keep passing "--draft" every time.

Make these behaviors more clear.

Test Plan
  • Ran arc help diff, read text.
  • Updated a draft with "--draft", got new warning but it went through.
  • Updated a published revision with "--draft", got new error.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 15 2018, 3:23 AM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.