Page MenuHomePhabricator
Create Task
Maniphest T13102

Plans: 2018 Week 11 Bonus Content
Closed, ResolvedPublic
Actions

Description

See PHI406. An install would like configurable favicons for development/staging/production installs.

See PHI433. An install would like to improve some of the messaging around drafts.

See PHI431. An install would like to support a nuanced workflow in review actions that probably doesn't make sense as a default upstream workflow but may mesh with T731 and which we may be able to provide some support for.

See PHI427. An install would like a way to render a short Doorkeeper external object reference. Update: this is hard because Doorkeeper uses the remote object reference as a cache key in both client and server workflows, and can't currently distinguish between different views of the same object. Not insurmountable but should actually get proper testing.

See PHI442. See T12994. This is probably worth resolving since it has cropped up again. Guidance for optimizer_search_depth=0 may also be warranted.

See PHI451. An ancient inline Javascript handler in DarkConsole violates the CSP header.

See PHI467. An install is hitting T8845 with L3 in a header.

See PHI364. An install encountered a held lock issue in a cluster which resolved itself immediately when I appeared onsite. It seemed plausible that this was because read synchronization does not put a timeout on git fetch, so if git fetch hangs for some network-related reason the lock could be held indefinitely.

See https://discourse.phabricator-community.org/t/desktop-only-notifications-mode-is-broken/1234/1. The "Desktop Only" notification mode seems to not be functioning properly.

See PHI461. An install would like slugs in project.search.

See PHI454. An install identified an opportunity to improve a joke in the API.

See PHI430. An install has identified a reproducible case where a policy exception causes a hard fatal instead of a graceful policy error.

Revisions and Commits

rP Phabricator
D19234rP2fa904921e1a Render object monograms and embedding references more gracefully when building…
D19233rPdbc72a05bc39 Correct the behavior of "Desktop Only" in Notifications preferences
D19232rPfa6cd200e878 Reduce the severity of policy fatals when building the Harbormaster "build…
D19231rP667955b8aeca Clarify that a PHUITagView API argument is boolean, not a value in "millimeters"
D19230rPc216fd40728b Allow projects to be queried by slug in "project.search"
D19218rPdc7e40ff3fc7 Fix the DarkConsole inline error log stack trace expansion behavior for Content…
D19215rP2b19f91936f2 Allow Doorkeeper references to have multiple display variations (full, short…
D19211rP1e93b49b1bf2 Allow custom actions in Differential to explicitly override "accept" stickiness
D19210rPdf8d4dff679b Raise a warning when mentioning a user in a comment on a draft revision

Related Objects
Search...

Event Timeline

epriestley triaged this task as Normal priority.Mar 9 2018, 4:03 PM
epriestley created this task.
Herald added subscribers: faulconbridge, eadler. · View Herald TranscriptMar 9 2018, 4:03 PM
epriestley updated the task description. (Show Details)Mar 9 2018, 4:04 PM
epriestley mentioned this in T13099: Plans: 2018 Week 10 Bonus Content.
epriestley updated the task description. (Show Details)Mar 12 2018, 5:30 PM
epriestley added a revision: D19210: Raise a warning when mentioning a user in a comment on a draft revision.Mar 12 2018, 11:08 PM
epriestley added a revision: D19211: Allow custom actions in Differential to explicitly override "accept" stickiness.Mar 12 2018, 11:54 PM
epriestley added a commit: rPdf8d4dff679b: Raise a warning when mentioning a user in a comment on a draft revision.Mar 13 2018, 12:03 AM
epriestley added a commit: rP1e93b49b1bf2: Allow custom actions in Differential to explicitly override "accept" stickiness.Mar 13 2018, 12:10 AM
epriestley added a revision: D19215: Allow Doorkeeper references to have multiple display variations (full, short, etc.).Mar 13 2018, 6:15 PM
epriestley added a comment.Mar 13 2018, 6:24 PM

While testing D19215 I ran into this behavior in Asana:

Screen Shot 2018-03-13 at 11.12.08 AM.png (228×640 px, 36 KB)

Those buttons just fill in the literal text written on the button, almost. They've been programmed very carefully -- for example, "Quick question..." fills Quick question (no trailing space) while "I can start on this by..." fills I can start on this by (with a trailing space), probably because the former phrase likely needs punctuation (like : or ,) while the latter does not.

the quick replies only show when someone has assigned you a task that you have yet to comment on, with the goal to encourage folks to acknowledge their tasks :slight_smile:
https://community.asana.com/t/new-in-asana-quick-replies/6910

This feature shipped in August 2017, apparently can not be customized or disabled, and is utterly mystifying to me.

epriestley added a commit: rP2b19f91936f2: Allow Doorkeeper references to have multiple display variations (full, short….Mar 13 2018, 6:29 PM
epriestley added a comment.Mar 13 2018, 7:06 PM

It appears that MYSQLI_ASYNC depends mostly on mysqlnd ("MySQL Native Driver"). This has been the default since PHP 5.3 was released in 200 BC, but Ubuntu, at least, unbundles it and you can still install php5-mysql (non-native driver). Compounding this, we currently recommend installs install php5-mysql (bad), rather than php5-msyqlnd (good).

It looks like apt-get install php5-mysqlnd just works correctly and replaces the nonnative driver with the native driver, so that's likely easy.

I also found this gem:

"Recommend you work on speeding up each query. Parallel execution in PHP ... is mostly a myth."
https://dba.stackexchange.com/a/111884

epriestley mentioned this in T12994: Add a setup warning if MYSQLI_ASYNC is not defined (support for MySQLi async).Mar 13 2018, 7:38 PM
epriestley updated the task description. (Show Details)Mar 13 2018, 11:07 PM
epriestley added a revision: D19218: Fix the DarkConsole inline error log stack trace expansion behavior for Content-Security-Policy.Mar 13 2018, 11:39 PM
epriestley added a commit: rPdc7e40ff3fc7: Fix the DarkConsole inline error log stack trace expansion behavior for Content….Mar 13 2018, 11:45 PM
epriestley updated the task description. (Show Details)Mar 15 2018, 11:30 PM
epriestley updated the task description. (Show Details)Mar 16 2018, 7:28 PM
epriestley added a revision: D19230: Allow projects to be queried by slug in "project.search".Mar 16 2018, 7:56 PM
epriestley updated the task description. (Show Details)Mar 16 2018, 7:57 PM
epriestley added a revision: D19231: Clarify that a PHUITagView API argument is boolean, not a value in "millimeters".Mar 16 2018, 8:08 PM
epriestley added a commit: rPc216fd40728b: Allow projects to be queried by slug in "project.search".Mar 16 2018, 8:08 PM
epriestley added a commit: rP667955b8aeca: Clarify that a PHUITagView API argument is boolean, not a value in "millimeters".Mar 16 2018, 8:11 PM
epriestley added a revision: D19232: Reduce the severity of policy fatals when building the Harbormaster "build status" element.Mar 16 2018, 8:26 PM
epriestley added a commit: rPfa6cd200e878: Reduce the severity of policy fatals when building the Harbormaster "build….Mar 16 2018, 8:28 PM
epriestley added a revision: D19233: Correct the behavior of "Desktop Only" in Notifications preferences.Mar 16 2018, 10:13 PM
epriestley added a commit: rPdbc72a05bc39: Correct the behavior of "Desktop Only" in Notifications preferences.Mar 16 2018, 10:17 PM
epriestley updated the task description. (Show Details)Mar 16 2018, 10:24 PM
epriestley added a revision: D19234: Render object monograms and embedding references more gracefully when building a Remarkup table of contents.Mar 16 2018, 10:37 PM
epriestley added a commit: rP2fa904921e1a: Render object monograms and embedding references more gracefully when building….Mar 16 2018, 10:44 PM
epriestley added a comment.Mar 16 2018, 10:56 PM

See PHI364. An install encountered a held lock issue in a cluster which resolved itself immediately when I appeared onsite.

I'm still expecting to fix this today but I'm going to roll it forward until after the release cut since the install in question isn't on a bleeding edge version right now and it wouldn't hurt to let this change soak for more than 5 minutes before it goes to stable.

See PHI431. An install would like to support a nuanced workflow in review actions...

This morphed into a bit of a bigger change and isn't fully resolved yet.

See PHI430. ... a policy exception causes a hard fatal instead of a graceful policy error.

This is improved in master but continued in T13088.

Everything else here should be resolved in master and promoting to stable shortly.

epriestley closed this task as Resolved.Mar 16 2018, 10:56 PM
epriestley mentioned this in T13108: Plans: 2018 Week 12 Bonus Content.
epriestley mentioned this in T12993: Datasource queries with many "JOIN ... LIKE" can have explosive complexity.Mar 19 2018, 2:55 PM
Phabricator · Built by Phacility