Differential D19226

When loading project membership to evaluate the "Subscribers" policy, use the ominipotent viewer
ClosedPublic
Actions

Authored by epriestley on Mar 14 2018, 7:49 PM.

Tags

None

Referenced Files

	F17711941: D19226.diff
	Thu, Jul 17, 9:20 AM

	Unknown Object (File)
	Wed, Jul 2, 9:49 PM

	Unknown Object (File)
	Apr 29 2025, 5:47 PM

	Unknown Object (File)
	Apr 19 2025, 11:31 AM

	Unknown Object (File)
	Apr 3 2025, 6:41 PM

	Unknown Object (File)
	Mar 29 2025, 6:56 AM

	Unknown Object (File)
	Mar 28 2025, 7:37 PM

	Unknown Object (File)
	Mar 21 2025, 9:42 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13106: Task detail pages are issuing an egregious number of queries?
Commits: rPf348721aed42: When loading project membership to evaluate the "Subscribers" policy, use the…

Summary

See PHI448. Ref T13106. The current implementation here can end up in an infinite stack if, e.g., a project uses "Visible to: Subscribers".

Test Plan

Will push.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 14 2018, 7:49 PM

Harbormaster completed remote builds in B19852: Diff 46035.Mar 14 2018, 7:51 PM

epriestley requested review of this revision.Mar 14 2018, 7:51 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 14 2018, 7:59 PM

Closed by commit rPf348721aed42: When loading project membership to evaluate the "Subscribers" policy, use the… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

subscriptions/

policyrule/

PhabricatorSubscriptionsSubscribersPolicyRule.php

7 lines

Diff 46036

View Options

src/applications/subscriptions/policyrule/PhabricatorSubscriptionsSubscribersPolicyRule.php

When loading project membership to evaluate the "Subscribers" policy, use the ominipotent viewerClosedPublicActions