Page MenuHomePhabricator
Differential D19226

When loading project membership to evaluate the "Subscribers" policy, use the ominipotent viewer
ClosedPublic
Actions

Authored by epriestley on Mar 14 2018, 7:49 PM.
Tags
None
Referenced Files
F18771958: D19226.id.diff
Wed, Oct 8, 11:14 PM
F18740821: D19226.id.diff
Thu, Oct 2, 5:58 AM
F18739317: D19226.diff
Wed, Oct 1, 8:53 PM
F18733777: D19226.id.diff
Tue, Sep 30, 10:41 PM
F18703183: D19226.id46036.diff
Sun, Sep 28, 3:13 AM
F18656465: D19226.id46035.diff
Sep 22 2025, 10:33 PM
F18651397: D19226.diff
Sep 21 2025, 4:16 AM
F18509443: D19226.id.diff
Sep 5 2025, 3:24 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13106: Task detail pages are issuing an egregious number of queries?
Commits
rPf348721aed42: When loading project membership to evaluate the "Subscribers" policy, use the…
Summary

See PHI448. Ref T13106. The current implementation here can end up in an infinite stack if, e.g., a project uses "Visible to: Subscribers".

Test Plan

Will push.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 14 2018, 7:49 PM
Harbormaster completed remote builds in B19852: Diff 46035.Mar 14 2018, 7:51 PM
epriestley requested review of this revision.Mar 14 2018, 7:51 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 14 2018, 7:59 PM
Closed by commit rPf348721aed42: When loading project membership to evaluate the "Subscribers" policy, use the… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
subscriptions/
policyrule/
7 lines

Diff 46036

View Options

src/applications/subscriptions/policyrule/PhabricatorSubscriptionsSubscribersPolicyRule.php

Loading...
Phabricator · Built by Phacility