Page MenuHomePhabricator
Feed All Stories

Jul 21 2016

markwei added a comment to T11251: Diff dependency should cause shared lines to be hidden.

Got it. Another quick comment: arc branch unfortunately does not work well for the HEAD~ workflow.

Jul 21 2016, 1:52 AM · Feature Request
epriestley added a comment to T11251: Diff dependency should cause shared lines to be hidden.

See T11343 for discussion of automatic "Depends On" detection. Briefly: desirable, but also complicated in the general case.

Jul 21 2016, 1:41 AM · Feature Request
markwei added a comment to T11251: Diff dependency should cause shared lines to be hidden.

Thanks for the explanations. I can appreciate the complexity and the multitudes of workflows which I am certainly not thinking of.

Jul 21 2016, 1:38 AM · Feature Request

Jul 20 2016

bapt updated the task description for T11351: Move Pholio to EditEngine and modern APIs.
Jul 20 2016, 10:40 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
avivey added a comment to T11353: Uploaded file "isn't redirecting properly".

That explains it then; I'm not used to being complimented about my eyesight :P

Jul 20 2016, 10:39 PM · Bug Report
anton.vladimirov created T11354: Given a link to a file in a large review, navigating to that link should automatically load the linked file.
Jul 20 2016, 10:11 PM · Restricted Project, Bug Report
epriestley added a comment to T11353: Uploaded file "isn't redirecting properly".

Clearly we should have a Services starting with "CloudF..." header.

Jul 20 2016, 9:51 PM · Bug Report
jonah214 added a comment to T11353: Uploaded file "isn't redirecting properly".

I'm using CloudFront. That explains why I ignored the note, though; it
doesn't apply to me!

Jul 20 2016, 9:36 PM · Bug Report
epriestley closed T11351: Move Pholio to EditEngine and modern APIs as Invalid.

Please read Contributing Feature Requests carefully before filing feature requests. In particular, we need you to describe a root problem (see Describing Root Problems).

Jul 20 2016, 9:35 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a comment to T11353: Uploaded file "isn't redirecting properly".

@jonah214 said he's using CloudFront (AWS) while that note is about CloudFlare (an unrelated product/company with a nearly identical name) so I'm suspicious there may be more to this than meets the eye (or maybe CloudFront was a typo).

Jul 20 2016, 9:30 PM · Bug Report
chad added a comment to T11353: Uploaded file "isn't redirecting properly".

I think we owe @avivey another lunch at this pace. Such eyesight!

Jul 20 2016, 9:24 PM · Bug Report
epriestley added a comment to T11353: Uploaded file "isn't redirecting properly".

I added you to Community, so you should have sweeping janitorial powers now.

Jul 20 2016, 9:05 PM · Bug Report
epriestley added a member for Community: jonah214.
Jul 20 2016, 9:05 PM
avivey closed T11353: Uploaded file "isn't redirecting properly" as Resolved.
Jul 20 2016, 9:04 PM · Bug Report
jonah214 added a comment to T11353: Uploaded file "isn't redirecting properly".

I must have missed what @avivey pointed out. Thanks! Sorry to bother you guys.

Jul 20 2016, 9:04 PM · Bug Report
avivey added a comment to T11353: Uploaded file "isn't redirecting properly".

Did you see the note in https://secure.phabricator.com/book/phabricator/article/configuring_file_domain/#approach-cloudflare ?

Jul 20 2016, 8:45 PM · Bug Report
epriestley added a comment to T11353: Uploaded file "isn't redirecting properly".

I can't reproduce this. Here's what I did:

Jul 20 2016, 8:45 PM · Bug Report
jonah214 created T11353: Uploaded file "isn't redirecting properly".
Jul 20 2016, 8:42 PM · Bug Report
chad renamed T8937: Unclear exception when patching non-existant revision from Invalid argument supplied for foreach() to Unclear exception when patching non-existant revision.
Jul 20 2016, 6:55 PM · Arcanist
chad merged task T11352: arc patch with invalid revision number fails with an exception into T8937: Unclear exception when patching non-existant revision.
Jul 20 2016, 6:55 PM · Arcanist, Feature Request
chad merged T11352: arc patch with invalid revision number fails with an exception into T8937: Unclear exception when patching non-existant revision.
Jul 20 2016, 6:55 PM · Arcanist
eadler added a project to T11352: arc patch with invalid revision number fails with an exception: Arcanist.
Jul 20 2016, 6:14 PM · Arcanist, Feature Request
eadler added projects to T11351: Move Pholio to EditEngine and modern APIs: Pholio, Conduit.
Jul 20 2016, 6:13 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
jsturgeon added a comment to T10109: Differental does not trigger Herald for mundane updates.

I'm curious, is there any other way to trigger Herald to process a Differential review *other* than uploading a new diff?

Jul 20 2016, 6:09 PM · Differential, Restricted Project, Herald, Bug Report
jsturgeon updated the answer wiki for Q447: Herald rules don't trigger on differential 'update'.
Jul 20 2016, 4:56 PM · Herald
jsturgeon closed Q447: Herald rules don't trigger on differential 'update' as resolved.
Jul 20 2016, 4:55 PM · Herald
jsturgeon added a comment to Q447: Herald rules don't trigger on differential 'update' (Answer 421).

Yes! Thank you.. that's it, closing this question.

Jul 20 2016, 4:55 PM
avivey added Q447: Herald rules don't trigger on differential 'update' (Answer 421).
Jul 20 2016, 4:25 PM
nochum added a comment to T4181: Document (the lack of) init scripts for phd, and be more explicit about `phd launch`.

I have created an upstart service for Ubuntu 14.04 LTS. Create a file /etc/init/phd.conf and save the following:

I was not able to use this script in any of my installations, it always causes bootup/shutdown to hang and does not properly start the phd daemons. For some reason, phd for me has been very difficult to get up and running with upstart scripts. Whatever I do, calling service phd start always results in just a hang. If anyone has any insight into how I can do this, would be greatly appreciated. I'm running Ubuntu.

Jul 20 2016, 4:07 PM · Phabricator
chad added Q450: How to address a concern by using a new code check in? (Answer 420).
Jul 20 2016, 4:05 PM
ronaldpringadi updated Q450: How to address a concern by using a new code check in? from to How to address a concern by using a new code check in?.
Jul 20 2016, 4:01 PM · Audit
• pena updated Q449: Using Harbormaster and Drydock - Is there a possibility to check out a certain branch? from to Using Harbormaster and Drydock - Is there a possibility to check out a certain branch?.
Jul 20 2016, 4:00 PM · Harbormaster, Drydock
jsturgeon added a comment to Q447: Herald rules don't trigger on differential 'update'.

Yes, nothing is in the transcript, in other words, no job was triggered

Jul 20 2016, 2:15 PM · Herald
sascha-egerer renamed T11352: arc patch with invalid revision number fails with an exception from arc patch with revision number fails with an exception to arc patch with invalid revision number fails with an exception.
Jul 20 2016, 10:29 AM · Arcanist, Feature Request
benjumanji added a comment to Q447: Herald rules don't trigger on differential 'update'.

I won't comment on the specifics, but have you looked at the herald transcript? I normally find the answer hiding in there.

Jul 20 2016, 10:10 AM · Herald
sascha-egerer created T11352: arc patch with invalid revision number fails with an exception.
Jul 20 2016, 9:56 AM · Arcanist, Feature Request
bapt created T11351: Move Pholio to EditEngine and modern APIs.
Jul 20 2016, 9:00 AM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
hach-que added a comment to T11350: Harbormaster Buildables list should show repository name.

For example, this is what it looks like on our instance:

Jul 20 2016, 8:38 AM · Restricted Project, Harbormaster, Feature Request
hach-que created T11350: Harbormaster Buildables list should show repository name.
Jul 20 2016, 8:25 AM · Restricted Project, Harbormaster, Feature Request
sascha-egerer awarded T5568: Support `.arcunit`, similar to `.arclint` a Hungry Hippo token.
Jul 20 2016, 5:24 AM · Unit, Arcanist
jsturgeon added a comment to T11349: Herald has the wrong list of "Author's Projects".

no.. they've been a part of that project since the beginning

Jul 20 2016, 12:21 AM · Restricted Project, Herald, Bug Report
jsturgeon updated Q448: Is there a way to update a differential comment using conduit? from to Is there a way to update a differential comment using conduit?.
Jul 20 2016, 12:20 AM · Conduit

Jul 19 2016

avivey added a comment to T11349: Herald has the wrong list of "Author's Projects".

If you're not allowed to see PHID-PROJ-rwnekrajar5m6diprobx, it will not be returned from project.query. Herald should be seeing all projects though, so PHID-PROJ-quo7cpreceuh6hnor3pw missing is strange.

Jul 19 2016, 11:03 PM · Restricted Project, Herald, Bug Report
jsturgeon added a comment to T11349: Herald has the wrong list of "Author's Projects".

yes... they're secret :)

Jul 19 2016, 10:56 PM · Restricted Project, Herald, Bug Report
avivey renamed T11349: Herald has the wrong list of "Author's Projects" from Herald has the wrong list of project authors to Herald has the wrong list of "Author's Projects".
Jul 19 2016, 10:17 PM · Restricted Project, Herald, Bug Report
avivey added a comment to T11349: Herald has the wrong list of "Author's Projects".

Is there anything special about the projects PHID-PROJ-rwnekrajar5m6diprobx and PHID-PROJ-quo7cpreceuh6hnor3pw? Is any of them secret?

Jul 19 2016, 10:17 PM · Restricted Project, Herald, Bug Report
jsturgeon created T11349: Herald has the wrong list of "Author's Projects".
Jul 19 2016, 9:07 PM · Restricted Project, Herald, Bug Report
michaeljs1990 added a comment to Q446: Are harbormaster builds cancellable? (Answer 419).

I have had users request this as well and we actually have a custom application that makes use of this. When you do this you run into other problems such as harbormaster doesn't clean up after tasks. That becomes the job of Drydock and you will have to write your own drydock blueprint to do this in any kind of sane way.

Jul 19 2016, 6:38 PM
jsturgeon added a project to Q447: Herald rules don't trigger on differential 'update': Herald.
Jul 19 2016, 6:28 PM · Herald
jsturgeon updated Q447: Herald rules don't trigger on differential 'update' from to Herald rules don't trigger on differential 'update'.
Jul 19 2016, 6:28 PM · Herald
jsturgeon closed Q446: Are harbormaster builds cancellable? as resolved.
Jul 19 2016, 6:24 PM · Herald, Harbormaster
chad added a comment to T5024: Provide a dedicated page for viewing a single workboard column.

I imagine this task is easier now that we have a "Move on Workboard" selector.

Jul 19 2016, 6:03 PM · Restricted Project, Workboards
jsturgeon added a project to Q446: Are harbormaster builds cancellable?: Herald.
Jul 19 2016, 6:02 PM · Herald, Harbormaster
jsturgeon added a comment to Q446: Are harbormaster builds cancellable? (Answer 419).

Thanks for the response, it does seem D15958 is what I am looking for.

Jul 19 2016, 6:02 PM
devd added a comment to T5024: Provide a dedicated page for viewing a single workboard column.

For the first case, maybe a column permalink would be a better solution? Then you could navigate back up the board easily. We can structure this as a search query instead (and it might not be bad to make that possible, for Dashboard panels) but it will lose some context. There's also no control which will easily let you select a column right now, and building a nice one is probably a fair bit of work (plus, it overlaps a lot with some other less well-defined tasks and infrastructure-blocked things).

Jul 19 2016, 6:01 PM · Restricted Project, Workboards
avivey added Q446: Are harbormaster builds cancellable? (Answer 419).
Jul 19 2016, 5:49 PM
jsturgeon updated Q446: Are harbormaster builds cancellable? from to Are harbormaster builds cancellable?.
Jul 19 2016, 5:26 PM · Herald, Harbormaster
chad merged T11347: Don't send notifications about restricted operations only into T10745: Emails are sent out about restricted changes.
Jul 19 2016, 3:24 PM · Restricted Project, Bug Report
chad merged task T11347: Don't send notifications about restricted operations only into T10745: Emails are sent out about restricted changes.
Jul 19 2016, 3:24 PM · Feature Request
chad closed T11346: Phabricator + Gitlab Integration as Invalid.

This doesn't appear to be a bug report. See Support Resources for how to get help with Phabricator.

Jul 19 2016, 3:20 PM · Bug Report
chad closed T11348: Save cutom policy as Invalid.

This doesn't appear to be a bug report. See Support Resources for how to get help with Phabricator.

Jul 19 2016, 3:18 PM · Bug Report
rabahmeradi created T11348: Save cutom policy.
Jul 19 2016, 2:03 PM · Bug Report
timor created T11347: Don't send notifications about restricted operations only.
Jul 19 2016, 12:11 PM · Feature Request
sanoob created T11346: Phabricator + Gitlab Integration .
Jul 19 2016, 10:12 AM · Bug Report
• Cain1127 added a comment to Q445: svn not work with some log, need help, please..

svn is used today. It never used before. So, I not sure whether it can work before. My install is out of date, this means need to update phabricator?

Jul 19 2016, 6:46 AM
20after4 added a comment to T11312: Watch / Subscribe project Herald action needed.

I think the root problem here is that "Herald added a subscriber: $user" is seen as email-spammy yet people are unwilling to edit their preferences to disable notifications for subscription-changes.

Jul 19 2016, 6:42 AM · Herald, Feature Request
chad added a comment to Q445: svn not work with some log, need help, please..

Does the error occur after you update Phabricator? Your install is out of date.

Jul 19 2016, 4:52 AM
chad closed T11345: phabricator svn error~ as Invalid.

This doesn't appear to be a valid bug report. You must update Phabricator before filing a bug report (your logs indicate you are a month behind), and you must provide steps we can reproduce the bug.

Jul 19 2016, 4:48 AM · Bug Report
• Cain1127 updated Q445: svn not work with some log, need help, please. from to svn not work with some log, need help, please..
Jul 19 2016, 4:35 AM
epriestley closed T11342: Table 'phabricator_metamta.metamta_mailinglist' doesn't exist in phabricator/bin/upgrade storage as Resolved.
Jul 19 2016, 4:33 AM · Bug Report
• soul.lwj created T11345: phabricator svn error~.
Jul 19 2016, 4:21 AM · Bug Report
asachau added a comment to T11342: Table 'phabricator_metamta.metamta_mailinglist' doesn't exist in phabricator/bin/upgrade storage.

Though I don't completely understand the specifics, I do have this issue resolved.

#1146: Table 'phabricator_metamta.metamta_mailinglist' doesn't exist

is an error from MySQL, and not from Phabricator. I believe the problem started when I restored the database from a backup. Rather that using a dump/restore, I rolled back to a previous filesystem snapshot on my database server. That filesystem snapshot contained :

mysql/phabricator_metamta/metamta_mailinglist.frm	
mysql/phabricator_metamta/metamta_mailinglist.ibd

database files. That particular table, however, no longer exists in the current versions of Phabricator. Once I removed those two files from the database server and restarted the MySQL server, the bin/storage upgrade command worked without error.

Jul 19 2016, 12:26 AM · Bug Report

Jul 18 2016

CodeMouse92 added a comment to T10750: Cannot Edit Comment on Files.

Awesome, thanks @epriestley. The update cron script runs that bin/storage upgrade every time.

Jul 18 2016, 11:22 PM · Files, Bug Report
epriestley added a comment to T10750: Cannot Edit Comment on Files.

Note that you need to bin/storage upgrade after picking up D16312 for this change to take effect. You should normally be doing this anyway, just mentioning it since it's not obvious that this would require database adjustments.

Jul 18 2016, 11:20 PM · Files, Bug Report
epriestley closed T10750: Cannot Edit Comment on Files as Resolved by committing Restricted Diffusion Commit.
Jul 18 2016, 11:17 PM · Files, Bug Report
epriestley added a comment to T11344: Differential commit message parser immediately rejects objects the user can't see, but Herald can put them there.

I think arc actually calls differential.getcommitmessage and then passes the result right back to differential.parsecommitmessage to split it into fields. That could/should work differently than it does.

Jul 18 2016, 11:04 PM · Unknown Object (Project), Differential, Arcanist, Bug Report
epriestley added a comment to T11343: Generate default "Depends on" line in commit message when multiple diffs are stacked.

This is desirable, but complicated in the general case. T3875 (and T3875#182020 in particular) has some discussion of a similar identification problem at the other end of the workflow, in arc land.

Jul 18 2016, 11:03 PM · Differential, Arcanist, Feature Request
avivey added a comment to T11344: Differential commit message parser immediately rejects objects the user can't see, but Herald can put them there.

Where did the phid get to the user anyway? If it's arc diff --update, it shouldn't try to parse the comment, and if it's arc diff --create, it shouldn't have any tags?

Jul 18 2016, 11:02 PM · Unknown Object (Project), Differential, Arcanist, Bug Report
epriestley added a comment to T11344: Differential commit message parser immediately rejects objects the user can't see, but Herald can put them there.

We can have this render "Tags: PHID-PROJ-abcdef" instead, which is an "improvement".

Jul 18 2016, 10:44 PM · Unknown Object (Project), Differential, Arcanist, Bug Report
epriestley awarded T11344: Differential commit message parser immediately rejects objects the user can't see, but Herald can put them there a Hungry Hippo token.
Jul 18 2016, 10:39 PM · Unknown Object (Project), Differential, Arcanist, Bug Report
michaeljs1990 added a comment to T11344: Differential commit message parser immediately rejects objects the user can't see, but Herald can put them there.

No this is just a general bug report since it's a fairly confusing error message for end users.

Jul 18 2016, 10:36 PM · Unknown Object (Project), Differential, Arcanist, Bug Report
avivey added a comment to T11344: Differential commit message parser immediately rejects objects the user can't see, but Herald can put them there.

Are you looking for alternative ways to block commits, or is this a bug report about "arc diff fails when revision has secret project tags?"

Jul 18 2016, 10:35 PM · Unknown Object (Project), Differential, Arcanist, Bug Report
michaeljs1990 renamed T11344: Differential commit message parser immediately rejects objects the user can't see, but Herald can put them there from Block user from landing diffs to differential.parsecommitmessage error parsing restricted projects.
Jul 18 2016, 10:34 PM · Unknown Object (Project), Differential, Arcanist, Bug Report
michaeljs1990 added a project to T11344: Differential commit message parser immediately rejects objects the user can't see, but Herald can put them there: Unknown Object (Project).
Jul 18 2016, 10:32 PM · Unknown Object (Project), Differential, Arcanist, Bug Report
michaeljs1990 created T11344: Differential commit message parser immediately rejects objects the user can't see, but Herald can put them there.
Jul 18 2016, 10:29 PM · Unknown Object (Project), Differential, Arcanist, Bug Report
sgrimm added a comment to T11343: Generate default "Depends on" line in commit message when multiple diffs are stacked.

Obviously I can implement this myself locally, but if it's a lousy idea for whatever reason, I'm hoping filing this request will cause someone to warn me off it.

Jul 18 2016, 10:27 PM · Differential, Arcanist, Feature Request
sgrimm created T11343: Generate default "Depends on" line in commit message when multiple diffs are stacked.
Jul 18 2016, 10:26 PM · Differential, Arcanist, Feature Request
epriestley added a revision to T10750: Cannot Edit Comment on Files: Restricted Differential Revision.
Jul 18 2016, 8:16 PM · Files, Bug Report
epriestley added a comment to T11171: When clicking an image in the comment edit modal, the image modal gets under the edit modal.

T8200 describes a somewhat-similar issue.

Jul 18 2016, 7:54 PM · Lightbox, Bug Report
epriestley reopened T9828: Make migrating files less scary as "Open".

Well, that sounds scary.

Jul 18 2016, 7:54 PM · Restricted Project, Files
epriestley reopened T9828: Make migrating files less scary, a subtask of T7163: Convert Phacility file storage to use S3, as Open.
Jul 18 2016, 7:54 PM · Files, Phacility
chad added a comment to T11341: new svn create repository workflow a pain.

In general we want people to update if possible before filing a bug report. The reason is most real "bugs" are fixed usually same day reported. For example we had a recent "Repository is not attached" exception that was fixed same day, but we're still getting reports trickling in weeks later. Being on this week's stable is all we usually expect. HEAD of master is better, but not required.

Jul 18 2016, 7:53 PM · Bug Report
yelirekim added a comment to T9828: Make migrating files less scary.

I'm trying to figure out if I destroyed our files this weekend by migrating them or by using purge / compress.

Jul 18 2016, 7:53 PM · Restricted Project, Files
epriestley moved T10750: Cannot Edit Comment on Files from Backlog to vNext on the Files board.
Jul 18 2016, 7:52 PM · Files, Bug Report
epriestley closed T8865: Automatically compact storage as Wontfix.

Per above, I'd like to just fix issues here rather than add an automatic compaction process. I don't currently know how to generate un-compact files in modern code.

Jul 18 2016, 7:51 PM · Files
yelirekim added a comment to T9828: Make migrating files less scary.

Actually....

Jul 18 2016, 7:50 PM · Restricted Project, Files
epriestley closed T9828: Make migrating files less scary as Resolved.

Presuming this is fixed / irrelevant / not scary / resolved / something since I don't think this went anywhere elese, yell if not or I just forgot something (or we can follow up after T11044 if this is waiting on that),

Jul 18 2016, 7:49 PM · Restricted Project, Files
epriestley closed T9828: Make migrating files less scary, a subtask of T7163: Convert Phacility file storage to use S3, as Resolved.
Jul 18 2016, 7:49 PM · Files, Phacility
ofbeaton added a comment to T11341: new svn create repository workflow a pain.

First I apologise if I somehow came across with any hostility, that was certainly not my intent.

Jul 18 2016, 7:47 PM · Bug Report
• sshannin updated Q444: Associate old commits with new phabricator user from to Associate old commits with new phabricator user.
Jul 18 2016, 7:18 PM · Diffusion