Page MenuHomePhabricator
Create Task
Maniphest T10750

Cannot Edit Comment on Files
Closed, ResolvedPublic
Actions

Description

Every time I try to edit or delete my own comment on a File, I get an error:

#1062: Duplicate entry 'PHID-USER-e4345xf2rzjrcqcpwefc-PHID-XACT-FILE-63l2duvntgluzd5' for key 'key_draft'

On my own installation (updated each morning to latest stable) , this just quietly fails with a grayed out screen,, which doesn't go away until one refreshes. I suspect the same error in the background.

Steps to Duplicate:

  1. Create a comment on a File object.
  2. Edit the comment.
  3. Note the error message, and that the edit does not save.
  4. Try to delete your own comment.
  5. Note the error message again, and that the comment is not deleted.

Revisions and Commits

rP Phabricator
D16312rP56bd762dd3ed Allow file comments to be edited

Related Objects

Event Timeline

CodeMouse92 created this task.Apr 8 2016, 6:15 PM
Herald added a subscriber: eadler. · View Herald TranscriptApr 8 2016, 6:15 PM
CodeMouse92 mentioned this in F516556: Screenshot from 2015-06-19 14:04:38.png.Apr 8 2016, 6:16 PM
francois added a subscriber: francois.Apr 10 2016, 2:32 PM
joshuaspence added a subscriber: joshuaspence.May 9 2016, 9:43 PM
david.sumolight added a subscriber: david.sumolight.May 11 2016, 3:08 PM
plehmkuhl added a subscriber: plehmkuhl.Jul 6 2016, 11:13 AM

We are also able to reproduce this on our installation.
Currently we are using Version 05699388804fc6ae1df5a17559917d218c4ec26d of phabricator.

epriestley merged a task: T11318: Error when editing your previous comment on File page.Jul 12 2016, 12:49 PM
epriestley added subscribers: Danny_B, aklapper.
epriestley moved this task from Backlog to vNext on the Files board.Jul 18 2016, 7:52 PM
epriestley added a revision: D16312: Allow file comments to be edited.Jul 18 2016, 8:16 PM
epriestley closed this task as Resolved by committing rP56bd762dd3ed: Allow file comments to be edited.Jul 18 2016, 11:17 PM
epriestley added a commit: rP56bd762dd3ed: Allow file comments to be edited.
epriestley added a subscriber: epriestley.Jul 18 2016, 11:20 PM

Note that you need to bin/storage upgrade after picking up D16312 for this change to take effect. You should normally be doing this anyway, just mentioning it since it's not obvious that this would require database adjustments.

CodeMouse92 added a comment.Jul 18 2016, 11:22 PM

Awesome, thanks @epriestley. The update cron script runs that bin/storage upgrade every time.

Phabricator · Built by Phacility